From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B90CC00144 for ; Fri, 29 Jul 2022 13:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c3EIy8h/PWyxxrL8apPl9pdHIc+gGCsdUVMB6pkIjRs=; b=K+J59xC6FN/D0X +HN7jvCD+3+wueNU5f47f9AyHRi3t8jD2de6ABUcagqLYJ8YWZqpqGrxuiriYaFPUfRxL23Y/6sUy X45+xBAUmma1aM7PZMWhb0rbxvfqi4CpkIWc1B1GDNLfaGr/HT4iKASAX41xTJ/W036NP9JJ0DNPS VT+WUpfVXZx7lx6BCeeiwqO7OcPv1Koybid4IbpxvSs18eTDj5VRktS8G7RILWuSf4+fsgmj1wgWB TyI6HLTiIPiMRi5cdjbFSpzj6qGOKTWz0fh6uc42F8TcprfnyrAr1Ir6AZ83O43XKqOmqvrDnxfX9 gFQh6oniHIpynFSw0kVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHPba-004wUe-1p; Fri, 29 Jul 2022 13:00:38 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHPbW-004wMJ-0R for linux-arm-kernel@lists.infradead.org; Fri, 29 Jul 2022 13:00:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=XdavFnr3NTOj35v811lVkK4EGAq0Y5wwPjr+y4ndjCw=; b=CE5z5DIMlo9rn/DMcpohrXqlYG 6QfY03YNNAJsM0kpVtPhwFXZ/rmRPGaz2vwq4blCLgMfpDKamSZ6uanPwiKrhdbm/hIVy8VsmNhCT DaqgCFtwq4AbHj5XeTE6snAEBIdiN3jbUmwze3HoQJ/ht+mTK8/mqLhs104ihMWNmgrA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oHPb3-00BuuW-Tw; Fri, 29 Jul 2022 15:00:05 +0200 Date: Fri, 29 Jul 2022 15:00:05 +0200 From: Andrew Lunn To: Maxime Chevallier Cc: davem@davemloft.net, Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Horatiu.Vultur@microchip.com, Allan.Nielsen@microchip.com, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net-next 3/4] net: phy: Add helper to derive the number of ports from a phy mode Message-ID: References: <20220728145252.439201-1-maxime.chevallier@bootlin.com> <20220728145252.439201-4-maxime.chevallier@bootlin.com> <20220729093252.50977d5c@pc-10.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220729093252.50977d5c@pc-10.home> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220729_060034_073766_16C96A63 X-CRM114-Status: GOOD ( 20.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 29, 2022 at 09:32:52AM +0200, Maxime Chevallier wrote: > On Thu, 28 Jul 2022 23:32:36 +0200 > Andrew Lunn wrote: > > > > +int phy_interface_num_ports(phy_interface_t interface) > > > +{ > > > + switch (interface) { > > > + case PHY_INTERFACE_MODE_NA: > > > + case PHY_INTERFACE_MODE_INTERNAL: > > > + return 0; > > > > I've not yet looked at how this is used. Returning 0 could have > > interesting effects i guess? INTERNAL clearly does have some sort of > > path between the MAC and the PHY, so i think 1 would be a better > > value. NA is less clear, it generally means Don't touch. But again, > > there still needs to be a path between the MAC and PHY, otherwise > > there would not be any to touch. > > > > Why did you pick 0? > > > > > + > > > + case PHY_INTERFACE_MODE_MII: > > > + case PHY_INTERFACE_MODE_GMII: > > > + case PHY_INTERFACE_MODE_TBI: > > > + case PHY_INTERFACE_MODE_REVMII: > > > + case PHY_INTERFACE_MODE_RMII: > > > + case PHY_INTERFACE_MODE_REVRMII: > > > + case PHY_INTERFACE_MODE_RGMII: > > > + case PHY_INTERFACE_MODE_RGMII_ID: > > > + case PHY_INTERFACE_MODE_RGMII_RXID: > > > + case PHY_INTERFACE_MODE_RGMII_TXID: > > > + case PHY_INTERFACE_MODE_RTBI: > > > + case PHY_INTERFACE_MODE_XGMII: > > > + case PHY_INTERFACE_MODE_XLGMII: > > > + case PHY_INTERFACE_MODE_MOCA: > > > + case PHY_INTERFACE_MODE_TRGMII: > > > + case PHY_INTERFACE_MODE_USXGMII: > > > + case PHY_INTERFACE_MODE_SGMII: > > > + case PHY_INTERFACE_MODE_SMII: > > > + case PHY_INTERFACE_MODE_1000BASEX: > > > + case PHY_INTERFACE_MODE_2500BASEX: > > > + case PHY_INTERFACE_MODE_5GBASER: > > > + case PHY_INTERFACE_MODE_10GBASER: > > > + case PHY_INTERFACE_MODE_25GBASER: > > > + case PHY_INTERFACE_MODE_10GKR: > > > + case PHY_INTERFACE_MODE_100BASEX: > > > + case PHY_INTERFACE_MODE_RXAUI: > > > + case PHY_INTERFACE_MODE_XAUI: > > > + return 1; > > > + case PHY_INTERFACE_MODE_QSGMII: > > > + case PHY_INTERFACE_MODE_QUSGMII: > > > + return 4; > > > + > > > + default: > > > + return 0; > > > + } > > > +} > > > > Have you tried without a default: ? I _think_ gcc will then warn about > > missing enum values, which will help future developers when they add > > further values to the enum. > > Without the default clause, I get an error about the missing > PHY_INTERFACE_MODE_MAX case, which I don't think belongs here... case PHY_INTERFACE_MODE_MAX: WARN_ONCE() return 0; break; Being passed PHY_INTERFACE_MODE_MAX is a bug in itself, so warning seems sensible. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel