From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7D77C00144 for ; Fri, 29 Jul 2022 13:10:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T9+1dwELUa+PQ3qKcHdhJzX9lqVPYhpOfp715lORoJQ=; b=MTnCTYKHeMGoBe 8iymPxPmEsF15737hatpSlnD3065R43GTwxpgl3l50OzZZPqguVXwGtRj7aqQbvaFbfo46Kh4VUqd 6p0cYkFhOBw8tcJ7n8x3GsQAIeWlgORxTrv9u3FHGM5vovAXiRx9ixVLPI/1UVGrcwrxHg1daD+6b 5hzA+62/httvHkF+ycMm9Ykv3Vft+klpRf5ir0K193O8hgJ/ol8AxZp5llbHgBGN4kFgX8/oXjN/r fP1MlqWFjgBLN9Xs8PL1OkOPWF2qe8TVz/d1Q0U1iyBYYG5bHcjHX7KTP5ex2yUaV4HCOWHgyjiz6 277HVeI5qSSVZUvgdPvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHPjd-0051AY-2u; Fri, 29 Jul 2022 13:08:57 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHPjY-00517t-MY for linux-arm-kernel@lists.infradead.org; Fri, 29 Jul 2022 13:08:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=XV4FYkS/nsQW9JhqD1MLPoDv6thr9pzmU6vmVArakKA=; b=A+X10RUu2sgNy6OI75yTPLCpL4 pdimq9m6r+Irwi35Ae5QGvmdLS6ff/m6GGKdMzcSpfRdAH8dhMIxQ4Zk7qSIenpTP10PCFngmHkzt AtBagkT7qH0v+R36jBsoAP0qwh+RZLenM7dnMBfgAM+Tjo3PeVfCm0+jwnmJU6F7fysI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oHPjL-00Bv17-Va; Fri, 29 Jul 2022 15:08:39 +0200 Date: Fri, 29 Jul 2022 15:08:39 +0200 From: Andrew Lunn To: "Pandey, Radhey Shyam" Subject: Re: [PATCH net-next 2/2] net: macb: Add zynqmp SGMII dynamic configuration support Message-ID: References: <1658477520-13551-1-git-send-email-radhey.shyam.pandey@amd.com> <1658477520-13551-3-git-send-email-radhey.shyam.pandey@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220729_060852_781693_16CF1735 X-CRM114-Status: GOOD ( 11.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "git \(AMD-Xilinx\)" , "linux-kernel@vger.kernel.org" , "gregkh@linuxfoundation.org" , "michal.simek@xilinx.com" , "claudiu.beznea@microchip.com" , "edumazet@google.com" , "ronak.jain@xilinx.com" , "git@xilinx.com" , "netdev@vger.kernel.org" , "kuba@kernel.org" , "pabeni@redhat.com" , "davem@davemloft.net" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > > How robust is this? What if somebody specified a different power domain? > > > > Some background - init_reset_optional() fn is implemented for three > > platforms i.e., zynqmp, versal, MPFS. > > > > zynqmp_pm_set_gem_config API expect first argument as GEM node id so, > > power-domain DT property is passed to get node ID. > > > > However, power-domain property is read only if underlying firmware > > supports configuration of GEM secure space. It's only true for zynqmp SGMII > > case and for zynqmp power domain is fixed. > > In addition to it there is an error handling in power-domain property parsing. > > Hope this answers the question. > > Please let me know the implementation looks fine or needs any modification? Given that explanation, it looks fine. Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel