From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1574DC00140 for ; Tue, 2 Aug 2022 12:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iQ1M6SmfxQitGJLfPuPK0Yyc4xcArsUFsRWqCd5RqT8=; b=Dgasv0P3W8pPYu sII23+4Ux+9jVvhyHVGJF5y9S055DJYW+wMPzta7+7nDPiFZAzDerpIVjTlUUPK5AtgkP4nC/NCpx 4ywPpztDbdtEK68+6IuKWR2+/hpjXC6V7LiC1N6o6AxZOEsVHp5JuLF+c4g1F1v7XZu2DTdvnDSkI nzUUoSi37ti80eJg5bpRpP+Tdus4tMEec1vK6+ILOJgxYESyhRzO8VdiW84vYgwdr0+K+U0OrORMX DN4iMs/LDeq4NPGxE9mSi0aa4bXsLeo0/S3jDMdLVqSiA+NRsM4ylvufM2zUBq1RTcdkORfA5hC9r SbLa477RfzDHifUFP+yQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIr1w-00Dzbc-Of; Tue, 02 Aug 2022 12:29:48 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIr1s-00DzYq-Fn for linux-arm-kernel@lists.infradead.org; Tue, 02 Aug 2022 12:29:46 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7817B13D5; Tue, 2 Aug 2022 05:29:43 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.44.56]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 551603F67D; Tue, 2 Aug 2022 05:29:41 -0700 (PDT) Date: Tue, 2 Aug 2022 13:29:38 +0100 From: Mark Rutland To: Kalesh Singh Cc: "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , Mark Brown , Catalin Marinas , James Morse , "Madhavan T. Venkataraman" , Marc Zyngier , Fuad Tabba , Will Deacon Subject: Re: [PATCH 5/8] arm64: stacktrace: rework stack boundary discovery Message-ID: References: <20220801121209.2479449-1-mark.rutland@arm.com> <20220801121209.2479449-6-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220802_052944_594263_6D235CCC X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 01, 2022 at 10:22:45PM -0700, Kalesh Singh wrote: > On Mon, Aug 1, 2022 at 5:12 AM Mark Rutland wrote: > > static bool on_accessible_stack(const struct task_struct *tsk, > > unsigned long sp, unsigned long size, > > struct stack_info *info) > > { > > - if (info) > > - info->type = STACK_TYPE_UNKNOWN; > > - > > - return (on_overflow_stack(sp, size, info) || > > - on_hyp_stack(sp, size, info)); > > + struct stack_info tmp; > > + > > + tmp = stackinfo_get_overflow(); > > + if (stackinfo_on_stack(&tmp, sp, size)) > > + goto found; > > + > > + tmp = stackinfo_get_hyp(); > > + if (stackinfo_on_stack(&tmp, sp, size)) > > + goto found; > > + > > nit: Some trailing whitespaces in this function, checkpatch should catch it Whoops; I'll go throug the series and double-check for any more. Thanks for the heads up! > Reviewed-by: Kalesh Singh Thanks! Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel