From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E08BC19F2A for ; Thu, 4 Aug 2022 14:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uIKZDy/JdKanuI0FQbnd0BfOfsK1ChcxIOdnzERb3Ms=; b=oxiQinjvA/QpsD hH6KkKi82qpLI9ueUofwTef7PAJG8l9G3HFiMEVXfBq0MLwcc0tZhSLDnkwS6w4wJc9+1Q5C1eqyY U4b8SuoPF9hJzSqW1/pNoahBghxOjc7L/C5+taHmEA0+0smKoNgtATZfuess32fVuYc7EDmheetaO FOugNVD8dI1ophVKgKfYwEtsvnYWdJfqUqbgGa7eCOyMOEOQaRQcDNGMiFpTZ0yjT9rbezpFP8FBH IT2kFaSKG6OIVp82Rmsxh2dY1ghw8YX6w4txX0ixPYgVC2aBC7IZENtUJRl0AaJooNkz/nJNE3FXS omBDv/XkvgRynvlexpCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJc0P-006nqU-F4; Thu, 04 Aug 2022 14:39:21 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJc0M-006nnd-48 for linux-arm-kernel@lists.infradead.org; Thu, 04 Aug 2022 14:39:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7E21323A; Thu, 4 Aug 2022 07:39:15 -0700 (PDT) Received: from FVFF77S0Q05N.cambridge.arm.com (FVFF77S0Q05N.cambridge.arm.com [10.1.29.144]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 828013F73B; Thu, 4 Aug 2022 07:39:13 -0700 (PDT) Date: Thu, 4 Aug 2022 15:38:56 +0100 From: Mark Rutland To: linux-arm-kernel@lists.infradead.org Cc: broonie@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, kaleshsingh@google.com, madvenka@linux.microsoft.com, maz@kernel.org, tabba@google.com, will@kernel.org Subject: Re: [PATCH 3/8] arm64: stacktrace: move SDEI stack helpers to stacktrace code Message-ID: References: <20220801121209.2479449-1-mark.rutland@arm.com> <20220801121209.2479449-4-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220801121209.2479449-4-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220804_073918_258003_A073A607 X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 01, 2022 at 01:12:04PM +0100, Mark Rutland wrote: > diff --git a/arch/arm64/include/asm/stacktrace.h b/arch/arm64/include/asm/stacktrace.h > index 6ebdcdff77f56..fa2df1ea22ebc 100644 > --- a/arch/arm64/include/asm/stacktrace.h > +++ b/arch/arm64/include/asm/stacktrace.h > +#if defined(CONFIG_ARM_SDE_INTERFACE) && defined(CONFIG_VMAP_STACK) > +DECLARE_PER_CPU(unsigned long *, sdei_stack_normal_ptr); > +DECLARE_PER_CPU(unsigned long *, sdei_stack_critical_ptr); > diff --git a/arch/arm64/kernel/sdei.c b/arch/arm64/kernel/sdei.c > index d20620a1c51a4..881eece3422ca 100644 > --- a/arch/arm64/kernel/sdei.c > +++ b/arch/arm64/kernel/sdei.c > @@ -31,9 +31,6 @@ unsigned long sdei_exit_mode; > * sdei stack. > * For now, we allocate stacks when the driver is probed. > */ > -DECLARE_PER_CPU(unsigned long *, sdei_stack_normal_ptr); > -DECLARE_PER_CPU(unsigned long *, sdei_stack_critical_ptr); > - The kbuild test robot reported that removing these lines broke builds with CONFIG_SDE_INTERFACE=y && CONFIG_VMAP_STACK=n: https://lore.kernel.org/r/16ba6649-d680-69d4-dbd3-3b1ffb06319b@intel.com For now I've restored the declarations in sdei.c, as the alternative was to make the ifdeffery in stacktrace.h more convoluted. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel