From: Mark Brown <broonie@kernel.org>
To: patrice.chotard@foss.st.com
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
linux-spi@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, christophe.kerello@foss.st.com
Subject: Re: [PATCH v2 1/2] spi: stm32_qspi: Add transfer_one_message() spi callback
Date: Wed, 10 Aug 2022 14:06:46 +0100 [thread overview]
Message-ID: <YvOtZtrRHd4AT+j+@sirena.org.uk> (raw)
In-Reply-To: <20220810093215.794977-2-patrice.chotard@foss.st.com>
[-- Attachment #1.1: Type: text/plain, Size: 878 bytes --]
On Wed, Aug 10, 2022 at 11:32:14AM +0200, patrice.chotard@foss.st.com wrote:
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>
> v2: _ use parallel-memories property
> _ set auto_runtime_pm to true
> _ remove pm_runtime_*() usage in transfer_one_message() callback
> ---
The changelog should come after the --- so that it gets automatically
stripped out by tooling. No need to resend just for this.
> + /*
> + * Dual flash mode is only enable in case "parallel-memories" and
> + * "cs-gpios" properties are found in DT
> + */
> + if (of_property_read_bool(dev->of_node, "parallel-memories") &&
> + of_gpio_named_count(dev->of_node, "cs-gpios")) {
> + qspi->cr_reg = CR_DFM;
> + dev_dbg(dev, "Dual flash mode enable");
> + }
Do we need to add something to the DT bindings to indicate that
parallel-memories is valid?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-10 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 9:32 [PATCH v2 0/2] spi: stm32_qspi: use QSPI bus as 8 lines communication channel patrice.chotard
2022-08-10 9:32 ` [PATCH v2 1/2] spi: stm32_qspi: Add transfer_one_message() spi callback patrice.chotard
2022-08-10 13:06 ` Mark Brown [this message]
2022-08-10 13:15 ` Patrice CHOTARD
2022-08-10 13:23 ` Mark Brown
2022-08-10 13:31 ` Patrice CHOTARD
2022-08-10 13:40 ` Mark Brown
2022-08-10 13:52 ` Patrice CHOTARD
2022-08-10 13:57 ` Mark Brown
2022-08-10 9:32 ` [PATCH v2 2/2] ARM: dts: stm32: Create separate pinmux for qspi cs pin in stm32mp15-pinctrl.dtsi patrice.chotard
2022-08-22 16:05 ` (subset) [PATCH v2 0/2] spi: stm32_qspi: use QSPI bus as 8 lines communication channel Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvOtZtrRHd4AT+j+@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=christophe.kerello@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=patrice.chotard@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox