From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8763FC19F2D for ; Sat, 13 Aug 2022 18:05:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FFhS6vdMGcuPKmspAPemly9OJkJhEgrzbp1hNqvGzIE=; b=gofafnv13fNFW1 7t0jChreE7f/lO/kZtq+lMsP3uOEPMwDjGxuApWeErUVG3koa5COph0FG8NzxJ2aDUB+5sawesSXK cF7M1mslVKOHPh7ZBqHb6/S3M9FuAGUUpTXJgbG4lfIQqYlRilu2pVeuJ6n9YpQ5dnquqZDz/+27l lGRly8UOxCsIWaSf1jR6PEX0s+GYMqAKZfy4QQmD9rf+QxmZftIB5l7lKtcWqtOe8wgQgdSBC8Qul vhEEQpD+vQ6UlYcmKEifDe3J3tMYouqKYysnMdbdQAEqPvgYKVI0EHEf5ityunoA2nUrGb/MYQrv1 rrZ7aV/4yRH52E5B0ryw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMvUU-00GSX2-Tb; Sat, 13 Aug 2022 18:04:07 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMvUS-00GSW7-NB for linux-arm-kernel@bombadil.infradead.org; Sat, 13 Aug 2022 18:04:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=u5Qb3H8U740kA02vgkBBFYcLMaC60aOFu3/mruv1/hU=; b=B3epzjXkLKTia6d8iO0vXz5I2F frS19V3eNHXA9VHS9Ayv0dcn/NAnG3SMHsb1tM7TPoZ4PwX+SOIwMArmHWlh75i3Tqgu1wKtzS2sw 6GzovDRH5qnZ6ycmHyapFghBKg0aeSrYGwZC0DbaEPuKZvDatbeaNrJKt5XPDq8lr/q12ZGSVPPkQ nUFGIwyKiTY/dXBIDVcP8mj25m998LcbMAYPYuHaAKeaG09DGy5/7TNPwQFkcIkyIjy6rLp880akz SObNxqKlMHUkxw8b7EwfjfrFMt13JBj9/HDy2fpj5WfEMVTckYh2TQL3jwn0SzQjIf2zqWhDaPcYb vt/FMJug==; Received: from [187.19.239.32] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMvUO-001yrY-J6; Sat, 13 Aug 2022 18:04:01 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id A3F7E4035A; Sat, 13 Aug 2022 15:03:55 -0300 (-03) Date: Sat, 13 Aug 2022 15:03:55 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , Zhengjun Xing , Ravi Bangoria , Kan Liang , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH v5 00/14] Compress the pmu_event tables Message-ID: References: <20220812230949.683239-1-irogers@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220812230949.683239-1-irogers@google.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Fri, Aug 12, 2022 at 04:09:35PM -0700, Ian Rogers escreveu: > jevents.py creates a number of large arrays from the json events. The > arrays contain pointers to strings that need relocating. The > relocations have file size, run time and memory costs. These changes > refactor the pmu_events API so that the storage of the pmu_event > struct isn't exposed. The format is then changed to an offset within a > combined big string, with adjacent pmu_event struct variables being > next to each other in the string separated by \0 - meaning only the > first variable of the struct needs its offset recording. > > Some related fixes are contained with the patches. The architecture > jevents.py creates tables for can now be set by the JEVENTS_ARCH make > variable, with a new 'all' that generates the events and metrics for > all architectures. > > An example of the improvement to the file size on x86 is: > no jevents - the same 19,788,464bytes > x86 jevents - ~16.7% file size saving 23,744,288bytes vs 28,502,632bytes > all jevents - ~19.5% file size saving 24,469,056bytes vs 30,379,920bytes > default build options plus NO_LIBBFD=1. Applied locally, going thru further tests. - Arnaldo > I originally suggested fixing this problem in: > https://lore.kernel.org/linux-perf-users/CAP-5=fVB8G4bdb9T=FncRTh9oBVKCS=+=eowAO+YSgAhab+Dtg@mail.gmail.com/ > > v5. Renamed two functions to be more inline with the code and added > extra commit message detail on the event sorting order as > suggested by John Garry . > v4. Fixed an issue with the empty-pmu-events.c spotted by John Garry > . > v3. Fix an ARM build issue with a missed weak symbol. Perform some > pytype clean up. > v2. Split the substring folding optimization to its own patch and > comment tweaks as suggested by Namhyung Kim > . Recompute the file size savings with the > latest json events and metrics. > > Ian Rogers (14): > perf jevent: Add an 'all' architecture argument > perf jevents: Remove the type/version variables > perf jevents: Provide path to json file on error > perf jevents: Sort json files entries > perf pmu-events: Hide pmu_sys_event_tables > perf pmu-events: Avoid passing pmu_events_map > perf pmu-events: Hide pmu_events_map > perf test: Use full metric resolution > perf pmu-events: Move test events/metrics to json > perf pmu-events: Don't assume pmu_event is an array > perf pmu-events: Hide the pmu_events > perf metrics: Copy entire pmu_event in find metric > perf jevents: Compress the pmu_events_table > perf jevents: Fold strings optimization > > tools/perf/arch/arm64/util/pmu.c | 4 +- > .../arch/test/test_soc/cpu/metrics.json | 64 +++ > tools/perf/pmu-events/empty-pmu-events.c | 204 +++++++- > tools/perf/pmu-events/jevents.py | 478 +++++++++++++++--- > tools/perf/pmu-events/pmu-events.h | 40 +- > tools/perf/tests/expand-cgroup.c | 25 +- > tools/perf/tests/parse-metric.c | 77 +-- > tools/perf/tests/pmu-events.c | 466 +++++++---------- > tools/perf/util/metricgroup.c | 275 ++++++---- > tools/perf/util/metricgroup.h | 5 +- > tools/perf/util/pmu.c | 139 ++--- > tools/perf/util/pmu.h | 10 +- > tools/perf/util/s390-sample-raw.c | 50 +- > 13 files changed, 1131 insertions(+), 706 deletions(-) > create mode 100644 tools/perf/pmu-events/arch/test/test_soc/cpu/metrics.json > > -- > 2.37.1.595.g718a3a8f04-goog -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel