From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D3E3C25B0E for ; Mon, 15 Aug 2022 13:05:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J5imgw98A1aw3nfA8gIGIrUNhcgFrTEl5Jg35bgMpGM=; b=hu7CaPrMxX6Sdy 0X9JMdqo+QDtkgUmWpInrqnF5OSH33CSQXUwEKB72eT5lHsTE9CSk0hrcMi0G4StFTTzXoUWHXC1F qGmHFwn2HdCtXFet+0HiR7m4oH4gAGdkH6gdi5M2SmoOTHrr8MdhabxHyou8bCiPOY3SnjxRYpEHf IcHWttE87mJEKnBhGJIVv536QGMoXPCiNdGQtp28CSaRyjwGyrk/6ybI1BYALhGNNkKbHy2IqgSr1 R1Lm4RGcnH6P9YOAHNWv+7RKb0+UrwgShQeH19N7jgne7+wb5zDnOSdZfkZl0Uhu3RxEEWWJjJ73B l7bISL9/1Dy7IxHIf7/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNZkz-00GVCW-Ub; Mon, 15 Aug 2022 13:03:50 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNZku-00GV4P-IA for linux-arm-kernel@lists.infradead.org; Mon, 15 Aug 2022 13:03:45 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 60EAA80FB; Mon, 15 Aug 2022 12:56:48 +0000 (UTC) Date: Mon, 15 Aug 2022 16:03:37 +0300 From: Tony Lindgren To: Arnd Bergmann Cc: Daniel Lezcano , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel test robot Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Fix compile test warning Message-ID: References: <20220815120334.51887-1-tony@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220815_060344_800087_D0A86891 X-CRM114-Status: GOOD ( 20.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Arnd Bergmann [220815 12:48]: > On Mon, Aug 15, 2022 at 2:03 PM Tony Lindgren wrote: > > > > We can get a warning with COMPILE_TEST enabled for omap_timer_match > > for 'omap_timer_match' defined but not used. > > > > Fixes: ab0bbef3ae0f ("clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3") > > Reported-by: kernel test robot > > Signed-off-by: Tony Lindgren > > --- > > drivers/clocksource/timer-ti-dm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c > > --- a/drivers/clocksource/timer-ti-dm.c > > +++ b/drivers/clocksource/timer-ti-dm.c > > @@ -1040,7 +1040,7 @@ static const struct dmtimer_platform_data am6_pdata = { > > .timer_ops = &dmtimer_ops, > > }; > > > > -static const struct of_device_id omap_timer_match[] = { > > +static const __maybe_unused struct of_device_id omap_timer_match[] = { > > { > > .compatible = "ti,omap2420-timer", > > }, > > I think a better way to address this is to remove the of_match_ptr() > usage from the driver. The only reason to use of_match_ptr() is to save > a few bytes on machines that don't have CONFIG_OF enabled, but this > driver is not used on such machines any more. OK makes sense, will send v2 patch. Thanks, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel