From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 925D2C25B0F for ; Tue, 16 Aug 2022 04:17:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=Nx8Boyad25xSBetSnJHziVwCOuGK3DMOi9jmw328raw=; b=cfNKttEBvJQqhR oqRITwc8HmlW/1S15xieXsoihl6ZWgsxPBXsjs17dwzmAovtJ11z7IIxgbj+bpwJlYQxtW2vkw9bX YcYJZS6c7JvFktU4DnsxPrQ+PeOjYXeByzV2d46CDIsT8SclIN8moSOukuDsN2OcirrYKObMjAaRG gsQBo4n4zqh7AGJhzHrQaPlNjAOfH8xlRDngU/q68POiS41xI9kP/beaymlTkaAfFl/GgoHSi+CuM 2DE9nh4GMdxzw7qKAeXBFeNgdbx+VWhCck6yfOeiUtMv/SU56bfs+tJY+7tjEM6srpMs+fqgm5l1y SeBLf5IuUlxCenWU0Erg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNnzk-00APRU-Et; Tue, 16 Aug 2022 04:16:00 +0000 Received: from helcar.hmeau.com ([216.24.177.18] helo=fornost.hmeau.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNnzg-00APL2-Ks for linux-arm-kernel@lists.infradead.org; Tue, 16 Aug 2022 04:15:57 +0000 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oNnzO-00BTJq-2W; Tue, 16 Aug 2022 14:15:39 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Tue, 16 Aug 2022 12:15:38 +0800 Date: Tue, 16 Aug 2022 12:15:38 +0800 From: Herbert Xu To: Tejun Heo , Linus Torvalds Cc: marcan@marcan.st, will@kernel.org, peterz@infradead.org, jirislaby@kernel.org, maz@kernel.org, mark.rutland@arm.com, boqun.feng@gmail.com, catalin.marinas@arm.com, oneukum@suse.com, roman.penyaev@profitbricks.com, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] workqueue: Fix memory ordering race in queue_work*() Message-ID: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Newsgroups: apana.lists.os.linux.kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220815_211556_692594_2F581AC8 X-CRM114-Status: UNSURE ( 8.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Tejun Heo wrote: > > Oh, tricky one and yeah you're absolutely right that it makes no sense to > not guarantee barrier semantics when already pending. I didn't even know > test_and_set_bit() wasn't a barrier when it failed. Thanks a lot for hunting > down and fixing this. Applied to wq/for-6.0-fixes. Please revert this as test_and_set_bit was always supposed to be a full memory barrier. This is an arch bug. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel