From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55274C25B0E for ; Tue, 16 Aug 2022 16:27:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5nrJ1JdMEf19NjdTHAvFGFLcObwyh/a92KoF06p+8xo=; b=CrVs+1Ir/eCev2 xCJ9YSh3zFmBi0P56qpiDpHbrQ2PMK+oNFM6+2011VWazYMgmg5VCygDO4UsDt/y6As+5/+K9OUPz 0j+Vw2vsuZrr50xKpCLap5sCw4vQGkVlpzhm1DjBVTSziKvIzAsoRrVIH/S2QSsBSuEWJkrv2NG6N YqubsWL0Svv4I/WcuDW4SwK7g4D6mN3kq+BVyFF2suqNErtGh1+Kpv+PBT3RuDLs88g4Vd3MqJxFl TGJh7ibRcXY+HJFQ32Ciydxj87OZXA9jZw4mbDPMILd3LiuLDPr0z8ULliugujkzPlRiCKtYhw3j2 vBo9hFwXSnDu01qAQC1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNzP0-004YAr-MQ; Tue, 16 Aug 2022 16:26:50 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNzOw-004Y7b-Q7 for linux-arm-kernel@lists.infradead.org; Tue, 16 Aug 2022 16:26:48 +0000 Received: by mail-pl1-x62c.google.com with SMTP id p18so9666756plr.8 for ; Tue, 16 Aug 2022 09:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc; bh=ljLPeyJn0iV7kitzqLVt7KHdOIXq5hmQNIGV4Rf22NI=; b=jXPLtZvYYGW1UCSKcJdgu1Qq8Dj49ejW9ZdP9CCg/hqwv1bdbEY4wPJD1MAowdz/WT mM3FVSjRlhXKRvZgtCo0kM6Jq41EYfJP4r27COFSuti8y26r/GuQXgSRz27GvtKrMXcT EaJlN9jrbiJVSc0uUm3EkTyblrXhYhEJNRnqvwEXkQ0yovmOnig8MXCGcfFMdtcjXnYj qVCCWsLaNimCmMXYqLQoBwhUlzvgly9FLSDRjVCyhgYtXDzF5qwRpyvIEIf9+AcJyHE4 MG6kHbVv08KVZi1rlJGbVipz/eDBdBNBe8VMw0uoSVbnZN0TczWAdr54yVWeUH/LGbJ7 BrQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc; bh=ljLPeyJn0iV7kitzqLVt7KHdOIXq5hmQNIGV4Rf22NI=; b=C78Hd+4oPDr4RAwUzk3xCiXpZ65sG4V8u+R4PYP0UiR4tbTNgIb9WCTJI+lEJUphru 4Ap+8PvzdYg/76qzEQHdu/+h/3Nxj3KTbgxU3F0t1/XNllS1jJoQhhuCiyyjOf/u470q bOQnTQw2G9ST5wqIe0gwEZ+K0xvzx8YIv2uE4jsHXtNij8v0HMkB2mywCeKJI9DXVlbm msPO2pP4wDNOwtVTnun7jZUypuUVZqTbgKzKcpIB3TsyC382DwcySY+zfhu8SKLATJxC b9jzoeyml1PPvc5XZa8V47tlsHyQRI6eP9GNJWUFLGWu6DAKxLPwIqDava4K0pAPCODD uFTg== X-Gm-Message-State: ACgBeo07YcgV0VXhLie/+r0lN6nezQzBmwgNzDO9oUogc1EkmsEccQ1m 5jkg+HRDwx6z5CGFsUq9Ak3X2p9rI7Y= X-Google-Smtp-Source: AA6agR5bHivgn4E351xXewu5xhtK6GrUe9gmyfDOPVlKI+snri85TlL75sgjwzpP/K3IpUj8NJbEYA== X-Received: by 2002:a17:902:d151:b0:172:9361:2a11 with SMTP id t17-20020a170902d15100b0017293612a11mr1044157plt.148.1660667205379; Tue, 16 Aug 2022 09:26:45 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:7229]) by smtp.gmail.com with ESMTPSA id d2-20020a17090a02c200b001faae55c013sm133834pjd.52.2022.08.16.09.26.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 09:26:44 -0700 (PDT) Date: Tue, 16 Aug 2022 06:26:43 -1000 From: Tejun Heo To: Herbert Xu Cc: Linus Torvalds , marcan@marcan.st, will@kernel.org, peterz@infradead.org, jirislaby@kernel.org, maz@kernel.org, mark.rutland@arm.com, boqun.feng@gmail.com, catalin.marinas@arm.com, oneukum@suse.com, roman.penyaev@profitbricks.com, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] workqueue: Fix memory ordering race in queue_work*() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220816_092646_903504_55455564 X-CRM114-Status: GOOD ( 13.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On Tue, Aug 16, 2022 at 12:15:38PM +0800, Herbert Xu wrote: > Tejun Heo wrote: > > > > Oh, tricky one and yeah you're absolutely right that it makes no sense to > > not guarantee barrier semantics when already pending. I didn't even know > > test_and_set_bit() wasn't a barrier when it failed. Thanks a lot for hunting > > down and fixing this. Applied to wq/for-6.0-fixes. > > Please revert this as test_and_set_bit was always supposed to be > a full memory barrier. This is an arch bug. Alright, reverting. Thanks. -- tejun _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel