From: Baoquan He <bhe@redhat.com>
To: Yun Levi <ppbuk5246@gmail.com>
Cc: will@kernel.org, chenzhou10@huawei.com,
nramas@linux.microsoft.com, thunder.leizhen@huawei.com,
linux-arm-kernel@lists.infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kexec@lists.infradead.org
Subject: Re: [PATCH-RESEND] arm64/kexec: Fix missing extra range for crashkres_low.
Date: Tue, 30 Aug 2022 15:37:03 +0800 [thread overview]
Message-ID: <Yw2+H9MNpf3Ve0eJ@MiWiFi-R3L-srv> (raw)
In-Reply-To: <CAM7-yPTdihLsPjDKM-0OEszxNd8n0bgeRseiEkCsSZW-uuaRvw@mail.gmail.com>
On 08/30/22 at 01:28pm, Yun Levi wrote:
> Like crashk_res, Calling crash_exclude_mem_range function with
> crashk_low_res area would need extra crash_mem range too.
> Add one extra crash_mem range when crashk_low_res is used.
>
> Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
> ---
> arch/arm64/kernel/machine_kexec_file.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/kernel/machine_kexec_file.c
> b/arch/arm64/kernel/machine_kexec_file.c
> index 889951291cc0..378aee04e7d4 100644
> --- a/arch/arm64/kernel/machine_kexec_file.c
> +++ b/arch/arm64/kernel/machine_kexec_file.c
> @@ -51,6 +51,9 @@ static int prepare_elf_headers(void **addr, unsigned long *sz)
> for_each_mem_range(i, &start, &end)
> nr_ranges++;
>
> + if (crashk_low_res.end)
> + nr_ranges++; /**< for exclusion of
> crashkernel=size,low region */
> +
Right, excluding crashkernel region may cause memory region splitting,
so we need extra slot for that.
Meanwhile, can you fix above code comment mess? Otherwise, this looks
good to me.
Or we can add extra 2 slots like we do in x86, it just add another 16
bytes temporarily.
> cmem = kmalloc(struct_size(cmem, ranges, nr_ranges), GFP_KERNEL);
> if (!cmem)
> return -ENOMEM;
> --
> 2.35.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-30 7:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 15:12 [PATCH] arm64/kexec: Fix missing extra range for crashkres_low Levi Yun
2022-08-30 4:28 ` [PATCH-RESEND] " Yun Levi
2022-08-30 7:37 ` Baoquan He [this message]
2022-08-30 8:30 ` Yun Levi
2022-08-30 9:28 ` [PATCH v2] " Levi Yun
2022-08-30 12:46 ` Baoquan He
2022-08-30 16:40 ` Catalin Marinas
2022-08-31 0:38 ` Yun Levi
2022-08-31 1:18 ` Baoquan He
2022-08-31 1:31 ` Yun Levi
2022-08-31 1:49 ` [PATCH v2-RESEND] " Yun Levi
2022-08-31 10:26 ` Catalin Marinas
2022-08-31 10:29 ` Yun Levi
2022-08-31 10:39 ` [PATCH v3] " Levi Yun
2022-09-01 13:06 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw2+H9MNpf3Ve0eJ@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=chenzhou10@huawei.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=ppbuk5246@gmail.com \
--cc=thunder.leizhen@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).