From: Sean Christopherson <seanjc@google.com>
To: Andrew Jones <andrew.jones@linux.dev>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Marc Zyngier <maz@kernel.org>, Anup Patel <anup@brainfault.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Oliver Upton <oliver.upton@linux.dev>,
Atish Patra <atishp@atishpatra.org>,
David Hildenbrand <david@redhat.com>, Tom Rix <trix@redhat.com>,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm-riscv@lists.infradead.org,
linux-riscv@lists.infradead.org, llvm@lists.linux.dev,
linux-kernel@vger.kernel.org,
Colton Lewis <coltonlewis@google.com>,
Peter Gonda <pgonda@google.com>
Subject: Re: [PATCH v5 7/7] KVM: selftests: Add ucall pool based implementation
Date: Tue, 30 Aug 2022 04:27:04 +0000 [thread overview]
Message-ID: <Yw2RmCujuaOczFTY@google.com> (raw)
In-Reply-To: <20220829163627.qbafyl4qz5cxxue5@kamzik>
On Mon, Aug 29, 2022, Andrew Jones wrote:
> On Thu, Aug 25, 2022 at 11:25:22PM +0000, Sean Christopherson wrote:
> > +static struct ucall *ucall_alloc(void)
> > +{
> > + struct ucall *uc;
> > + int i;
> > +
> > + GUEST_ASSERT(ucall_pool && ucall_pool->in_use);
>
> ucall_pool->in_use will never be null.
>
> > +
> > + for (i = 0; i < KVM_MAX_VCPUS; ++i) {
> > + if (!atomic_test_and_set_bit(i, ucall_pool->in_use)) {
> > + uc = &ucall_pool->ucalls[i];
> > + memset(uc->args, 0, sizeof(uc->args));
> > + return uc;
> > + }
> > + }
>
> nit: blank line
Got 'em. Thanks for the reviews, much appreciated!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-30 4:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 23:25 [PATCH v5 0/7] KVM: selftests: Implement ucall "pool" (for SEV) Sean Christopherson
2022-08-25 23:25 ` [PATCH v5 1/7] KVM: selftests: Consolidate common code for populating ucall struct Sean Christopherson
2022-08-25 23:25 ` [PATCH v5 2/7] KVM: selftests: Consolidate boilerplate code in get_ucall() Sean Christopherson
2022-08-25 23:25 ` [PATCH v5 3/7] KVM: selftests: Automatically do init_ucall() for non-barebones VMs Sean Christopherson
2022-08-29 16:15 ` Andrew Jones
2022-08-25 23:25 ` [PATCH v5 4/7] tools: Add atomic_test_and_set_bit() Sean Christopherson
2022-08-25 23:25 ` [PATCH v5 5/7] KVM: selftests: Make arm64's MMIO ucall multi-VM friendly Sean Christopherson
2022-08-29 16:19 ` Andrew Jones
2022-08-25 23:25 ` [PATCH v5 6/7] KVM: selftest: Drop now-unnecessary ucall_uninit() Sean Christopherson
2022-08-29 16:21 ` Andrew Jones
2022-08-25 23:25 ` [PATCH v5 7/7] KVM: selftests: Add ucall pool based implementation Sean Christopherson
2022-08-29 16:36 ` Andrew Jones
2022-08-30 4:27 ` Sean Christopherson [this message]
2022-08-26 21:32 ` [PATCH v5 0/7] KVM: selftests: Implement ucall "pool" (for SEV) Peter Gonda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw2RmCujuaOczFTY@google.com \
--to=seanjc@google.com \
--cc=alexandru.elisei@arm.com \
--cc=andrew.jones@linux.dev \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=borntraeger@linux.ibm.com \
--cc=coltonlewis@google.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=james.morse@arm.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=oliver.upton@linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pbonzini@redhat.com \
--cc=pgonda@google.com \
--cc=suzuki.poulose@arm.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).