From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99FE3C28D13 for ; Tue, 23 Aug 2022 01:14:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+FPpwmm7McpZ24V7ooDHDvWeMtKv6slegbyTwCYCSj4=; b=lVXUkxJoj/xibW sHXtppBHay2T/vBevTEANU7rXgt+4/hU7TfVdlL7I0hrp2jDXhU63CXyCPwzmpieEIGCaYo/7ftOa wyxeu3dBqEujhdzqCbCpH0F/XH1IIcwJyFaC8uMqBXHlonHKP3srQkw8Z3sNisBp+ji+9W6mmFv0p erQwXKCZrtOHLLL5F1B084F2Rs4BCyXzX3L7BnSgfn/+h5+TBHbfgsE40R8lAEHNoO+eXOa5bntgA TsSmqLWL2Acq5vGbD/3QkmwP4HVoFgsgTR4HeDf0sM8iVlVFta3C+y6uawTW0E9cuChyrCCmLDAce QG4pojzdyfuxdHjoBgqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQITx-00H51R-V1; Tue, 23 Aug 2022 01:13:30 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQITt-00H4t8-Bz for linux-arm-kernel@lists.infradead.org; Tue, 23 Aug 2022 01:13:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661217200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yfh06TyG5c34D7x1kaHxF6+hr4mEnE7ZvWBsUHmo9JM=; b=QmXuS+NUkfMFMYRdeAn5Hr2AVCBbwxl83WxzyztF8a4E3Tt5KcgMVDTLGQ03o0QPpMVFrW zE4AWjEwk52IhyZubSzHy9K3vGDR344Fv+ZZcnzP7E+SFjvqXfXMKJFBQ4jkMIaydUcvnw M09V4+m/MGgLQg9esy2fMbiqdCBzZII= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-202-q_SzlhyIMgiW9KpYE3iyUA-1; Mon, 22 Aug 2022 21:13:17 -0400 X-MC-Unique: q_SzlhyIMgiW9KpYE3iyUA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 47F38811E75; Tue, 23 Aug 2022 01:13:17 +0000 (UTC) Received: from localhost (ovpn-12-31.pek2.redhat.com [10.72.12.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 978112026D4C; Tue, 23 Aug 2022 01:13:16 +0000 (UTC) Date: Tue, 23 Aug 2022 09:13:13 +0800 From: Baoquan He To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 02/11] mm: ioremap: fixup the physical address and page prot Message-ID: References: <20220820003125.353570-1-bhe@redhat.com> <20220820003125.353570-3-bhe@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220822_181325_647174_181FF0D5 X-CRM114-Status: GOOD ( 13.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/20/22 at 11:54pm, Christoph Hellwig wrote: > > -void __iomem *arch_ioremap(phys_addr_t phys_addr, size_t size, unsigned long prot); > > +void __iomem * > > +arch_ioremap(phys_addr_t *paddr, size_t size, unsigned long *prot_val); > > It seems a bit odd to do this in two steps vs just doing the entire > change in the first patch. Any good reason for that? I will merge patch 1~2 or 1~3 into patch 1. Earlier, I wrote the reason as below paragraph in cover letter of v1 post. Now it seems not so hard to tell and understand. ==== For patch 1~3, I don't merge them because I made them in different rounds of changing. And splitting them makes me easily describe the intention and make review easier. I can merge them after v1 reviewing if anyone thinks they should be merged. ==== _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel