From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFAA3C32774 for ; Tue, 23 Aug 2022 06:03:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O/d7qlBNxSJMGH6hn2EfM041WLreFw1NI6rNWxXd2Nk=; b=kIWZCzDc8ml0E0 m2J3cAhO4C6ymqRtJPWh5PS01LiJ7Gk0RBciBj+884NYkEv7vLroAGWiGmVfmVyLKcnSvcxfP+Mk8 ANH5zNvOT+51IziujMfl+Gfi19hMdeDSJc39krh+1KYre7jScfRVYqSpp3qec317yX3ITpubt+tWn brpMHjXWl3tB08XBEPSDw4/2HS4eRLGNi5RC5hC/GLhxWjtoMDYSsxw/qE1/0q/xMY2cM9HZgez/C ZvX3nNlnYoPKT/uOj4cnfE1ESUPc3pYgVb0F3yAR26QWulghKpqIiH7yYjbTezjrb0zDot3b4QIaj ZphoAQBl3FBocNDDLrSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQMzO-002fva-Jj; Tue, 23 Aug 2022 06:02:15 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQMzI-002fnw-82 for linux-arm-kernel@lists.infradead.org; Tue, 23 Aug 2022 06:02:09 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id EE54280F9; Tue, 23 Aug 2022 05:54:54 +0000 (UTC) Date: Tue, 23 Aug 2022 09:02:00 +0300 From: Tony Lindgren To: Janusz Krzysztofik Subject: Re: [PATCH 0/9] Clean-up timer-ti-dm a bit Message-ID: References: <20220815131250.34603-1-tony@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220822_230208_415366_F1B41BA0 X-CRM114-Status: GOOD ( 22.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Grygorii Strashko , Vignesh Raghavendra , Aaro Koskinen , Keerthy , Daniel Lezcano , Linux Kernel Mailing List , Linux OMAP Mailing List , Ladislav Michl , Thomas Gleixner , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Janusz Krzysztofik [220822 22:22]: > Hi Tony, > > On Monday, 15 August 2022 15:12:41 CEST Tony Lindgren wrote: > > Hi all, > > > > This series of changes cleans up timer-ti-dm a bit. After this series we > > can start replacing the custom PWM related functions with standard > > Linux frameworks and use things like clk_set_duty_cycle(). > > > > I have only tested this on K3 and omap2+ devices, I don't have any > > omap1 devices online right now. Aaro & Janusz, if you could give this > > series a quick boot test for omap1 that would be great. > > AFAICS, OMAP1 timer-ti-dm compatible "omap_timer" device requires OMAP16xx > at least, while I only have OMAP15xx. Then, my testing (successful) was > limited to a single function -- omap_dm_timer_modify_idlect_mask() -- which > is called on any OMAP1 as long as CONFIG_OMAP_DM_TIMER is set (requires > CONFIG_COMPILE_TEST). However, I've reviewed the series and it looks good > to me. I'm only not sure if we may expect any external users of > omap_dm_timer_get_irq(), if not than we could make it local to the driver while > being at it. OK thanks for testing. And thanks for spotting that omap_dm_timer_get_irq() can be static, I'll post a separate patch for that. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel