Re: [PATCH v4] regulator: core: Resolve supply name earlier to prevent double-init

From: Mark Brown <broonie@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: "Christian Kohlschütter" <christian@kohlschutter.com>,
	heiko@sntech.de, lgirdwood@gmail.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-rockchip@lists.infradead.org, m.reichl@fivetechno.de,
	robin.murphy@arm.com, vincent.legoll@gmail.com, wens@kernel.org
Subject: Re: [PATCH v4] regulator: core: Resolve supply name earlier to prevent double-init
Date: Thu, 25 Aug 2022 13:21:13 +0100	[thread overview]
Message-ID: <YwdpOX0xCzYwhjmx@sirena.org.uk> (raw)
In-Reply-To: <58b92e75-f373-dae7-7031-8abd465bb874@samsung.com>

[-- Attachment #1.1: Type: text/plain, Size: 1062 bytes --]

On Thu, Aug 25, 2022 at 01:32:50PM +0200, Marek Szyprowski wrote:

> This patch landed recently in linux next as commit 8a866d527ac0 
> ("regulator: core: Resolve supply name earlier to prevent double-init"). 
> Unfortunately it breaks booting of Samsung Exynos 5800 based Peach-Pi 
> (arch/arm/boot/dts/exynos5800-peach-pi.dts) and Peach-Pit 
> (arch/arm/boot/dts/exynos5420-peach-pit.dts) Chromebooks. The last 
> message in the kernel log is a message about disabling 'vdd_1v2' 
> regulator. This regulator is not used directly, however it is a supply 
> for other critical regulators.

This suggests that supplies are ending up not getting bound.  Could you
perhaps add logging to check that we're attempting to resolve the supply
(in the

+       if ((rdev->supply_name && !rdev->supply) &&
+                       (rdev->constraints->always_on ||
+                        rdev->constraints->boot_on)) {

block)?  I'd also note that it's useful to paste the actual error
messages you're seeing rather than just a description of them.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel