From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A65C8ECAAD6 for ; Fri, 26 Aug 2022 20:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1u2hGg2TR5uumKPvvpufzMz64J17SfQL6cv02ESvxxE=; b=r0iCsUaBuJ46sz o+qwTkwZBCjSIomfyb405ialGQl0fi4N1QtPYkHOIekW2b4Zk/zUw0zBcreeeKFIKg0lCmZfna5to MRYA394ctA7JQfBI5Z561fiRP2t+n/UW6tb/gTYMeNiLQI4z09ROVGKvHsgFEfRXVXf//YXieKZnc rdtCcud9CNDhOFG1T+7zsQC91g9W5OKDyG730u6w/ytsgTnk7a80SEmWRMNMC7c9e5lkEUHEMLhjW kTz+niugp8nJK5g1bAqxTbfIjlzGhOFSKZonjM14Dnxi7cSDktdutab5AkDVHxbHaUcX9xnXe3cY6 6aoRntOwhO/kwegkLy5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRfoM-00BZEl-FR; Fri, 26 Aug 2022 20:20:14 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRfoJ-00BZ6w-Ei for linux-arm-kernel@lists.infradead.org; Fri, 26 Aug 2022 20:20:12 +0000 Received: by mail-pf1-x42f.google.com with SMTP id t129so2550436pfb.6 for ; Fri, 26 Aug 2022 13:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=Yy3h91/LZL0yMN3Y+gPnYCc8uzqqu6+PEMw/uYOkvrQ=; b=QI2iqRq9/94E6zl7r9mZw4F+7Daqhq8WErAzs7MCXRZvrz4GpEbY7Dstc+ZZ2JEyb2 q0xcA8xKqPk01eYmQLRlBIm9I9enL9gle1pvxTgv3hEVqdUw5C4cSi7lwuKtIjcxf5KZ MNemfeMqo0zzfRvxEdPkaXJq+V0CXBJoNhrKZhmH2a/6fEvyddf2Pci6F7c3hz5Uh2KZ p9XfmAZB3QDZNhI51WLuUsrX5a34H43X0h0MgNESMM7lb3mZRO5lRiW8QfXtTjK0Iio8 Bx/faeNKIHAHpdLZt2Qt47/Jnw19TxwGoB6eZJ5V4qbulyod0s+zhEZ6nWzqexbUBQl1 6MGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=Yy3h91/LZL0yMN3Y+gPnYCc8uzqqu6+PEMw/uYOkvrQ=; b=MkpqmHiE7CInTagHupZryfFiZ0RFgSg+Z5J/PoaUrgh9TWaR/nj5b2nzHAs43dGCAN Lkszr+qprGPS+OvLsaXlW554TK3D+E7gqtDoz8niga+q1gPFGu/qlFGPgxkQNowVOXLC RghOwTt0UeC0Ct5W5j7LYuXRsiO+3i2qGyPrKqdy0bmRzu+DGe7ENniL2N0X0Z00kSQh XZOEvvTn4FvO/RWDUZsTyE+kl2uPqz+JDoLORujY8QRwod36G9CxtFhgYHd6QXXj4Ptl bwgEqwkze80XtMfeoL7VBRD+sHZozY811knb+lkqDG8TfI4R3L4O5vUu4EBcmgXcd2cz 1Ahg== X-Gm-Message-State: ACgBeo0SfrjFoPfpXSoCJOwhe0NWE8/8VPnaejYxwWtOAiEgDMiLGW7d vJ1OT159qRW5jjVjusjr0SG4dw== X-Google-Smtp-Source: AA6agR5n02jhbK1nhPu/jZhpJFX2d1euSOaYUkGIxcjNNi+QlVmGNtQ1h1+3uTxVaQGYEwd8dNh3mw== X-Received: by 2002:a05:6a00:4147:b0:52e:2d56:17c8 with SMTP id bv7-20020a056a00414700b0052e2d5617c8mr5478964pfb.51.1661545204289; Fri, 26 Aug 2022 13:20:04 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id x21-20020a63f715000000b0042b117e8bf8sm1843703pgh.23.2022.08.26.13.20.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Aug 2022 13:20:03 -0700 (PDT) Date: Fri, 26 Aug 2022 20:20:00 +0000 From: Sean Christopherson To: Yosry Ahmed Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Oliver Upton , Huang@google.com, Shaoqin , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v7 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats. Message-ID: References: <20220823004639.2387269-1-yosryahmed@google.com> <20220823004639.2387269-4-yosryahmed@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220823004639.2387269-4-yosryahmed@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220826_132011_510334_003DDCA0 X-CRM114-Status: GOOD ( 22.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 23, 2022, Yosry Ahmed wrote: > Count the pages used by KVM mmu on x86 in memory stats under secondary > pagetable stats (e.g. "SecPageTables" in /proc/meminfo) to give better > visibility into the memory consumption of KVM mmu in a similar way to > how normal user page tables are accounted. > > Signed-off-by: Yosry Ahmed > Reviewed-by: Sean Christopherson > --- > arch/x86/kvm/mmu/mmu.c | 16 ++++++++++++++-- > arch/x86/kvm/mmu/tdp_mmu.c | 12 ++++++++++++ > 2 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > index e418ef3ecfcb..4d38e4eba772 100644 > --- a/arch/x86/kvm/mmu/mmu.c > +++ b/arch/x86/kvm/mmu/mmu.c > @@ -1665,6 +1665,18 @@ static inline void kvm_mod_used_mmu_pages(struct kvm *kvm, long nr) > percpu_counter_add(&kvm_total_used_mmu_pages, nr); > } > > +static void kvm_account_mmu_page(struct kvm *kvm, struct kvm_mmu_page *sp) > +{ > + kvm_mod_used_mmu_pages(kvm, +1); > + kvm_account_pgtable_pages((void *)sp->spt, +1); > +} > + > +static void kvm_unaccount_mmu_page(struct kvm *kvm, struct kvm_mmu_page *sp) > +{ > + kvm_mod_used_mmu_pages(kvm, -1); > + kvm_account_pgtable_pages((void *)sp->spt, -1); > +} Hrm, this is causing build on x86 issues for me. AFAICT, modpost doesn't detect that this creates a new module dependency on __mod_lruvec_page_state() and so doesn't refresh vmlinux.symvers. ERROR: modpost: "__mod_lruvec_page_state" [arch/x86/kvm/kvm.ko] undefined! make[2]: *** [scripts/Makefile.modpost:128: modules-only.symvers] Error 1 make[1]: *** [Makefile:1769: modules] Error 2 make[1]: *** Waiting for unfinished jobs.... Kernel: arch/x86/boot/bzImage is ready (#128) make[1]: Leaving directory '/usr/local/google/home/seanjc/build/kernel/vm' make: *** [Makefile:222: __sub-make] Error 2 Both gcc and clang yield the same behavior, so I doubt it's the compiler doing something odd. Cleaning the build makes the problem go away, but that's a poor band-aid. If I squash this with the prior patch that adds kvm_account_pgtable_pages() to kvm_host.h, modpost detects the need to refresh and all is well. Given that ARM doesn't support building KVM as a module, i.e. can't run afoul of whatever modpost weirdness I'm hitting, I'm inclined to squash this with the previous patch and punt on the modpost issue so that we can get this merged. Any objections? Or thoughts on what's going wrong? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel