From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B78B0C0502C for ; Sat, 27 Aug 2022 06:32:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NC+rwSvcRe1P4EEw2fsuo1LoVh6tFMWs0ppxxgpYV6c=; b=idME+2twxwEWiH 66b3DLBf0mRwhnrka70HRGxzVGS/45wVFA34rzRHGzaJg/+35e6OPOzBn8ONgeDg5oyvSmC1IHfkt u+nQ4HD8TSKxkKamMZFzOTXBqjp2Ec21ENjXKQwVKzuA6PHj+nbzPSGo0SAH2/2KHT45VbCwaUoBQ PEEToDg8uSZ2Kl1rEsRVCA6cTT4EbGfftDU4CoRtT27MQulncRcHmyDBQwQx/E4juqn+H/PE7L9EF TRBK7gZyEn4Ke5fT4ZIVyyTjhQwxfE38jiE/Xxeyj+4PGw2wJn7pzl2PQLrwsHLQJOINBd2TL/la6 hFnAgjnJYdKekAJ2qTbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRpLb-003pKz-Sr; Sat, 27 Aug 2022 06:31:11 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRpLY-003pD7-V7 for linux-arm-kernel@lists.infradead.org; Sat, 27 Aug 2022 06:31:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661581868; x=1693117868; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=2RdCy6tyMucjJ+3ngZSsWyiE4xxEX4EO/OwoRyYj4oU=; b=kkmmeB5QWAaW4rpY2CZBtjsBsdsg9mJPabnDaf4Jla0/KNaMvfpa1g9d CFCRSFSZHJ+dTYuwM/Cs/TO6CmGyxhuNOZ0AxV4cLslEQA+dwNeJlVaxU b16vIA5oLtEDV5sMHk/17kyX01E+E/r4jr0Fztnq4euwsIaVX4hipPH0d SKW6fToHTYVUb5J1I0MGN9qVZiWXcI//XZ0e1DURZBqyHfaciAVP9YbcL ePANpnpZAlvmbcgoA12jtKITT40fAFlKHfpKriDug0AafDAbAOJFBgtGW 5U4JKfbUmyBVyFCzC5fXjAQWaYWnR8LH5GJYDzNiV8ISw0MD/8bXwe8tU A==; X-IronPort-AV: E=McAfee;i="6500,9779,10451"; a="294649804" X-IronPort-AV: E=Sophos;i="5.93,267,1654585200"; d="scan'208";a="294649804" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2022 23:31:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,267,1654585200"; d="scan'208";a="938992735" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by fmsmga005.fm.intel.com with ESMTP; 26 Aug 2022 23:30:58 -0700 Date: Sat, 27 Aug 2022 14:21:42 +0800 From: Xu Yilun To: Nava kishore Manne Cc: git@amd.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com, mdf@kernel.org, hao.wu@intel.com, trix@redhat.com, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, ronak.jain@xilinx.com, rajan.vaja@xilinx.com, abhyuday.godhasara@xilinx.com, piyush.mehta@xilinx.com, lakshmi.sai.krishna.potthuri@xilinx.com, harsha.harsha@xilinx.com, linus.walleij@linaro.org, nava.manne@xilinx.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, yilun.xu@intel.com Subject: Re: [PATCH 1/4] firmware: xilinx: Add afi ioctl support Message-ID: References: <20220824035542.706433-1-nava.kishore.manne@amd.com> <20220824035542.706433-2-nava.kishore.manne@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220824035542.706433-2-nava.kishore.manne@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220826_233109_057812_96678A12 X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-08-24 at 09:25:39 +0530, Nava kishore Manne wrote: > Adds afi ioctl to support dynamic PS-PL bus width settings. Please also describe what is afi, PS, PL here, Patch #0 won't appear in upstream tree finally. Thanks, Yilun > > Signed-off-by: Nava kishore Manne > --- > drivers/firmware/xilinx/zynqmp.c | 14 +++++++++++ > include/linux/firmware/xlnx-zynqmp.h | 36 ++++++++++++++++++++++++++++ > 2 files changed, 50 insertions(+) > > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c > index d1f652802181..cbd84c96a66a 100644 > --- a/drivers/firmware/xilinx/zynqmp.c > +++ b/drivers/firmware/xilinx/zynqmp.c > @@ -843,6 +843,20 @@ int zynqmp_pm_read_pggs(u32 index, u32 *value) > } > EXPORT_SYMBOL_GPL(zynqmp_pm_read_pggs); > > +/** > + * zynqmp_pm_afi() - PM API for setting the PS-PL bus width > + * @config_id: Register index value > + * @bus_width: Afi interface bus width value. > + * > + * Return: Returns status, either success or error+reason I see other functions are also like this, but I still can't figure out what values for success and what for error+reason. Thanks, Yilun > + */ > +int zynqmp_pm_afi(u32 config_id, u32 bus_width) > +{ > + return zynqmp_pm_invoke_fn(PM_IOCTL, 0, IOCTL_AFI, > + config_id, bus_width, NULL); > +} > +EXPORT_SYMBOL_GPL(zynqmp_pm_afi); > + > /** > * zynqmp_pm_set_boot_health_status() - PM API for setting healthy boot status > * @value: Status value to be written > diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h > index 9f50dacbf7d6..7d0d98303acc 100644 > --- a/include/linux/firmware/xlnx-zynqmp.h > +++ b/include/linux/firmware/xlnx-zynqmp.h > @@ -78,6 +78,16 @@ > #define EVENT_ERROR_PSM_ERR1 (0x28108000U) > #define EVENT_ERROR_PSM_ERR2 (0x2810C000U) > > +#define AFIFM_BUS_WIDTH_128_CONFIG_VAL 0x0U > +#define AFIFM_BUS_WIDTH_64_CONFIG_VAL 0x1U > +#define AFIFM_BUS_WIDTH_32_CONFIG_VAL 0x2U > + > +#define AFIFS_SS0_SS2_BUS_WIDTH_128_CONFIG_VAL 0x200U > +#define AFIFS_SS0_SS2_BUS_WIDTH_64_CONFIG_VAL 0x100U > +#define AFIFS_SS1_BUS_WIDTH_128_CONFIG_VAL 0x800U > +#define AFIFS_SS1_BUS_WIDTH_64_CONFIG_VAL 0x400U > +#define AFIFS_SS_BUS_WIDTH_32_CONFIG_VAL 0x0U > + > enum pm_api_cb_id { > PM_INIT_SUSPEND_CB = 30, > PM_ACKNOWLEDGE_CB = 31, > @@ -147,6 +157,7 @@ enum pm_ioctl_id { > IOCTL_READ_PGGS = 15, > /* Set healthy bit value */ > IOCTL_SET_BOOT_HEALTH_STATUS = 17, > + IOCTL_AFI = 18, > IOCTL_OSPI_MUX_SELECT = 21, > /* Register SGI to ATF */ > IOCTL_REGISTER_SGI = 25, > @@ -155,6 +166,25 @@ enum pm_ioctl_id { > IOCTL_GET_FEATURE_CONFIG = 27, > }; > > +enum pm_afi_config_id { > + AFIFM0_RDCTRL = 0, > + AFIFM0_WRCTRL = 1, > + AFIFM1_RDCTRL = 2, > + AFIFM1_WRCTRL = 3, > + AFIFM2_RDCTRL = 4, > + AFIFM2_WRCTRL = 5, > + AFIFM3_RDCTRL = 6, > + AFIFM3_WRCTRL = 7, > + AFIFM4_RDCTRL = 8, > + AFIFM4_WRCTRL = 9, > + AFIFM5_RDCTRL = 10, > + AFIFM5_WRCTRL = 11, > + AFIFM6_RDCTRL = 12, > + AFIFM6_WRCTRL = 13, > + AFIFS = 14, > + AFIFS_SS2 = 15, > +}; > + > enum pm_query_id { > PM_QID_INVALID = 0, > PM_QID_CLOCK_GET_NAME = 1, > @@ -475,6 +505,7 @@ int zynqmp_pm_is_function_supported(const u32 api_id, const u32 id); > int zynqmp_pm_set_feature_config(enum pm_feature_config_id id, u32 value); > int zynqmp_pm_get_feature_config(enum pm_feature_config_id id, u32 *payload); > int zynqmp_pm_register_sgi(u32 sgi_num, u32 reset); > +int zynqmp_pm_afi(u32 config_id, u32 bus_width); > #else > static inline int zynqmp_pm_get_api_version(u32 *version) > { > @@ -745,6 +776,11 @@ static inline int zynqmp_pm_register_sgi(u32 sgi_num, u32 reset) > { > return -ENODEV; > } > + > +static inline int zynqmp_pm_afi(u32 config_id, u32 bus_width) > +{ > + return -ENODEV; > +} > #endif > > #endif /* __FIRMWARE_ZYNQMP_H__ */ > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel