From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF5B5ECAAD2 for ; Mon, 29 Aug 2022 09:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vSAuchpfvYSapAssI8/YGW41DeqZxBUdQYkz50uvQ1s=; b=RfLVkHXbpGyR/A NkkXhqHS52BZf9GzM9ezbkQSqXTUZh0FAMKO/q8XBLS944BkqzoYF6QqPAxZVrRRWZgVfBrQqDJSs Fdw/gKkvFvTJ3wQS7xyxE4YZbEQbLL68U8sYlreF1v8R7I4rTWzN/wEqMQkPmpvvuJMPYGC1td/i8 L+Atsq6y01K5UmjOZ4A+D9a1J9Z9O7/hEKE3OGdl5fbSMp0vLXa+eUUZFF/yb4jRbQP+8zz9z/N4J yf37WSjF8EcuWl/6hPoVOLV3rLiFkbp1m2ST4/aZXB/AIA16a3wyLvRCwZxuZJK2vym11AnzQ+pnl jf8HO9kBdKjyGnQxXdpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSb7o-006lBe-GM; Mon, 29 Aug 2022 09:32:09 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSb7N-006kzW-NQ for linux-arm-kernel@lists.infradead.org; Mon, 29 Aug 2022 09:31:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2001EB80E1A; Mon, 29 Aug 2022 09:31:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35EB6C433D6; Mon, 29 Aug 2022 09:31:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661765498; bh=DaCQt9/itQJTFVdFfWf2frefrBLkra5oL6E0l2pgOzc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T1UjB0kz4tKX6+aXtk/He42QK6ZZIjjj/2jm80uSBrcPBl4lY/Dd6jNYRYf/JUG4U szWPIe1xCyqeYejjPqpgiL/3mT0MpGeqf/fDv/w/9JaYEQJ52aB7IL/oIZdI7eZ/Di xUgy9/KikHWIT8ph7bTwX0xtdndX09wc/Mumr5Jpfaf2KW9iw1qG6rz4R9LYfxqIBd jDn3eeeiVskvTLkW6BhEKIEqvlEo3r1ydKymYg/EA1oVgE6283p85em2S2AX92DZrv 7l3AFbXJAm1z2+rfx7i0P9Qa0nzL5ryLWEM+BCa8tL7GQkm8TFm2GASwWsb5mkX1Uk UJ4NxvhppiRVQ== Date: Mon, 29 Aug 2022 11:31:32 +0200 From: Lorenzo Pieralisi To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Thomas Petazzoni , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] PCI: aardvark: Add support for PCI Bridge Subsystem Vendor ID on emulated bridge Message-ID: References: <20220711221823.12154-1-pali@kernel.org> <20220711225915.13896-1-pali@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220711225915.13896-1-pali@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220829_023142_005318_BA4CA18E X-CRM114-Status: GOOD ( 19.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 12, 2022 at 12:59:15AM +0200, Pali Roh=E1r wrote: > Register with Subsystem Device/Vendor ID is at offset 0x2c. Export is via > emulated bridge. "Export it..." I suppose. So in short, this patch enables support for the Subsystem Device/Vendor ID - by reading it in the PCI controller config space and storing it in the emulated bridge control structures, so that it is exposed in the respective PCI capability. Correct ? Thanks, Lorenzo > After this change Subsystem ID is visible in lspci output at line: > = > Capabilities: [40] Subsystem > = > Signed-off-by: Pali Roh=E1r > = > --- > Changes in v2: > * Fix wrong rebase, do not add PCIE_CORE_EXP_ROM_BAR_REG > --- > drivers/pci/controller/pci-aardvark.c | 3 +++ > 1 file changed, 3 insertions(+) > = > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controll= er/pci-aardvark.c > index 74511f015168..060936ef01fe 100644 > --- a/drivers/pci/controller/pci-aardvark.c > +++ b/drivers/pci/controller/pci-aardvark.c > @@ -32,6 +32,7 @@ > #define PCIE_CORE_DEV_ID_REG 0x0 > #define PCIE_CORE_CMD_STATUS_REG 0x4 > #define PCIE_CORE_DEV_REV_REG 0x8 > +#define PCIE_CORE_SSDEV_ID_REG 0x2c > #define PCIE_CORE_PCIEXP_CAP 0xc0 > #define PCIE_CORE_ERR_CAPCTL_REG 0x118 > #define PCIE_CORE_ERR_CAPCTL_ECRC_CHK_TX BIT(5) > @@ -982,6 +983,8 @@ static int advk_sw_pci_bridge_init(struct advk_pcie *= pcie) > /* Indicates supports for Completion Retry Status */ > bridge->pcie_conf.rootcap =3D cpu_to_le16(PCI_EXP_RTCAP_CRSVIS); > = > + bridge->subsystem_vendor_id =3D advk_readl(pcie, PCIE_CORE_SSDEV_ID_REG= ) & 0xffff; > + bridge->subsystem_id =3D advk_readl(pcie, PCIE_CORE_SSDEV_ID_REG) >> 16; > bridge->has_pcie =3D true; > bridge->data =3D pcie; > bridge->ops =3D &advk_pci_bridge_emul_ops; > -- = > 2.20.1 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel