From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3867ECAAD1 for ; Thu, 1 Sep 2022 18:30:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7Merr/u/5L+7vKdSaFgH9G75RAA54ckL0IejHVcBjuU=; b=jx7ztCtZpevWY5 rNdHr2C0Fr+dAV6rlOR+BlKMiCl4oTVvfeDogCIyMZX2ITyoVSnE4QGN4er8onrG9YfGTMbg9zqoe qR73SDnpwlb63KfGoeYg2r41vSLgnfpFvyiuvbuSfCF+ICqLBLySJEUdSPGe/RcfXau+tVs+eYuJS Yl8kdVjAKCY8evYCzfW2r5lnebqJDJiLgwzDksRfUxvNdpIzSoko5wtOH0a0PlZihfhHe/fU9bqn/ I3hK+tPgqJQ7zfBv4QMlodMEzKLOc6jEQkN6mAfwChe1iRJgV0udd+pf4u6pmDAF3jWoxy/kTIkcv fEJfwXkfJ0GaC+Q8pCEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTowT-00Dwa3-Ut; Thu, 01 Sep 2022 18:29:30 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTowQ-00DwYw-EN for linux-arm-kernel@lists.infradead.org; Thu, 01 Sep 2022 18:29:27 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9319B6CD; Thu, 1 Sep 2022 20:29:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1662056964; bh=Z2PmbE+q+oRXUcaxQb4yleqabhSi7+sIU+fRtX1f08s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EC9PRlW04t2B9cCt+4wz2+8sQ2yp8ZM7K4V7wFcAu18ic4AGLGU00x4HynEEWPN2Q Qz2NoygeN3lB+O3uKqaXMdjNbid1+cX2wo60JSgsJWl4n9pr++mwna1ahvOcnmbBYQ uTEIOzPWZL7Zo/XQrQStWN6+c4w7jIunb8wj3B2s= Date: Thu, 1 Sep 2022 21:29:13 +0300 From: Laurent Pinchart To: Max Krummenacher Cc: Max Krummenacher , Fabio Estevam , Krzysztof Kozlowski , Marcel Ziswiler , NXP Linux Team , Pengutronix Kernel Team , Philippe Schenker , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown Subject: Re: [PATCH] arm64: dts: imx8mp-verdin: board regulators: add always-on Message-ID: References: <20220901110422.1859621-1-max.oss.09@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220901110422.1859621-1-max.oss.09@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220901_112926_651639_DD4F3654 X-CRM114-Status: GOOD ( 17.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Max, (CC'ing Mark and Liam) Thank you for the patch. On Thu, Sep 01, 2022 at 01:04:22PM +0200, Max Krummenacher wrote: > From: Max Krummenacher > > These regulators are switched on by HW during power up and can not > be influenced by SW. > Set the always-on property. Is this needed ? When a fixed regulator has no control GPIO or clock, as is the case here, I would expect the driver and/or regulator core to understand that it's always on, as the alternative is always-off, which is pointless :-) Mark, Liam, what do you think ? > Signed-off-by: Max Krummenacher > > --- > > arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > index 557cfef8f049..76cc89296150 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > @@ -62,6 +62,7 @@ button-wakeup { > /* Carrier Board Supplies */ > reg_1p8v: regulator-1p8v { > compatible = "regulator-fixed"; > + regulator-always-on; > regulator-max-microvolt = <1800000>; > regulator-min-microvolt = <1800000>; > regulator-name = "+V1.8_SW"; > @@ -69,6 +70,7 @@ reg_1p8v: regulator-1p8v { > > reg_3p3v: regulator-3p3v { > compatible = "regulator-fixed"; > + regulator-always-on; > regulator-max-microvolt = <3300000>; > regulator-min-microvolt = <3300000>; > regulator-name = "+V3.3_SW"; > @@ -76,6 +78,7 @@ reg_3p3v: regulator-3p3v { > > reg_5p0v: regulator-5p0v { > compatible = "regulator-fixed"; > + regulator-always-on; > regulator-max-microvolt = <5000000>; > regulator-min-microvolt = <5000000>; > regulator-name = "+V5_SW"; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel