From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 803DDC38145 for ; Sat, 3 Sep 2022 00:26:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vpk4HXfDCXtLhuDPowIM2Quhlo9MFZr3RZNF3trseGA=; b=uyBIyve6KYb9BS N1lgvxvERRIvhQmzutWPDWb/88Af9nRm6fLUavpnpgFELe0mvCY5gm/RYY3i66LNejvKpJPGD+P4c ZDTSz9qvLPywVrVI/vC/RGzBt70IZkOjSfF2HZ/ztkUvAOlYbZCqMDqiMUvn1tT+B+ZQv9E3AVdRu 57EQuJrqAi/0s7eZ7wryhk9gDwe6ok+drnH5G0vcXvaZGRZiWpajrKeXBJben0bSSwcXRs/BjMm7W IEap2q30KkqyB4dY0NbnusopIWdGIUHKq0V7/4R/1PKmr/NtyOQF7geU5wWCXgELDTBrxcyR1PmB3 /ys4QUtIRvG/YkmU8aIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oUGyL-00E5CS-NZ; Sat, 03 Sep 2022 00:25:17 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oUGyI-00E54b-OL for linux-arm-kernel@lists.infradead.org; Sat, 03 Sep 2022 00:25:16 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8EDEB6DD; Sat, 3 Sep 2022 02:25:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1662164704; bh=H2oIKKpl7vDJ+UZWMIb/3wmlWoyGMna5rxAUCLWh4mk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Me420Y6rkhnnjE3cmtE1eQhJLjVnyqoxTJulX2e9n1z/YSEpUTbVY03AFsoZdS+6m QKRU+jSdrp1Ll1vBPqQLs379abGsgkxlNG3mF0N7IMZIBP0C4pkdkKFdHiI2kyFKwV i6x72SSeG9MqHcxYqURlKq09XYaRXpnWRgnw/gww= Date: Sat, 3 Sep 2022 03:24:51 +0300 From: Laurent Pinchart To: Francesco Dolcini Cc: Max Krummenacher , Max Krummenacher , Fabio Estevam , Krzysztof Kozlowski , Marcel Ziswiler , NXP Linux Team , Pengutronix Kernel Team , Philippe Schenker , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] arm64: dts: imx8mp-verdin: add dsi to hdmi functionality Message-ID: References: <20220901154051.1885509-1-max.oss.09@gmail.com> <20220902155720.GB5699@francesco-nb.int.toradex.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220902155720.GB5699@francesco-nb.int.toradex.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220902_172514_988557_CC2D0BDF X-CRM114-Status: GOOD ( 23.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Francesco, On Fri, Sep 02, 2022 at 05:57:20PM +0200, Francesco Dolcini wrote: > Hello Laurent, > answering here for both patches (1/2 and 2/2). > > On Thu, Sep 01, 2022 at 09:07:49PM +0300, Laurent Pinchart wrote: > > On Thu, Sep 01, 2022 at 05:40:50PM +0200, Max Krummenacher wrote: > > > From: Max Krummenacher > > > > > > Add the hdmi connector present on the dsi to hdmi adapter now > > > required by the upstream lontium bridge driver. > > > The dsi to hdmi adapter is enabled in an device tree overlay. > > > > Shouldn't the connector also be in the overlay ? There's certainly no > > physical HDMI connector on the i.MX8MP Verdin SoM :-) > > Toradex DTS include and overlay files structure so far has been a little > bit different and not following the expectation you just stated here, > you can just check the current *toradex*dts* files and you'll see that there > is other stuff that is not strictly part of the module. > > Copying from a previous email thread on a very similar discussion [0] > some of the reasons: > > - The SoM dtsi representing not only the functionality implemented into > the SoM, but the whole connector pinout to the carrier makes very easy > to just include a different som.dtsi in the carrier board dts and just > switch SoM, for example from a colibri-imx6 to a colibri-imx7. That's fine, but I don't see how that's related to the issue at hand. The DSI to HDMI bridge wouldn't be present on either SoM, would it ? > - We avoid code duplication > > This is working for us pretty well so far and the majority of the users > of ours modules rely on this structure, we would prefer not to change that. It may work for your current use cases, but it doesn't make it right :-) Someone can integrate a Verdin SoM with a carrier board that has no DSI to HDMI (or LVDS) bridge, there should thus be no such device in the device tree. The SoM has DSI signals present on its connector, that's what the SoM .dtsi should expose. > [0] https://lore.kernel.org/all/20220413094449.GB118560@francesco-nb.int.toradex.com/ -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel