From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1ABC2C38145 for ; Sat, 3 Sep 2022 17:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QdacV3AhZkCf4tcNH6L13VaxZBPCOK1U9brfhyAUY0I=; b=4DoIsFNLRS76mt LbSLyO2NcSt3/bf0Mv/Ec4h1ZQHnnmGkcsZkfmJMiXdC3vPLO2u6QwhHvV0b7zmDoPjq1PAAxcG2E mSh8ZySNM5MrsfxSgHTk4pXOzXUXx7xznGtVFEPD9RHtZKGIofcb9UdVaS2TuDuCe8SqeRAHAqZC8 TbWsg/p1M3Yhsa8jQpEwbiMmfnqhnGAI3PQIUp1Sw2pcP2NLqSMs1d85vgIGwUMsb32Ajzl80t/X1 rvU//9rbbvNgokMpv0XDQIRQyDLKXCN3EG64jY2d+U9oOXFFfZqC8BNO2zddpCSdDfrBIsINwX35N RrKpB79s872WfgpgAZbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oUWrO-00EFFb-7b; Sat, 03 Sep 2022 17:23:10 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oUWrL-00EFBn-0r for linux-arm-kernel@lists.infradead.org; Sat, 03 Sep 2022 17:23:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662225786; x=1693761786; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=E7SV1tvE14Rrta1eoerSvxDnugKpcVZ31cMcGlREDBs=; b=kgUSKaoRbTu9OND4In0JS5dKCHE3rYLFiCxVddpCm36h5aTbGKxNnQGm 5s1Q41lgxq1e5wUax8tRyZQnns1b+Wa6bLsz67heMpT73XsshFZiLOXro jxGMOp8NC9E9Tc7a5qRnkinGzdrjYNXxPXoJjEZhE1TG48lmR3G8fvJ2p D7oT/yQxeY3UfPBz5FNCDkrxyK08uP4dsUJZfav+AJJ2AA0ch8REshfXK Atx28XI/WDKRkPCLyWsi8PenGq25NJX91KINJJ/r8sB36VtCYtjidKisU SvP9upC+XHPBjizRMii5d88IuvVb5tqx68uo0RpV1wNJbRxtNWxh0V1iE A==; X-IronPort-AV: E=McAfee;i="6500,9779,10459"; a="276571858" X-IronPort-AV: E=Sophos;i="5.93,287,1654585200"; d="scan'208";a="276571858" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2022 10:23:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,287,1654585200"; d="scan'208";a="590428747" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by orsmga006.jf.intel.com with ESMTP; 03 Sep 2022 10:22:57 -0700 Date: Sun, 4 Sep 2022 01:13:34 +0800 From: Xu Yilun To: "Manne, Nava kishore" Cc: "git (AMD-Xilinx)" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "michal.simek@xilinx.com" , "mdf@kernel.org" , "hao.wu@intel.com" , "trix@redhat.com" , "p.zabel@pengutronix.de" , "gregkh@linuxfoundation.org" , "ronak.jain@xilinx.com" , "rajan.vaja@xilinx.com" , "abhyuday.godhasara@xilinx.com" , "piyush.mehta@xilinx.com" , "lakshmi.sai.krishna.potthuri@xilinx.com" , "harsha.harsha@xilinx.com" , "linus.walleij@linaro.org" , "nava.manne@xilinx.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-fpga@vger.kernel.org" Subject: Re: [PATCH 1/4] firmware: xilinx: Add afi ioctl support Message-ID: References: <20220824035542.706433-1-nava.kishore.manne@amd.com> <20220824035542.706433-2-nava.kishore.manne@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220903_102307_096612_1102F43E X-CRM114-Status: GOOD ( 22.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-08-30 at 09:25:47 +0000, Manne, Nava kishore wrote: > Hi Yilun, > > Please find my response inline. > > > -----Original Message----- > > From: Xu Yilun > > Sent: Saturday, August 27, 2022 11:52 AM > > To: Manne, Nava kishore > > Cc: git (AMD-Xilinx) ; robh+dt@kernel.org; > > krzysztof.kozlowski+dt@linaro.org; michal.simek@xilinx.com; > > mdf@kernel.org; hao.wu@intel.com; trix@redhat.com; > > p.zabel@pengutronix.de; gregkh@linuxfoundation.org; > > ronak.jain@xilinx.com; rajan.vaja@xilinx.com; > > abhyuday.godhasara@xilinx.com; piyush.mehta@xilinx.com; > > lakshmi.sai.krishna.potthuri@xilinx.com; harsha.harsha@xilinx.com; > > linus.walleij@linaro.org; nava.manne@xilinx.com; > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; linux-fpga@vger.kernel.org; yilun.xu@intel.com > > Subject: Re: [PATCH 1/4] firmware: xilinx: Add afi ioctl support > > > > On 2022-08-24 at 09:25:39 +0530, Nava kishore Manne wrote: > > > Adds afi ioctl to support dynamic PS-PL bus width settings. > > > > Please also describe what is afi, PS, PL here, Patch #0 won't appear in > > upstream tree finally. > > > > Agree, Will update the description in v2. > > > Thanks, > > Yilun > > > > > > > > Signed-off-by: Nava kishore Manne > > > --- > > > drivers/firmware/xilinx/zynqmp.c | 14 +++++++++++ > > > include/linux/firmware/xlnx-zynqmp.h | 36 > > > ++++++++++++++++++++++++++++ > > > 2 files changed, 50 insertions(+) > > > > > > diff --git a/drivers/firmware/xilinx/zynqmp.c > > > b/drivers/firmware/xilinx/zynqmp.c > > > index d1f652802181..cbd84c96a66a 100644 > > > --- a/drivers/firmware/xilinx/zynqmp.c > > > +++ b/drivers/firmware/xilinx/zynqmp.c > > > @@ -843,6 +843,20 @@ int zynqmp_pm_read_pggs(u32 index, u32 > > *value) } > > > EXPORT_SYMBOL_GPL(zynqmp_pm_read_pggs); > > > > > > +/** > > > + * zynqmp_pm_afi() - PM API for setting the PS-PL bus width > > > + * @config_id: Register index value > > > + * @bus_width: Afi interface bus width value. > > > + * > > > + * Return: Returns status, either success or error+reason > > > > I see other functions are also like this, but I still can't figure out what values > > for success and what for error+reason. > > > > Please find the relevant error info here: > https://elixir.bootlin.com/linux/v6.0-rc3/source/drivers/firmware/xilinx/zynqmp.c#L81 The caller should at least know what value is success and what are failures from the kernel doc, so they could write the code which call your API. Thanks, Yilun > > Regards, > Navakishore. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel