From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A02EECAAD3 for ; Mon, 5 Sep 2022 10:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x/2EF+wxBfdUT6Y1RG1tLwj3BAJd7TTasyTcOrtCdwc=; b=r+XQwo2RoxSHEW wM64DgZnjpQUqJLWZ/xZVNeNj5w+GK0ioPGj9rRiTAxMpc6WSY9Su5XnniXKqz8vmmqRuJX/7ArNx JDMYGhL+kN5GMQISr+8ykq1R8F8HlZzYX34j7/8uT4QD0Vs0x5ZJFDjNMvc/wyhjABGmoqagU452O 8FmpPcCxqt51CD1vEgt+jQCy8X8Jsht0wePSLN+8Pf/T4VhYU0lln2IjbdZn5Bg/VT28okErrXR7h f+X2QZgYlNwYuogA4z05EfJZ8oauCfW/BykjHaxKOkKq5uMMF8KJ4DUR45WTfyHGtBbVAl3Yc6RvH 24n4xc4JX4fToEu5Nijg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oV9Ci-0004f3-5c; Mon, 05 Sep 2022 10:19:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oV7m4-00EwUY-Ff for linux-arm-kernel@lists.infradead.org; Mon, 05 Sep 2022 08:50:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 41C9F139F; Mon, 5 Sep 2022 01:48:13 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.76.120]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB27A3F534; Mon, 5 Sep 2022 01:48:05 -0700 (PDT) Date: Mon, 5 Sep 2022 09:48:03 +0100 From: Mark Rutland To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, maz@kernel.org, will@kernel.org, nd@arm.com Subject: Re: [PATCH 6/9] arm64: alternatives: have callbacks take a cap Message-ID: References: <20220901151403.1735836-1-mark.rutland@arm.com> <20220901151403.1735836-7-mark.rutland@arm.com> <20220902155445.GA10647@e124191.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220902155445.GA10647@e124191.cambridge.arm.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 02, 2022 at 04:54:45PM +0100, Joey Gouly wrote: > Hi Mark, > > On Thu, Sep 01, 2022 at 04:14:00PM +0100, Mark Rutland wrote: > > diff --git a/arch/arm64/kernel/alternative.c b/arch/arm64/kernel/alternative.c > > index 2e18c9c0f612b..da706c9f9a9a5 100644 > > --- a/arch/arm64/kernel/alternative.c > > +++ b/arch/arm64/kernel/alternative.c > > @@ -21,6 +21,11 @@ > > #define ALT_ORIG_PTR(a) __ALT_PTR(a, orig_offset) > > #define ALT_REPL_PTR(a) __ALT_PTR(a, alt_offset) > > > > +#define ALT_CAP(a) ((a)->cpufeature & ~ARM64_CB_BIT) > > +#define ALT_HAS_CB(a) ((a)->cpufeature & ARM64_CB_BIT) > > + > > +#define ALT_NR_INST(a) ((a)->orig_len / AARCH64_INSN_SIZE) > You introduced this macro, but don't use it. Whoops; I'd originally added that for the dumping code, but ended up reworking things to not use it anyway. Removed now! Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel