From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1750ECAAD3 for ; Mon, 5 Sep 2022 18:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LCAo4zD1W52uo94vF65q4EFSC6w+QMSPdr8HMTQDPP8=; b=elVM4u4Afp7cTh krESVw5yUNk/3sF1oeX0nL1urdX8GTlyRF65keG4WL6EadB42fvaDhQwJ+OfxXQ+qGgPnnoxZC8fI 3bAZHab8cQG7bGMSikzkx0p3hn4dexFcDOK9Uef/9T7qAqRJYh2OST65DnkggBdueQYH2p4bYxVim tb6Fe5z1wdiAxSXQmHn1DySaHowiusRWOgBsg4HIfy3HoKqfmH9UmTIcwcZ+Nbd2+Wj69ifzJPRci LzkiuN03fm8kPBlDZLDc17LgQaKrh+NrAHL+6My5QK/OJwLEsfHxtf9LrSVansUe5vFvZBuQD3pQ8 dOrq2HWZx+rz/equ8Hig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVGht-008J2p-Ii; Mon, 05 Sep 2022 18:20:26 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVESg-006MOJ-4u for linux-arm-kernel@bombadil.infradead.org; Mon, 05 Sep 2022 15:56:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kZg5uA3NvW7M7kk4PRkFU4UyLnROUP61ZJaJXsOBBEo=; b=rWRYd8RmKKoujcE0IszqN+Gdwd qVuH2RHTOcWGZXW1Tb3AIk62LtwRLaCf+eqIKBu5/2pEZp0buCF6GJVzNzIMCY6tBjInXNA1paJD7 Ov6tdtJhXCdNGS296fquEHo3gc0gzBEYXpSHpVvBl9+9lxrltl04PGsYA+Mal/bSlNrBSHy8gYZ2d Ex13lMMfJkSLGZs8IVKlUrHuL1wK/Bd/a/80qj1ynhADutGAnHCAqnee6u0PEIJWUQPb5qIiAP1Wg Uo9+vYoG41KGFb88dreFMYT3ZwmTv8EXe5V2jIO/6OZ7EQhGGCl9+zd0R/R4pH99FhEMYMJrmFfYr J9iI9NPw==; Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVESY-009nFH-Pm for linux-arm-kernel@lists.infradead.org; Mon, 05 Sep 2022 15:56:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kZg5uA3NvW7M7kk4PRkFU4UyLnROUP61ZJaJXsOBBEo=; b=VLyLuwA1tFcxzSz5m1owrQ9SSG 1uFDPGLtF/3pG6dC0PmQATM6h2RAkN6S4MbQfRJYkanAkhrWbmT3CBSsxL/9x7NF6WO7RfFycCBiy pQHmBd11mbCyUmbTk58o2QDqO8J0plXwZcAbqFqGYNgXFI5d+eawnlHjWrBHUb2lxDUvddBp9Nixu t3CzEnKxDCvGCb645ZFfPYK2bKBIdFyB98mv+z++BASQfeTPi5tSt5MECRrIwljZDbDta6xOeOGJb xCLLB/NUmQJzl86R/+TFPXGCAnfN5LKCW18r1/zw+HP0dV3pJ7bxJRF5IUOR83b+MXJdixbiQ4TEc alvPtAIg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34124) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oVESQ-0002aF-VR; Mon, 05 Sep 2022 16:56:19 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oVESO-0007PT-SF; Mon, 05 Sep 2022 16:56:16 +0100 Date: Mon, 5 Sep 2022 16:56:16 +0100 From: "Russell King (Oracle)" To: Hector Martin Cc: Andy Shevchenko , Arnd Bergmann , Lee Jones , Linus Walleij , Alyssa Rosenzweig , asahi@lists.linux.dev, Bartosz Golaszewski , linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , Sven Peter Subject: Re: [PATCH 5/6] gpio: Add new gpio-macsmc driver for Apple Macs Message-ID: References: <0457bda4-8449-dede-1d85-e4e1317dff12@marcan.st> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0457bda4-8449-dede-1d85-e4e1317dff12@marcan.st> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_165627_187412_F0A0029C X-CRM114-Status: GOOD ( 19.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 06, 2022 at 12:52:48AM +0900, Hector Martin wrote: > On 05/09/2022 23.01, Russell King (Oracle) wrote: > > On Mon, Sep 05, 2022 at 04:16:27PM +0300, Andy Shevchenko wrote: > >> P.S. Do you have a platform to test all these? > > > > Yes, but that doesn't mean I can do testing sufficient to ensure that > > the modifications are correct. As I understand things, the SMC is not > > limited to just aarch64 hardware. > > FWIW, the RTKit backend is limited to aarch64 hardware, and that's also > why I kept all the endian-munging there. T2 and legacy x86 backends > (which don't exist yet, so whether things need changing for those > platforms is an open question anyway) would respectively do whatever > endian-munging is appropriate for them. > > So at this point, only Apple Mx AArch64 SoCs matter, though I *tried* to > write the code in the way that I thought was most likely to cleanly > transfer over to other SMC platforms by just changing the backend code. Right, and that's a good argument not to go and change the smc_key layout... that invites one hell of a big headache (also for the reasons you've set out in one of your previous replies.) I'm going to back out the hex2bin conversion; you've made a good argument why the code is the way it is. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel