From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EF9DECAAA1 for ; Mon, 5 Sep 2022 22:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b7/bqw/fXlZfXKh0b3FZ7O9+xMdzt1d3BXbtm5nqXYE=; b=dnlkH2leiZL3ux I+XHb3t0n9xbhcFetfQ9Yi1ZvQnJ1ZC3DVlOFAJqRpI5OHV7CoelTzr7xzZ1/rsjmMy0DZzwIhx51 JwCj0Jt0ak/sVvYcgcV6n0vEfzMvkkKgveCA6+asqUzWBpzOfg7/PuP/3gxalGMUW3igZi2x4Em/c 582WKDpvna6iNqmIhZxr5C+b8/W0IQpWyb72A7z/55KZOfJBtCX6jWtyGwFiLD6zMSFMashlCB0oo kse2sV91qaM/HfjV7OinvFtwaA0uyIXKX6q1AFSJ2IHd7NfGeIhP1vDLB+cO5zh7CWzLvyqrigige vCL0ti7ZRK317blXgedg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVKzq-00HUXx-GO; Mon, 05 Sep 2022 22:55:15 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVKzc-00HULH-AM; Mon, 05 Sep 2022 22:55:01 +0000 Received: by mail-pj1-x1030.google.com with SMTP id q3so9475254pjg.3; Mon, 05 Sep 2022 15:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date; bh=QRQkxIGFI3OF3amcRlbkZf4vgkek6ggFXyd9zidvB8c=; b=gsorC9ciDElqLq5gq0tq73oj5nMDX/AJm+EMEt5M9j7Nw6OucD0+TVGBzuQn+rrtls 0loRnw7UzHrgMM28KIGVLo7qn/bZoumg2qTw3CfDMDdQmf0bgbzpShi+kGjU7raGyx6P sToiGUYujxqPyCybICNsYdfYAa2jOurTif72VImXpZhCttvifys7wIqhFIW1PJR8dY03 UzvU99z5GubsoABcuAk5rbAMv44acUIXmY5P0ep133FiqLgOHtVg+wzuulxPweHG+ula IzdWZ5ta3aGiqrNbwgZATXaEEWNGQRgzb+HrP6NXzuvsc0zd1wPa546sY9tkILtVErqR hUbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=QRQkxIGFI3OF3amcRlbkZf4vgkek6ggFXyd9zidvB8c=; b=r2A9gVlU+ocyMJdj9Jg7fHZeUdFCm7wsyj1h5B6Hla0p3+Ygh/v43mZ3NVoMIoGuTK 5YZHiG8G95BI89csLB6JMnPyRsk1eh//UmYfQWXSeomT6hoNsQ0SS7aIdmkIMDFwjQIj q+IwxRd+erVOJlObdni9ji23SED6smFej2O6WWbz4jsQTYk0QhZ5yu5Bk+ac+7ozRk6Y epAhphNdWGT8AeY1Ezg/8YVXu35mMckYAZOdr4rTJKL3zbK/9SOG3IPr6PQigaJoT8sk 1fvrM3d0N47p/49+P586cLs4w2hyae4+4ur939hQgOSev37zFLkYXDsJNtFMx7UL8Vnx jlxQ== X-Gm-Message-State: ACgBeo01KbgrK8dT78jdE8k5a1fHboiaQgvafm6FNg6IVTqBdQk7ngot pjLFg+PrtsuxKdNYJaUKZzk= X-Google-Smtp-Source: AA6agR6BVwijybUmJvKefzrwHZ9dDsULsMfqVmOf8/ecx+Q6qQipxqieCoJRYSCXP05TF0ANy6CnCA== X-Received: by 2002:a17:902:be03:b0:175:6397:9425 with SMTP id r3-20020a170902be0300b0017563979425mr21493671pls.26.1662418498231; Mon, 05 Sep 2022 15:54:58 -0700 (PDT) Received: from google.com ([2620:15c:202:201:1190:fbfa:ae95:111c]) by smtp.gmail.com with ESMTPSA id d21-20020a630e15000000b0042c2def703asm6833366pgl.22.2022.09.05.15.54.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Sep 2022 15:54:57 -0700 (PDT) Date: Mon, 5 Sep 2022 15:54:53 -0700 From: Dmitry Torokhov To: Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH v1 06/11] PCI: aardvark: switch to using devm_gpiod_get_optional() Message-ID: References: <20220903-gpiod_get_from_of_node-remove-v1-0-b29adfb27a6c@gmail.com> <20220903-gpiod_get_from_of_node-remove-v1-6-b29adfb27a6c@gmail.com> <20220905070046.46nlhczkck2ufr4x@pali> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220905070046.46nlhczkck2ufr4x@pali> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_155500_414178_1E14014F X-CRM114-Status: GOOD ( 29.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Alexandre Belloni , Vignesh Raghavendra , David Airlie , linux-pci@vger.kernel.org, Linus Walleij , Alexandre Torgue , dri-devel@lists.freedesktop.org, Liam Girdwood , linux-tegra@vger.kernel.org, Thierry Reding , linux-mtd@lists.infradead.org, Thomas Petazzoni , Miquel Raynal , linux-stm32@st-md-mailman.stormreply.com, Alyssa Rosenzweig , linux-watchdog@vger.kernel.org, Rob Herring , Marc Zyngier , Bartosz Golaszewski , Jonathan Hunter , Lorenzo Pieralisi , Guenter Roeck , Maxime Coquelin , Matti Vaittinen , linux-gpio@vger.kernel.org, Mark Brown , Bjorn Helgaas , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Vetter , Richard Weinberger , Claudiu Beznea Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 05, 2022 at 09:00:46AM +0200, Pali Roh=E1r wrote: > On Sunday 04 September 2022 23:30:58 Dmitry Torokhov wrote: > > I would like to stop exporting OF-specific devm_gpiod_get_from_of_node() > > so that gpiolib can be cleaned a bit, so let's switch to the generic > > device property API. > > = > > I believe that the only reason the driver, instead of the standard > > devm_gpiod_get_optional(), used devm_gpiod_get_from_of_node() is > > because it wanted to set up a pretty consumer name for the GPIO, > = > IIRC consumer name is not used at all. > = > The reason was to specify full name of DTS property, for easier > identification of the code. DTS property is "reset-gpios" but API > specify only "reset". I see. Do you want me to reset the patch with updated desctiption as to the reason devm_gpiod_get_from_of_node() was used? > = > > and we now have a special API for that. > > = > > Signed-off-by: Dmitry Torokhov > > = > > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/contro= ller/pci-aardvark.c > > index 4834198cc86b..4a8a4a8522cb 100644 > > --- a/drivers/pci/controller/pci-aardvark.c > > +++ b/drivers/pci/controller/pci-aardvark.c > > @@ -1856,20 +1856,19 @@ static int advk_pcie_probe(struct platform_devi= ce *pdev) > > return ret; > > } > > = > > - pcie->reset_gpio =3D devm_gpiod_get_from_of_node(dev, dev->of_node, > > - "reset-gpios", 0, > > - GPIOD_OUT_LOW, > > - "pcie1-reset"); > > + pcie->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_= LOW); > > ret =3D PTR_ERR_OR_ZERO(pcie->reset_gpio); > > if (ret) { > > - if (ret =3D=3D -ENOENT) { > > - pcie->reset_gpio =3D NULL; > > - } else { > > - if (ret !=3D -EPROBE_DEFER) > > - dev_err(dev, "Failed to get reset-gpio: %i\n", > > - ret); > > - return ret; > > - } > > + if (ret !=3D -EPROBE_DEFER) > > + dev_err(dev, "Failed to get reset-gpio: %i\n", > > + ret); > > + return ret; > > + } > > + > > + ret =3D gpiod_set_consumer_name(pcie->reset_gpio, "pcie1-reset"); > > + if (ret) { > > + dev_err(dev, "Failed to set reset gpio name: %d\n", ret); > > + return ret; > > } > > = > > ret =3D of_pci_get_max_link_speed(dev->of_node); > > = > > -- = > > b4 0.10.0-dev-fc921 Thanks. -- = Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel