From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A432AECAAA1 for ; Tue, 6 Sep 2022 01:43:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SAyo4yoG2K4oLgFZfv7KbhxHg00ZztmP7DJfv26WGcY=; b=PCGr1k3463f7Hw aAc0T3IENq1O1m7zZl211mu/gKUmCB8qCHr5++Z6P56XtpHX2FofzrS2KICZbzUZDbY91UmbYbjF3 lYPv221uZR78KGGIiSMpEn61rMqS2sFDBXlrIs3aF1rdfrIcJ1CMzpatdu+oS7crNrhYAc0exkxFd wPXBrL8jMf5jCr6AuE0sKI8kvaziLvSebDjnYk0+1XInu3nE2f/bQtxe1vDHwvHoIhMKOoVgwpMR1 VZn76L8A4Hcl7+llUlxHP8nymXlQ4B3J90Yo7loB2eUt/NUwHn/UwgUKOGtPFDNFSgc0tH3AfhTqw 9wFfHexIkmsWO391lDqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVNb5-001ORl-Am; Tue, 06 Sep 2022 01:41:52 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVNb0-001OPH-UY for linux-arm-kernel@lists.infradead.org; Tue, 06 Sep 2022 01:41:48 +0000 Received: by mail-pj1-x1030.google.com with SMTP id z9-20020a17090a468900b001ffff693b27so8554978pjf.2 for ; Mon, 05 Sep 2022 18:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=wR4LPrjfekVqjvMATBzjqFfhUkvNlLUUdzUvMBxpESs=; b=fAn8Ca6BxfW8B6GwWQ+j/b2XZntmmRVgtRSpX6VUO92+DWvaZokWOokIDmpsUClAJd QKe8lYnSXvInKYIIgHyCLWyePb1+LeYdB04PGDobVVbhPtszGc7TssZgqqbwD46G5tOj iEDf9CWSO8WINiKJLraioNeM/tSh2oG5SDtqc9sBbD+ZpQD3zqBd2MGsomNU+3Eiq36q ignrLr71jr29mS75UAat2TLZVc29hJPp1Bl8rbbXCPTEKzmHrQ7E1nCH3CJZ9XzUUa3f vhOBzDg1ifmg7s7yXmSN3hahrP6nywPDxHy2wvpit2f+QmKPJAluwZBk1UXRWhmV8I6c Nu7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=wR4LPrjfekVqjvMATBzjqFfhUkvNlLUUdzUvMBxpESs=; b=Ed4fhPz8GT0ll3Mtm2ghPx3QWL2hR0KOLINptDWwCOCRa6p6/RCb8q927Pp7cX170B zunu2fpgjfGxNIWJAONKFYd/XUSrWQRBVEshe9kNQDXFk2Z1hNtQVEf1J1fW2vLIn2Oy yWxZzYoIbTLku6ZZP8i2uHHqCwQG/hOYrbNbXYynSNUDFwll22b35C3sAZzxz7APQREb MNVE85Alg23zRo6r8FPuC/A+8+IfQU3Bh4DlT0EaPlXl+Kid4LJYSyFHfWCxuHYOf8MI EexhQsNxC9JJWUngwo8XkTV3uo0QNyXEdW/1pGFSxJrGjD/SUQYq+UuH3w4zL1SlkLRA dTbA== X-Gm-Message-State: ACgBeo0WCkp8EkSADYPjrfMu8Zy/MqI7RD5oCJIzp/vii1YJRlihRzgX aW/SrEo5dUZOLW7FPBJTwA8= X-Google-Smtp-Source: AA6agR5TgrDoVvwWAx1/PpDci1lw+560LvwFEWeXckFE2dCbAKtDFoQDxiEJOJP0QONGukRxKjeH5Q== X-Received: by 2002:a17:90a:5aa2:b0:200:30aa:c773 with SMTP id n31-20020a17090a5aa200b0020030aac773mr12700964pji.182.1662428503955; Mon, 05 Sep 2022 18:41:43 -0700 (PDT) Received: from taoren-fedora-PC23YAB4 ([76.132.249.1]) by smtp.gmail.com with ESMTPSA id cp15-20020a170902e78f00b00176ae5c0f38sm2935022plb.178.2022.09.05.18.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Sep 2022 18:41:43 -0700 (PDT) Date: Mon, 5 Sep 2022 18:41:33 -0700 From: Tao Ren To: Andrew Lunn Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heyi Guo , Dylan Hung , Guangbin Huang , Liang He , Hao Chen , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Tao Ren , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] ARM: dts: aspeed: elbert: Enable mac3 controller Message-ID: References: <20220905235634.20957-1-rentao.bupt@gmail.com> <20220905235634.20957-3-rentao.bupt@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_184147_015600_BC3B9837 X-CRM114-Status: GOOD ( 26.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, On Tue, Sep 06, 2022 at 02:22:50AM +0200, Andrew Lunn wrote: > On Mon, Sep 05, 2022 at 04:56:34PM -0700, rentao.bupt@gmail.com wrote: > > From: Tao Ren > > > > Enable mac3 controller in Elbert dts: Elbert MAC3 is connected to the > > onboard switch directly (fixed link). > > What is the switch? Could you also add a DT node for it? > > > > > Signed-off-by: Tao Ren > > --- > > arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts > > index 27b43fe099f1..52cb617783ac 100644 > > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts > > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts > > @@ -183,3 +183,14 @@ imux31: i2c@7 { > > &i2c11 { > > status = "okay"; > > }; > > + > > +&mac3 { > > + status = "okay"; > > + phy-mode = "rgmii"; > > 'rgmii' is suspicious, though not necessarily wrong. This value is > normally passed to the PHY, so the PHY inserts the RGMII delay. You > however don't have a PHY. So i assume the switch is inserting the > delay? Again, being able to see the DT properties for the switch would > be useful. > > Andrew Thank you for the quick review! The BMC mac3 is connected to BCM53134P's IMP_RGMII port, and there is no PHY between BMC MAC and BCM53134P. BCM53134P loads configurations from its EEPROM when the chip is powered. Could you please point me an example showing how to describe the switch in dts? Anyhow I will need to improve the patch description and comments in v2. Thanks, - Tao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel