From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05953ECAAA1 for ; Tue, 6 Sep 2022 02:22:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v2mYU2zr3iwkEtXczr5nP0yThQIzwDyRypHDg6h7OR8=; b=JNq45meqv2bPVvMxNirvVgsmfE 86CNC5lP5pNFDy/3zuxd8vZ5l8GsqP8sL5UMH08RRH43jm+hazexR4W3EuZ3uoYxlzvXo+cNWEJr5 NTi4G0BerCiG7yNWQ1hOXeqTGiJTFNIiXhtcA//qgjme/Ymt13rO2j4YNaJW2BQ77gfXkms34arXv nL4SZuzfIQ6apzaOPFzPWUb/xw46yoEeqIG8yoWhdxq8XxZoC5hML5pt4l/lIltPKbcrJ+gTRteKy sVSfmGwhq5lifx3x4Vfm1zwd4w82oZVG2izGnmy8Lc1bfH6fiw9xsgLB1A1tYM8TQsvq/kPCE+W98 CwDxy3sA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVODM-001hb6-IA; Tue, 06 Sep 2022 02:21:24 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVODJ-001hX5-IR; Tue, 06 Sep 2022 02:21:23 +0000 Received: by mail-pg1-x52b.google.com with SMTP id s206so9385301pgs.3; Mon, 05 Sep 2022 19:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=/vAljfHVQKdDbVhAfIrYOWlHcfdpbbyTa3VRahPWfYI=; b=O534L2W272BxM0WSHH7xszDUnnM5xK4dX03HeHuoLgKr150AVhpf66fgsMEUZjQfNP tpnfdNXZr7sJ8y3Kth6JswL5u99JAF2fdSMBsnMO5sfcSdxACOZCwzbd4hkzaTy9QHlg TekDgr8EDQ85jqHZDYlXnI6baPUmt+P99+qnor2yOJx5+86JdId0fUIzzmtPxUqC8pAN 7lYnkkW34CfMwcw39DGd5/CIiaDslnZ8tzSvBP11ZWVpGknSoYgE2xW30cCNUPqY7Z+r SCzg0Tom91+6ckqCYubi/u7kaZcrgk5umR+OzdwRZxyfe7VNkHTHL4je9Bd6adOULgSS xpRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=/vAljfHVQKdDbVhAfIrYOWlHcfdpbbyTa3VRahPWfYI=; b=GGDtgYGPOPKGknF3CMyFisVgBDGcNTRabhkFcHAxIHLdf3NaB3zeZwCd7DWQysEcgY wytW1cbef2MbOviGJ1YH5d8vICH4US6VvGt1jKZpcUh3mpuy3nLcubUSORfItB2pLMSW 79Zxpa5XTnPps4RRzLQPEwGKgQ+oPB54CUydwHhlUYiV2SP4JCJTMeTzEgK48hDJYVWu 3aEqmwtm35yuOdW19bNwH3qMke2ZAuagxYXAjP5E2CqvGEZo5ElPlHBFqPKEr3e+OnSp DyFqziN1BpDzcz1Uj+h63IH1zdL0XLZR0QyMspb3BG9Mz9Au/Wu2etJXmLUjUpOQCDgG 03cQ== X-Gm-Message-State: ACgBeo145r8voKaJcjPZu7vFLvCq9j4s/2CUhIbSPihZuZ1pTd/u05Qp iYtyXsHVyUbPnh7oxXuLqj8= X-Google-Smtp-Source: AA6agR4xwamrVgwrwIQTJpnWfOmv0Rb4f9pW+MVs//kAtusqemNCS2zH+QizXMXLsyaXpzm8PFzCjQ== X-Received: by 2002:a63:1e12:0:b0:42b:bb36:f898 with SMTP id e18-20020a631e12000000b0042bbb36f898mr37094069pge.469.1662430875629; Mon, 05 Sep 2022 19:21:15 -0700 (PDT) Received: from debian.me (subs03-180-214-233-83.three.co.id. [180.214.233.83]) by smtp.gmail.com with ESMTPSA id y10-20020a17090322ca00b0016b865ea2ddsm8406737plg.85.2022.09.05.19.21.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Sep 2022 19:21:15 -0700 (PDT) Received: by debian.me (Postfix, from userid 1000) id BA9F9103CFD; Tue, 6 Sep 2022 09:21:11 +0700 (WIB) Date: Tue, 6 Sep 2022 09:21:11 +0700 From: Bagas Sanjaya To: Charles Mirabile Cc: linux-kernel@vger.kernel.org, Peter Robinson , Serge Schneider , Stefan Wahren , Nicolas Saenz Julienne , Mattias Brugger , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, rh-kdlp@googlegroups.com, Joel Slebodnick , Joel Savitz Subject: Re: [PATCH v10 0/6] Raspberry Pi Sense HAT driver Message-ID: References: <20220823174158.45579-1-cmirabil@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220823174158.45579-1-cmirabil@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_192121_662439_19C5D8E8 X-CRM114-Status: GOOD ( 14.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5261179798448081922==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5261179798448081922== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0d7ie7tAKFEy7O0I" Content-Disposition: inline --0d7ie7tAKFEy7O0I Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 23, 2022 at 01:41:53PM -0400, Charles Mirabile wrote: > This patch series adds a set of drivers for operating the Sense HAT > peripheral device. This board is an add on for the Raspberry Pi that is > designed to connect using the GPIO connector and communicate via I2C. >=20 Better say "Add a set of drivers for Sense HAT peripheral add-on device for Raspberry Pi. The device is connected using GPIO connector and communicate via I2C". > This is a refactor of the work of Serge Schneider, the author of a > version of this driver that is currently in the Raspberry Pi downstream > kernel. We modified his code to make it suitable for upstream Linux. >=20 s/We modified his code/The driver code is modified/ Also, I see that description of individual patches is written in descriptive mood. However, it is preferable to write in imperative instead (see "Describe your changes" in Documentation/process/submitting-patches.rst). The specific suggested wordings are in reply to each patch. Thanks. --=20 An old man doll... just what I always wanted! - Clara --0d7ie7tAKFEy7O0I Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCYxaujgAKCRD2uYlJVVFO o/KVAQD5X62mGGJfyokbCip9gU9D0JaVjC8Fv8RYHyhdNzTrGQEAmYIRyFqqj7T3 L4QZk//cVLDCmpu8jgI4FMM3a2XAiwQ= =/4Ra -----END PGP SIGNATURE----- --0d7ie7tAKFEy7O0I-- --===============5261179798448081922== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5261179798448081922==--