From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C819ECAAA1 for ; Tue, 6 Sep 2022 07:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wisDQj17qpTZBtxBXr4QhuA1hWfvrFQeH6VyD/D0leY=; b=zAkZvidlTdp37F GWXahVMlzdhgJ8IcFErPhTGncUj1mMM7jUSTbrhZJo6Vz7a7GvPzPthaLTbngjTrt2/E86hVWm7kH NM0yuk4Fjui1F+Vza/khUL7Crx4IIOeUBvD1cDtw6EefSxAwPLhmQEqwujTNYfeZ/k4oFeueU3vlw ElijJMwoC65H4Cykbfsyf+u7Dj/QbcUTYc5FIZNiqbdpUO/Uydl7IANqnKC+HF3shSbrbCf+JZ9q9 tQxdU5VoWOxiYEk44nsPxyZT5JDNjlMw6BHDK0FLI2lyVSiBPgXDHNE181AF/OBhgBaYh/0E1CFM7 I9w5qwdiNwXJjDHdSUsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVTTh-00B05u-PS; Tue, 06 Sep 2022 07:58:37 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVTTd-00B02s-Gj for linux-arm-kernel@lists.infradead.org; Tue, 06 Sep 2022 07:58:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lLXhTMvjqFFLOX0a6T90Zams+r/sSjtpu4H/nZBakYs=; b=oCINmkxAjl/nzza1v/DJ4U4BvX Fl3q+7uY05Zms4N2oXFzeSLhtW+ZRo4ZRlMh4b+KcteXGCTKB8xd/+NJq/uCZpHMRNbE3si+JcwyR NyzsUI/UJ0ICFYXw5a6mG9PSgKwPHMqVeVCs4N1c2Mjt4UO/PwWzFpMkQmChc8tgBqyO70xGRBGe6 howisr2hDJtidTInx248n/PDcO2KWUJeyIEJBijweEVLsdDTUZ00OjFZK6sjg6xFtmFIX3ohqGOKH oFOH6Dg1J1Z00SP8U/HRx0Tkw5dCR4h/rehOElnsgcMOeV2eEWpeWGMsNDJ1Ys3b5V3f/GIFdY6KS lMtaPBRQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34140) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oVTTX-0003a3-6a; Tue, 06 Sep 2022 08:58:27 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oVTTV-00086j-Fp; Tue, 06 Sep 2022 08:58:25 +0100 Date: Tue, 6 Sep 2022 08:58:25 +0100 From: "Russell King (Oracle)" To: Sven Peter Cc: Jassi Brar , Hector Martin , Alyssa Rosenzweig , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] mailbox: apple: Implement poll_data() operation Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220906_005833_574221_A9A3A5B9 X-CRM114-Status: GOOD ( 18.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 05, 2022 at 07:03:39PM +0200, Sven Peter wrote: > > > On Mon, Sep 5, 2022, at 18:48, Russell King wrote: > > From: Hector Martin > > > > This allows clients running in atomic context to poll for messages to > > arrive. > > > > Signed-off-by: Hector Martin > > Signed-off-by: Russell King (Oracle) > > Reviewed-by: Sven Peter > > with one small comment below: > > > --- > > drivers/mailbox/apple-mailbox.c | 37 ++++++++++++++++++++++++++++++--- > > 1 file changed, 34 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/mailbox/apple-mailbox.c b/drivers/mailbox/apple-mailbox.c > > index 33e7acf71e3e..1c14ff63f3d3 100644 > > --- a/drivers/mailbox/apple-mailbox.c > > +++ b/drivers/mailbox/apple-mailbox.c > > @@ -26,6 +26,7 @@ > > #include > > #include > > #include > > +#include > > #include > > > > #define APPLE_ASC_MBOX_CONTROL_FULL BIT(16) > > @@ -101,6 +102,7 @@ struct apple_mbox { > > > > struct device *dev; > > struct mbox_controller controller; > > + spinlock_t rx_lock; > > }; > > > > static const struct of_device_id apple_mbox_of_match[]; > > @@ -204,13 +206,16 @@ static irqreturn_t apple_mbox_send_empty_irq(int > > irq, void *data) > > return IRQ_HANDLED; > > } > > > > -static irqreturn_t apple_mbox_recv_irq(int irq, void *data) > > +static int apple_mbox_poll(struct apple_mbox *apple_mbox) > > { > > - struct apple_mbox *apple_mbox = data; > > + > > small nit: there's a spurious white line here Thanks, well spotted. Will fix. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel