From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 547AEC38145 for ; Tue, 6 Sep 2022 04:56:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RzTL9reERPasg9UQghpH4oax8Ud217ifbHGPuX2PIu0=; b=XqsDp+5rCFwryr ihKPFf1/Ecirf5l+vR/oIFmIt30hWHzKVZsyxpkxuEIZu+zM6O/2lLfaz6R1XDbPAWkDetflJyJ8k ZaJslnEum7TvmRpNS2MDrZkdwPbz0+xsceycPZoo4WXFFqz0G8EHHiBavFu29iPyIWCUBXV8+szvt JmsaEd21eqpKniYmYWJnR6NFaTeYe2HlWuZ/NkbIU9e7nGLnQ10h0cWaLYkp6NDP6KQZn7F8FPtQ0 6Zefy/xaPDqdk47r7fBLuA4q4bidlTYPY7tF9EozTe+Vv0PTOIbnEtr+r+5NkyChwtwgjAtfH02aa 0KF7HvC3Tw19XjmI05DQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVQbw-008muY-02; Tue, 06 Sep 2022 04:54:56 +0000 Received: from out1.migadu.com ([91.121.223.63]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVQbq-008mMU-3j for linux-arm-kernel@lists.infradead.org; Tue, 06 Sep 2022 04:54:52 +0000 Date: Tue, 6 Sep 2022 05:54:40 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662440083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hEQ8207Wqe20jUMzx18IBRP3OCnR8vMZaKCXgkLkmoI=; b=cpKKgUdkl1pr2b5NAK+po55wTT4lLZFVj2qXXrk+tQJtYXNItl2oTLRu2W5BbAdhXBxw2d zVPdqLj35UVIKoqWdjwC+LOeaHmkB4MQkY09RikH1UtRHMJYcb+LiGFTEEvAfDSNba37CD z91nYZEs/rqeI0hbE1URG2e9enSD2Vs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Andrew Jones Cc: Marc Zyngier , James Morse , Alexandru Elisei , Paolo Bonzini , Shuah Khan , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Reiji Watanabe , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 7/7] KVM: selftests: Add test for RAZ/WI AArch32 ID registers Message-ID: References: <20220902154804.1939819-1-oliver.upton@linux.dev> <20220902154804.1939819-8-oliver.upton@linux.dev> <20220905073140.lrsrbyu2zhkiki5a@kamzik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220905073140.lrsrbyu2zhkiki5a@kamzik> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_215450_375502_92E2F7BC X-CRM114-Status: GOOD ( 10.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Drew, On Mon, Sep 05, 2022 at 09:31:40AM +0200, Andrew Jones wrote: [...] > > +static uint64_t reg_ids[] = { > > + KVM_ARM64_SYS_REG(SYS_ID_PFR0_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_PFR1_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_DFR0_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_MMFR0_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_MMFR1_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_MMFR2_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_MMFR3_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_ISAR0_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_ISAR1_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_ISAR2_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_ISAR3_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_ISAR4_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_ISAR5_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_MMFR4_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_ISAR6_EL1), > > + KVM_ARM64_SYS_REG(SYS_MVFR0_EL1), > > + KVM_ARM64_SYS_REG(SYS_MVFR1_EL1), > > + KVM_ARM64_SYS_REG(SYS_MVFR2_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_PFR2_EL1), > > + KVM_ARM64_SYS_REG(SYS_ID_MMFR5_EL1), > > Hi Oliver, > > I see all the hidden and unallocated registers have been filtered out of > the test lists. They should also behave as RAZ, right? Maybe we should > keep them in the lists here for consistency and to test them as well. Sure, can do. The reason I only tested these registers is because they have RAZ/WI behavior with this series, whereas the rest are RAZ + invariant. Should be easy enough to cover the whole range, though. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel