From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AD84C38145 for ; Tue, 6 Sep 2022 06:29:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UKJ9jGkVfqPQwie6aP+saV9TgMI1ChepLyVcsIJnuws=; b=tXGzxbPido/fp2 4PNbWBU3piAPTElYC92DyR59QRQFyVGAK/fG7JDlIl8t6kpKQU6yIs2PiYsc3IfUlDjL333h2ElbK /dzPzUJ8hHyb+kvDLwP8KYjDBap3IZJtq1X7pwGu3Cqo2l2sITfUioSASWwwzUyCzxm9v6B4ZQVnK f8wY8ttXSo3MIk935CusJs3ih7Z2MV5jgGxb8A2/DhLm+1YqNjJ6vptcIKNq/UI+pP0H4en8dK7EI hsUXF2PR/XKQYDef8pL6dce6oEhSjSPeUqMvyZ8Cr4D4p61xjsiR6W6TRw6YALymkYrGkNOqjuo06 sUYfCpRB2sMZYDxzEUEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVS41-00AP0i-Q4; Tue, 06 Sep 2022 06:28:02 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVS3v-00AOxT-3z for linux-arm-kernel@lists.infradead.org; Tue, 06 Sep 2022 06:27:58 +0000 Received: by mail-pl1-x633.google.com with SMTP id s14so754309plr.4 for ; Mon, 05 Sep 2022 23:27:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=tZGkVWfVwu3VMSzAGROw7vkLVEx9FkktQXY75aiAv1g=; b=q5hGWkzHC+IcxG4HYOa7ijNSm1gIy0xI5yvRIJoJ4rgtFb2yeGg7eV0Lgc8rAzwEyh /QWrx4UiRJbjR2JAimM/PiPuId0VOld9GL6aNQX60m10yKQ3PY4GXU4P0J5Qfj+tgw/D 6Hhqvib3H9O+nL22TPeHRfO/axMjJNt23nIm9cgDFLQrD32clHnaShP4nWQe5Gj3lIp/ owHKctlCy1/sheAOOwGmfruXxWvuJi7QF+kUQOZVB5KwuStkhy8x4nUJZbOrG/W7gZEW Q3HfIxUSPIf3wLI/8Z6m8zljULEgzTDuyImYCzcxsooqpotxIO4mGp2rrvhmSXoveut/ g/ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=tZGkVWfVwu3VMSzAGROw7vkLVEx9FkktQXY75aiAv1g=; b=0IoCPL/L/HUwAUmu+DvY8VWt7mxaGIptsL23Jm4OZ3Z1NG4BHJn1uKY64RZAVlz5x6 QYPo4bo10dk4aLuFsp1RrhZfobNJoSJYQtaH4nqwqmfZYaF0yd4slkNgQHJk5e+vfqYd mKslsddi7ERD22ZQmAA3QVkOrBJCTyK14CfuKMuN+kxxMlytQrEeFM2+6Hs3btKr+L8S 70z6xpnsgO8Q+HXeIxMqMGjRClUL75Hf62hYtzOP2Zts+EBJ+DRjyvS2PNyg43IYVkCy BTJGzNq11vg29hGB5ZuzZKhdC4J7U2ToH7WO5b70Z4sWLiKpORFogTmdL6SUBJm+b853 OK/A== X-Gm-Message-State: ACgBeo2TqiTHo1s3UQMyzyTe+ZbKlWDUKMCY0ZVUviVaER6hXHN9wOrB c02w9Hdww+tfrlDwH0wCojw= X-Google-Smtp-Source: AA6agR6bqQvVPxZDdNU9/IYUxuqxClwUpHLhvoX7Ki3t2GJAr6RH4b3PG2Cl6yU8oos1upmBqsa86w== X-Received: by 2002:a17:90a:5988:b0:1fd:6a33:abf with SMTP id l8-20020a17090a598800b001fd6a330abfmr23105126pji.69.1662445672225; Mon, 05 Sep 2022 23:27:52 -0700 (PDT) Received: from taoren-fedora-PC23YAB4 ([76.132.249.1]) by smtp.gmail.com with ESMTPSA id 5-20020a170902c24500b0016dc78d0153sm842426plg.296.2022.09.05.23.27.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Sep 2022 23:27:51 -0700 (PDT) Date: Mon, 5 Sep 2022 23:27:42 -0700 From: Tao Ren To: Karthikeyan Pasupathi Cc: Rob Herring , Joel Stanley , Andrew Jeffery , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Subject: Re: [PATCH v1] Update for Facebook yosemite V2 BMC. Message-ID: References: <20220906050702.GA10565@hcl-ThinkPad-T495> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220906050702.GA10565@hcl-ThinkPad-T495> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_232757_081678_E0CA6F37 X-CRM114-Status: GOOD ( 17.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Karthikeyan, I don't have much experience with ipmb-dev, but I'd suggest updating the patch tile so it's consistent with other dts patches. For example: "ARM: dts: aspeed: yosemitev2: Enable i2c13 controller" Cheers, - Tao On Tue, Sep 06, 2022 at 10:37:02AM +0530, Karthikeyan Pasupathi wrote: > Added IPMB-13 channel for Debug Card communication. > > --- > --- v1 - Initial draft. > --- > > Signed-off-by: Karthikeyan Pasupathi > --- > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts > index 8864e9c312a8..84236df522dc 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts > @@ -215,6 +215,17 @@ > }; > }; > > +&i2c13 { > + status = "okay"; > + // Debug Card > + multi-master; > + ipmb13@10 { > + compatible = "ipmb-dev"; > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; > + i2c-protocol; > + }; > +}; > + > &pwm_tacho { > status = "okay"; > //FSC > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel