From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Michael Walle <michael@walle.cc>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v1 1/1] pinctr: microchip-sgpio: Correct the fwnode_irq_get() return value check
Date: Tue, 6 Sep 2022 14:47:38 +0300 [thread overview]
Message-ID: <YxczWhMyDJgC5jmP@smile.fi.intel.com> (raw)
In-Reply-To: <21f2241f19003a1210bd475883ee077b@walle.cc>
On Tue, Sep 06, 2022 at 12:24:43AM +0200, Michael Walle wrote:
> Am 2022-09-05 21:08, schrieb Andy Shevchenko:
> > fwnode_irq_get() may return all possible signed values, such as Linux
> > error code. Fix the code to handle this properly.
> >
> > Fixes: be2dc859abd4 ("pinctrl: pinctrl-microchip-sgpio: Add irq
> > support (for sparx5)")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Reviewed-by: Michael Walle <michael@walle.cc>
Thanks! I will send a v2 since I have to fix a typo in the Subject.
> Btw. do we care about EPROBE_DEFER?
In the original code this big (unsigned) value was added as parent IRQ and
things wouldn't work, with the proposed change IRQ won't work, but at least
in robust way without any surprises (whatever big parent IRQ number mean).
I think the people who have access to hardware and different configurations
of the kernel may or may not add the support later on.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-09-06 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 19:08 [PATCH v1 1/1] pinctr: microchip-sgpio: Correct the fwnode_irq_get() return value check Andy Shevchenko
2022-09-05 22:24 ` Michael Walle
2022-09-06 11:47 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxczWhMyDJgC5jmP@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=lars.povlsen@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).