From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89C68ECAAA1 for ; Tue, 6 Sep 2022 11:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SC40seilIV8PQFoaqel1Pz5aZdiBAjLYFAyQmKItQTs=; b=KkoNhvcMo24m6h cTgQDn9xKWttJjY0CrWW6roAq8RNh4sGrFPo9U2zRmPp08iK7mVUhUrUH/8zSQIAMR7pesw03VM5D 8GbF6260btj6jgMQn1+PWDDV9BA8HEucH69LBoNRYlz8sqZ2Su8j7tAjMlaacbRl/VOdtv6QRluBe qVhNqMH04uTHjgw2fu2J1pyVCkQs5MNWW+3pOt4r3qfRGgzMae96YA43aXt4sIaAmdZh05yIXBdR6 eBNNCjmLZX34ZEIT/bilr059yiswDrfNDxTAXn7iLIHi6EGQBlmmGZaxxZ/pX1apgz2jWlPfHWrx3 IPYlHGOz/75f/VWgaebQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVX3c-00D0fh-VW; Tue, 06 Sep 2022 11:47:57 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVX3a-00D0dq-FP for linux-arm-kernel@lists.infradead.org; Tue, 06 Sep 2022 11:47:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662464874; x=1694000874; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZFdAqLLCkAK18dTg0m9aGKuAoPgAnLxj5S7NDofG9Z0=; b=SUtHuuzBADM3H4Wiqpn+rfJm1tU2tvdl/aWWcnfq8il5oc+hgr8ht9+S KaHJehZAAPisMtcWw2D6xt9MFk7D8N9NzrkV4REJiHHeSDPzTJ6BhXKlR TNjrYyootp+veOs99YEPj/6yu5k0I4AgCk7DSfwIMWU7W98gg0z3fo6Or id5qez0sAF0rdi/TMMIr/C8XvSQFk/lfqB8eUWsaja/sbwVTwAqIYjIeC llNRAJcEegA6lsv4c9LATnKcxpnh5z8weKms48NYtsoPzbdHiIV6Fr6Ks VKNm+/tQp2QMObxzvP1fR1btX732+BftRDzpdO31P2ws8ezs040Cv927s A==; X-IronPort-AV: E=McAfee;i="6500,9779,10461"; a="283567092" X-IronPort-AV: E=Sophos;i="5.93,294,1654585200"; d="scan'208";a="283567092" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2022 04:47:43 -0700 X-IronPort-AV: E=Sophos;i="5.93,294,1654585200"; d="scan'208";a="682371275" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2022 04:47:41 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oVX3K-009663-1t; Tue, 06 Sep 2022 14:47:38 +0300 Date: Tue, 6 Sep 2022 14:47:38 +0300 From: Andy Shevchenko To: Michael Walle Cc: Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com Subject: Re: [PATCH v1 1/1] pinctr: microchip-sgpio: Correct the fwnode_irq_get() return value check Message-ID: References: <20220905190849.73194-1-andriy.shevchenko@linux.intel.com> <21f2241f19003a1210bd475883ee077b@walle.cc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <21f2241f19003a1210bd475883ee077b@walle.cc> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220906_044754_579855_16083EAB X-CRM114-Status: GOOD ( 15.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 06, 2022 at 12:24:43AM +0200, Michael Walle wrote: > Am 2022-09-05 21:08, schrieb Andy Shevchenko: > > fwnode_irq_get() may return all possible signed values, such as Linux > > error code. Fix the code to handle this properly. > > > > Fixes: be2dc859abd4 ("pinctrl: pinctrl-microchip-sgpio: Add irq > > support (for sparx5)") > > Signed-off-by: Andy Shevchenko > > Reviewed-by: Michael Walle Thanks! I will send a v2 since I have to fix a typo in the Subject. > Btw. do we care about EPROBE_DEFER? In the original code this big (unsigned) value was added as parent IRQ and things wouldn't work, with the proposed change IRQ won't work, but at least in robust way without any surprises (whatever big parent IRQ number mean). I think the people who have access to hardware and different configurations of the kernel may or may not add the support later on. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel