From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH v1 1/1] iio: adc: mxs-lradc-adc: Get rid of OF specifics
Date: Tue, 6 Sep 2022 16:36:20 +0300 [thread overview]
Message-ID: <YxdM1KUFcdVlnKuO@smile.fi.intel.com> (raw)
In-Reply-To: <20220620204225.34d40a3f@jic23-huawei>
On Mon, Jun 20, 2022 at 08:42:25PM +0100, Jonathan Cameron wrote:
> On Fri, 3 Jun 2022 18:10:06 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
> > On Mon, 30 May 2022 20:33:24 +0300
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >
> > > First of all, the additional conversion from vIRQ, and this is exactly
> > > what is returned by platform_get_irq_byname(), to vIRQ is not needed.
> > Confusing sentence form. Perhaps:
> >
> > First, the additional conversion from vIRQ (returned by platform_get_irq_byname())
> > to vIRQ is not needed.
> >
> > > Hence, drop no-op call to irq_of_parse_and_map().
> > >
> > > Second, assign the firmware node instead of of_node.
...
> > Seems sensible to me, but I'd like a sanity check from someone more
> > familiar with this driver.
>
> This one has been outstanding for a few weeks. I'd still like
> an Ack or similar form someone who knows this device well.
>
> If no one has looked at it in a week or so I'll just go with
> my judgement and pick it up.
Any news on this one? Maybe I need to resend with the better commit message?
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-06 13:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 17:33 [PATCH v1 1/1] iio: adc: mxs-lradc-adc: Get rid of OF specifics Andy Shevchenko
2022-06-03 17:10 ` Jonathan Cameron
2022-06-20 19:42 ` Jonathan Cameron
2022-09-06 13:36 ` Andy Shevchenko [this message]
2022-09-11 9:52 ` Jonathan Cameron
2022-09-12 10:21 ` Andy Shevchenko
2022-09-12 10:24 ` Andy Shevchenko
2022-06-20 21:13 ` Fabio Estevam
[not found] ` <CAHp75Vd9yah3D8dUOPinhj=nm9GQs3xOsWZRL=6CvaROZC3OCQ@mail.gmail.com>
2022-06-20 21:56 ` Fabio Estevam
2022-06-21 10:26 ` Andy Shevchenko
2022-06-21 10:35 ` Andy Shevchenko
2022-06-21 10:58 ` Andy Shevchenko
2022-06-21 11:06 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxdM1KUFcdVlnKuO@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=festevam@gmail.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).