From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55CDAECAAA1 for ; Wed, 7 Sep 2022 01:09:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7kSU7kUTzupTrhEw/89u2cJCN60KYugsjIGHHoGY8Jw=; b=MOR56IEV8bvSio dGZkyn9HLTgL6jkQwqD7LLEJbFJUDjyWAvcJYyqanSKrA5uv7Y9OX0nrFAIIWDABVmfukC58+iNoG oGEv+MatyWuivMkcVjB2/F4NB0mTnX/0yez1s9lF5MksLbP/uR/XzDohEtKorVTIBeTPTDzjikj/P aWiGM9V8SYCu2LYujAvnzAOTrWcg0Gbid/Wn1Tlv0IZpdyJ22gq1gYwk0u79Ua9SpRKVJVA8GTkA8 ldnD7F0ewdUIOoimnoiofbedr5dtfBQYrdZAWEOfocc0X9dl4KuaWvq84dbUsIlD96VrYFDyRo2GU FXSXIfubGxyU0JBeCi2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVjYA-001AaB-AH; Wed, 07 Sep 2022 01:08:18 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVjY6-001AXS-Bm for linux-arm-kernel@lists.infradead.org; Wed, 07 Sep 2022 01:08:15 +0000 Received: by mail-pl1-x632.google.com with SMTP id p18so12958004plr.8 for ; Tue, 06 Sep 2022 18:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=4/ZIZdVDq8QafnDshkBp2uy/VhVapnzNn87zZZcPkMs=; b=BXCJ/81wXRUVjLzY5YNY5ye2rZiq86cruthWzZHRASDILgN42toBND9Kb/oCI8DphG wOIZs5V3vi3G2eOQ8siyMkOd0WguXRDXSLb5t6LhaQm6ADHwIEP81mnE2AGSMfO/+krw Mr65tQ0TG93dXkc8fXfbTgIUIl/G8UnEASBjLNMoKbQHAAskGXHNmOULrObU/hUKCDua AeukbRKsMK3P+J3bP1eBo/mEYdhQNlqEShfWIKtcpVPBTrJ7L3YYPOo9pOpJMvZmjN76 MLWvhHFAeCKvXXsFZRSfaakgapGZlABn/kUgXHUNLrIDOPQlbYaE7Ik5yvYU0e6HUMlt jaWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=4/ZIZdVDq8QafnDshkBp2uy/VhVapnzNn87zZZcPkMs=; b=3UTl+cPLOtTjyJu/2NIK0xVtEnR1O4bP4v+iKEAt009aGaMHyCcwa61KAB3iUuSDPA Vkd6oB4OsutaH8Iiqv1ODAAUMo71QnfeSPP7fzZYrRYmy84aEPSyJeqDmIxDsmti893O lFSMjgWqhE6qhIYWqozdXKx21/RO6OWLmWb8zKHJ1UzpVWKuqPnYkV6haH3Ma0GFJV+w 8TTFxUn7EkWTQzQiK1fmmXN2dQcihswosFTglfBwkC5jWfAeb+CLbtcZtMkcAS2xqs/0 6nDk2KxkTjqItEEiYQwxhGVGSzztRzvKFKKybk+AMuQ7qy5mnYqqD/wHeQJkXATae9uA F9Tg== X-Gm-Message-State: ACgBeo1Li5HOjigZHt2iIZDKclThiBqwXqZpqzJnTZCECm9R6D1Y4yhN jraq3gDK1nDjlu6c8PXVRMQ= X-Google-Smtp-Source: AA6agR57Xaz/Sv3hksaBQZHcfqE+BOwZHQhh0tXNqUeibP9IAHNiFB2O+UvExvW6jYOK4VgxY94zGQ== X-Received: by 2002:a17:902:a5c7:b0:172:dd10:f638 with SMTP id t7-20020a170902a5c700b00172dd10f638mr1323811plq.127.1662512890636; Tue, 06 Sep 2022 18:08:10 -0700 (PDT) Received: from taoren-fedora-PC23YAB4 ([76.132.249.1]) by smtp.gmail.com with ESMTPSA id om2-20020a17090b3a8200b001f22647cb56sm13392417pjb.27.2022.09.06.18.08.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 18:08:10 -0700 (PDT) Date: Tue, 6 Sep 2022 18:08:05 -0700 From: Tao Ren To: Andrew Lunn Cc: Florian Fainelli , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heyi Guo , Dylan Hung , Guangbin Huang , Liang He , Hao Chen , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Tao Ren , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] ARM: dts: aspeed: elbert: Enable mac3 controller Message-ID: References: <20220905235634.20957-1-rentao.bupt@gmail.com> <20220905235634.20957-3-rentao.bupt@gmail.com> <45cdae58-632a-7cbb-c9d5-74c126ba6a3e@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220906_180814_446024_EACDD92D X-CRM114-Status: GOOD ( 18.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, On Wed, Sep 07, 2022 at 02:36:33AM +0200, Andrew Lunn wrote: > > Specific to this Elbert platform, we don't have plan to configure > > BCM53134 via OpenBMC MDIO (dts), because we expect the switch always > > loads configurations from its EEPROM. > > DSA offers more than configuration. You can also get interface > statistics, and knowledge of if an interface is up/down. And since the > PHY of the switch becomes normal Linux PHYs, you can do cable testing, > if the PHY has support, etc. > > Do you have spanning tree to break L2 network loops? Linux will > provide that as well. > > However, if you are happy with dumb switch, then what you posted is > sufficient. > > Andrew Apprently I have very limited knowledge in DSA area, because I didn't know these features. I will keep the patch series as is for now, to at least enable ethernet in Elbert OpenBMC, and will work out new patch series to add BCM53134 in DSA later. Thanks again for the review. Cheers, Tao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel