Re: [PATCH] arm64: dts: imx8mp: correct usb clocks

[Abel Vesa <abel.vesa@linaro.org>]

On 22-09-06 11:30:14, Jun Li wrote:
> +Abel
> 
> > -----Original Message-----
> > From: Shawn Guo <shawnguo@kernel.org>
> > Sent: Tuesday, September 6, 2022 6:19 PM
> > To: Jun Li <jun.li@nxp.com>
> > Cc: Marco Felsch <m.felsch@pengutronix.de>; robh+dt@kernel.org;
> > krzysztof.kozlowski+dt@linaro.org; s.hauer@pengutronix.de;
> > kernel@pengutronix.de; festevam@gmail.com; marex@denx.de;
> > devicetree@vger.kernel.org; Peng Fan <peng.fan@nxp.com>;
> > Markus.Niebel@ew.tq-group.com; laurent.pinchart@ideasonboard.com;
> > paul.elder@ideasonboard.com; dl-linux-imx <linux-imx@nxp.com>;
> > aford173@gmail.com; linux-arm-kernel@lists.infradead.org;
> > l.stach@pengutronix.de
> > Subject: Re: [PATCH] arm64: dts: imx8mp: correct usb clocks
> > 
> > On Tue, Sep 06, 2022 at 09:49:28AM +0000, Jun Li wrote:
> > > Hi Shawn,
> > >
> > > > > > > Hi Li,
> > > > > > >
> > > > > > > On 22-08-24, Li Jun wrote:
> > > > > > > > After commit cf7f3f4fa9e5 ("clk: imx8mp: fix usb_root_clk
> > > > > > > > parent"), usb_root_clk is no longer for suspend clock so
> > > > > > > > update dts accordingly to use right bus clock and suspend clock.
> > > > > > >
> > > > > > > Please don't send two seperate patchsets for this topic, since
> > > > > > > they can be applied delayed. So your v2 should contain the
> > > > > > > patches from [1]
> > > > > > as well.
> > > > > >
> > > > > > Understood, I will put all in one patch set in v2.
> > > > >
> > > > > Since the clock part patches[1] already were accepted, I think
> > > > > this corresponding dts fix patch should be okay as it is.
> > > >
> > > > Should I apply the DTS patch for v6.0-rc or v6.1?  My understanding
> > > > is that it needs to appear in the same release as clock patch[1], right?
> > >
> > > Yes, it needs to appear in the same release as clock patch[1].
> > 
> > So could you find out which release the clock patch is targeting?
> 
> Seems the clock patches[1] are only at Abel's tree. 

Right, but your patch didn't have any Fixes tag.

So I think I need drop your patch from my tree for now and you need
to resend a new version with Fixes tag, which probably will be going
through Stephen's tree.

> 
> Actually this dts patch and clk patches[1] should apply for the
> releases with below patch:
> 
> commit cf7f3f4fa9e57b8e9f594823e77e6cbb0ce2b254
> Author: Peng Fan <peng.fan@nxp.com>
> Date:   Sat May 7 20:54:30 2022 +0800
> 
>     clk: imx8mp: fix usb_root_clk parent
>     
>     According to reference mannual CCGR77(usb) sources from hsio_axi, fix
>     it.
>     
>     Fixes: 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver")
>     Signed-off-by: Peng Fan <peng.fan@nxp.com>
>     Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
>     Link: https://lore.kernel.org/r/20220507125430.793287-1-peng.fan@oss.nxp.com
>     Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
>  
> So it should target v5.19, v6.0rc and v6.1
> 
> Do I need resend the patch with stable tag applied? like
> Cc: stable@vger.kernel.org # v5.19+

And yes, cc stable too.

> 
> [1] https://lore.kernel.org/linux-arm-kernel/1661328262-3867-2-git-send-email-jun.li@nxp.com/
> 
> Thanks
> Li Jun
> 
> > 
> > Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel