From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69BAAC54EE9 for ; Wed, 7 Sep 2022 13:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZS2TcyH7s4PMQDEG6pjDjIlc0rPSTmNOPE0Ks/tPr6g=; b=LHlbBIXpeI2SGN e6huXngs38xAbzkeZcLHeUNHG+KkKCOiNusWMSWcaYQVbxGyD8Oh3IyuxJTXzfvfXfDOzryoh3TzX DWGjBAq18J4mz6i+ZXUyLbLPEcugrR/DWlz7I9N41mH+3dHJvlHSGAN3hCuYhq6aIrpJ4RdSvkR3N Uk4YWG6UGeK/L/A65Jg7Gz446Iw3SkyfQmJZu/8DfNjuzm8O8TFz670slnLHaMxUu4SyHEUJ7cAZf Yf4my5B6YW9Ywk1WDs3S2frvvTS9FKyzsroyAgP2cgC/gFG/7mGUqueSOg2zB8Q8DbmN1+SXjDyAA 29NQa9QKH6Y9VIz3BvPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVvPD-006bv8-37; Wed, 07 Sep 2022 13:47:51 +0000 Received: from mail-co1nam11on2062.outbound.protection.outlook.com ([40.107.220.62] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVvP8-006brq-4y for linux-arm-kernel@lists.infradead.org; Wed, 07 Sep 2022 13:47:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i5TpSIbp7n4FdX03af0ZmzI4ryWc4TMAuZkv3OvL9l05db+cVpGU7AE3tL2J84r/TVILeTiDUjN5J25Uupx/FceUrz31NP+F3CpTMaExT48047NkmjH0lnI0NXB6JeQU6yxa3HODwgeNcvwYhvUUzNimReo5CDtSk364dCr0WZjoe+P5RLuu6Yuo1hdVQtq0UAjXL0FCwbMEhtjRuUGuGvbhr12I6jAjjy/KavShAUlmgCqHpunyxClfmuBnXqG5yHjvdrm5+hmTiLrEStXfLPV4BQ9XH33GStcLYZQP+hOsnnnjLZNlH5X3NRcXGs/bb8n+ZTq4Y/H/jnNYli2rRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YZWsgruCQzrAAiboQObmvUv93DwUbOOZ9VLx2Vr9ey4=; b=MouwyBWWvOnBlTWrtdnhhZB21loxIt1GbcX4qiRPmJQhHKyPCCwmrA5OfC65CD/PVw77MBCsRKwp3zZHhgyPqcG7ZmhD0pblOInZ9MLQ32im5SBJLzTwvK2GN5KsqPgNrxLUJGy4IHN791mEP1o+udQGf1bvDoiA/Sh4BKtgzqByVm6/D83xH0nsg4Vo3iBvCpp60f/yfHMtCb8knoj9T9sGtCk4//ugjiWWKOCcwILdl5RKEAeTU5GXSomAkKElb5ptnuw3GQJeoWFLc4Vt82ViGIpf1Ns74bzJszOuHtycwdFNJQ3no3FNHP4LakCulgESbmLL7x6HV0rHm27aJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YZWsgruCQzrAAiboQObmvUv93DwUbOOZ9VLx2Vr9ey4=; b=kRFiAR9hNc6FYP82KRGlAD0AcdHfu9fdrlWuiSInIuSzALPTktlPyAboGHtuz4TP8xEaewQuLoPgJwsB/6Rk+qiO5hVmQyltlot0+Twldf1tNYrbK/MQp8dAytI/yFCAAQaKsSXr1s6cP0WSzCRwcEFFim/Ib1iH2X8TfRuUHhEiRnMvwOYZLRvwZENKaKEvvjx5uuvA/+NT6KJvacgu6922Pbf+0UFnV4kKn1wVQyeL3wIBEZ886y+Dm6vRJtj6sDw6sM5XuRVYqbYGRF/nDN01iL5EX5U1oGfcGR4eV7Y5A63jl+gXnq6a4qfpee6zk2yruaaRC0vJBLCGt9Jp7g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from MN2PR12MB4192.namprd12.prod.outlook.com (2603:10b6:208:1d5::15) by CH0PR12MB5331.namprd12.prod.outlook.com (2603:10b6:610:d6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 13:47:40 +0000 Received: from MN2PR12MB4192.namprd12.prod.outlook.com ([fe80::462:7fe:f04f:d0d5]) by MN2PR12MB4192.namprd12.prod.outlook.com ([fe80::462:7fe:f04f:d0d5%7]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 13:47:40 +0000 Date: Wed, 7 Sep 2022 10:47:39 -0300 From: Jason Gunthorpe To: Joerg Roedel Subject: Re: [PATCH v6 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group Message-ID: References: <20220815181437.28127-1-nicolinc@nvidia.com> <20220815181437.28127-2-nicolinc@nvidia.com> Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BL1PR13CA0090.namprd13.prod.outlook.com (2603:10b6:208:2b8::35) To MN2PR12MB4192.namprd12.prod.outlook.com (2603:10b6:208:1d5::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 939f968a-b589-4854-2b87-08da90d78847 X-MS-TrafficTypeDiagnostic: CH0PR12MB5331:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NBMQxxKiyzg416DV7jH4U4XBQM+V94ouj2MvUczjBjUVT1dsKyi+I0hmF5qcbRIxWTENbw1sKdDYecITGKwSFyllmjXq8s3BFlqgV9Mm9bouqppxVJjCWees1FD4+4CYQ83PQbMY0ei+Jd5sk3LyQc7pJuEA4DG/TjnF9No51zGOmqXjUID7GE3aYwCzRuXJbo3bEpF1nEWSGBLyiSyKH1o5ptvC/oqtOMc2u9qQl61J1h8MoGmeyQZshLLmv95TkByc/ZaNfUMzVnGHa37yBVk66yFhaTWJj13YkIoEqX6zngVzQxe0tENXHBtDO9GuK4VxiMEU6K/UnZpBZezylCo/QdHq9B6IdXoC7y/ItJkozYGiu8htogeHloMVAAnh0UTwNCFodNfH8O38s2kLlJkbV6Ph5Y6+bb+K6mBRJo0lESCgE5V17raQM8vSCbGu1pzPTWXSp2iHscT3fj+WHdcGX3FEljl54jna4Ia7H9w9EQ7Nh/Hzo+jVaEPonrdKoQxRYGzUuQIjBsJGdTIevJ73n2LpaiSNF1+EHZkzjVsa+0hVQuQ6SUvtIPuRO7K+jqBDTQq1EnrhVMBXLBDEO10D7odmfuAtnHmUEbtJtHFCdiRqF+WqByhcSM6nKNN7ZGT+i+NHT78xhtByWKpoVF2BfDBHtfpQUfcEv+YIpnfVlRuvUtM7ZodXjdLb1okut9XuiiUGckb+am7BGMmTjhE0MWOVrpOGbL0J5FBv5r8gphtoySQGlaVPMfO1AYy0 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB4192.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(376002)(136003)(39860400002)(366004)(66946007)(478600001)(66556008)(4326008)(8676002)(41300700001)(8936002)(5660300002)(7416002)(7406005)(6486002)(2906002)(26005)(6506007)(6512007)(38100700002)(66476007)(86362001)(186003)(83380400001)(2616005)(316002)(36756003)(6916009)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kJ+P/cwLYf8csGl5q/TUd+eu3EG72FWaZXcxc2KAqanrOU7ITm7jpkCzPtsg?= =?us-ascii?Q?NPePokI8I4CbUxFp+Sud/jIwqKRBGR17PCs3S2LrEILS3e0EwrhmqYj5tHrD?= =?us-ascii?Q?WNuK0nP4zvPCr5f2Nm4dONUARBTLWoCrIz/6i4c8/J2HcmN0pM/ia/RG2vjU?= =?us-ascii?Q?knWJjWf5VkG86kpn8/21VLjTi1B04IjJh/Hl8JjeTljgf5BYOpcyeh21PKG5?= =?us-ascii?Q?m82QAAsvuVqBkj0HAKjhpV1Q91RwajirhRCFT/UpjUXUz/9UzhArXplHM2nV?= =?us-ascii?Q?LNAmrDEbpfE1yV1S92eH7u1k+JBfU/W5MYJawLPo/z6rrB2VZgpQEksj8nNz?= =?us-ascii?Q?vtHaU/JCAG5WVkDH61a/J8QsI7oq75nafVZo1UajV2krOJgF7/PhagDN2xxP?= =?us-ascii?Q?GJ23TEzjl3ti4T7xkzUviJvhkAMZYg6Dkg8vQ1ccHzyPKQzGoA5QK8qrMvj4?= =?us-ascii?Q?/gsdoJEWfGlCgh8sqanxiffNk7tFMwqrDeBeQpWs0W+es21xAIH8lOvOsSsD?= =?us-ascii?Q?fDOUBdvpeLtnsf0cZY+2OwXvlbyHrDkkZZneprYw+0AZAAwOZS/hmW/hKuMh?= =?us-ascii?Q?4+N5495W4GXn6N6u4tUgJA2ogfZyzQ8dMIB1VhwTwOJbtFAHXu8TTkrSQGpo?= =?us-ascii?Q?snD+vlSstRvz0sAxkq4wANQL1WtaXrPHrorawCzZl/aBNYJMHLaebi4uzBJ6?= =?us-ascii?Q?EqYkVUcIhsHV6YT+AM6dztCClTU46n2DpmMe8f3ugYUiJx93FygnaU710w/H?= =?us-ascii?Q?3wIbE1AhFKqFNDuYEH5v5dph6rCPkPHSB58Vr1aW2Q+3pb+eU4TmWb3OhjtA?= =?us-ascii?Q?53UDKg5ytmvozbp+BZ8UvregbxldzksAoFmMgu/NPpb4+DSTwTESvpxnVfWW?= =?us-ascii?Q?HutRV0+wMM/yNTiJFnUNfslHFnqTcJVPYslBhLVQKOEtd8+TTx8qyoLJvYzA?= =?us-ascii?Q?Ettme2uGEyM3hlWcMeJH55XQfYKaPqJ4jI0ynZkBIJ9pY13fuibADrGp9q+S?= =?us-ascii?Q?e5YU1Rq/zdSJ+ZZEbaQnLux9nY8bgL1xcwdpHe3r4T5LF61yFQwxefLKHuPg?= =?us-ascii?Q?aMBMA6puaP/+A5ur7ktIjoaSKO6HqqnM6MOPJCXwvqELm8u1FuGZgo6ZIiNq?= =?us-ascii?Q?CV0vl1XxCtaLY1HQgPXECzoIf6XAWW85CRBErbGf3MgUlpJpQixAcCrvOVx4?= =?us-ascii?Q?6zy4ZzDYHHUcWwm021+N4jgfTIwmzdOWixfy5w+A1b8IpEN1zZeOCe5FqfOB?= =?us-ascii?Q?zkhstKTFFol+n84bl2A0L10ry8KOsuewlS7aV6NRuJWoaCC05xQqPslCLwvF?= =?us-ascii?Q?IIo3ggYzCWrDyKeUYWQjBAniaf0zlv9f7elcyVDOcLIftDyKYzn9M0EZP9DA?= =?us-ascii?Q?TVtcKUohRXg9KFVTnPdADVia0mj8ws9QcwS69/PYPisxfL/vbiGVoZKSTlZU?= =?us-ascii?Q?ni0/5kjRuLxZqEnOrDNcX8Km64asXb76MmhJ/imC0yz7lFa6pJCpEu7ZtDTC?= =?us-ascii?Q?czk8UAo9F6tmae7rB5W6GKpYAxNpl08SozmrZ57UBR2hM15oaqlFhLGEkFwW?= =?us-ascii?Q?Xs4d7HjDz/zZvk9Z/eQ5qVnyxhqHzS036xD0EYOa?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 939f968a-b589-4854-2b87-08da90d78847 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:47:40.6486 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7DUF73AG/Y9P/XHw0GSfrLdc6rBLfLjx7MHZG3jgPm+iMkLqZCKhzu4g78TPUNym X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5331 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220907_064746_224229_3B78B7EF X-CRM114-Status: GOOD ( 16.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, marcan@marcan.st, mjrosato@linux.ibm.com, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, will@kernel.org, alyssa@rosenzweig.io, jean-philippe@linaro.org, kvm@vger.kernel.org, zhang.lyra@gmail.com, jon@solid-run.com, jonathanh@nvidia.com, iommu@lists.linux.dev, Nicolin Chen , yangyingliang@huawei.com, orsonzhai@gmail.com, gerald.schaefer@linux.ibm.com, kevin.tian@intel.com, sven@svenpeter.dev, linux-arm-msm@vger.kernel.org, christophe.jaillet@wanadoo.fr, baolin.wang@linux.alibaba.com, thunder.leizhen@huawei.com, linux-tegra@vger.kernel.org, tglx@linutronix.de, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, dwmw2@infradead.org, cohuck@redhat.com, alex.williamson@redhat.com, shameerali.kolothum.thodi@huawei.com, robdclark@gmail.com, asahi@lists.linux.dev, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, baolu.lu@linux.intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 07, 2022 at 02:41:54PM +0200, Joerg Roedel wrote: > On Mon, Aug 15, 2022 at 11:14:33AM -0700, Nicolin Chen wrote: > > Provide a dedicated errno from the IOMMU driver during attach that the > > reason attached failed is because of domain incompatability. EMEDIUMTYPE > > is chosen because it is never used within the iommu subsystem today and > > evokes a sense that the 'medium' aka the domain is incompatible. > > I am not a fan of re-using EMEDIUMTYPE or any other special value. What > is needed here in EINVAL, but with a way to tell the caller which of the > function parameters is actually invalid. Using errnos to indicate the nature of failure is a well established unix practice, it is why we have hundreds of error codes and don't just return -EINVAL for everything. What don't you like about it? Would you be happier if we wrote it like #define IOMMU_EINCOMPATIBLE_DEVICE xx Which tells "which of the function parameters is actually invalid" ? > For that I prefer adding an additional pointer parameter to the attach > functions in which the reason for the failure can be communicated up the > chain. That sounds like OS/2 :\ Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel