From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org
Subject: Re: [arm:ktext 16/19] arch/arm64/mm/ktext.c:96:17: error: implicit declaration of function 'clean_dcache_range_nopatch'
Date: Wed, 7 Sep 2022 15:29:39 +0100 [thread overview]
Message-ID: <Yxiq0xwjQDCn8fH6@shell.armlinux.org.uk> (raw)
In-Reply-To: <YxipLuybhzCZ7XbT@arm.com>
On Wed, Sep 07, 2022 at 03:22:38PM +0100, Catalin Marinas wrote:
> Hi Russell,
>
> Sorry, holidays and lots of emails to go through.
Will mentioned you were away.
> On Fri, Aug 12, 2022 at 12:46:55PM +0100, Russell King wrote:
> > What do you think would be the best way to fix the issue with
> > clean_dcache_range_nopatch() in this patch set? I see two possible
> > solutions to it:
> >
> > 1) duplicate clean_dcache_range_nopatch() in arch/arm64/mm/ktext.c
> > 2) make clean_dcache_range_nopatch() globally visible so ktext.c
> > can call it.
> >
> > Neither of these feels like a great solution.
> >
> > I've thought about moving the code into arch/arm64/kernel/alternative.c
> > but that means making other stuff globally visible instead. So it seems
> > to be a case of what is the lesser of all the evils.
> >
> > The patch can be viewed at:
> > http://git.armlinux.org.uk/cgit/linux-arm.git/commit/?h=ktext&id=b8557d9117093ebe17320d36dadd47fc742820c9
>
> I'd prefer the second option above. It's easier to maintain in case we
> have to change this function (errata etc.)
>
> You could also pass a function pointer to ktext_replication_* to call
> for cache maintenance but I'm not sure it's worth it.
Thanks - (2) is what I ended up doing, so that's great! I'll post the
patches in the next day or so as the series needs to be rebased on to
something more recent than 5.19!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-09-07 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 20:50 [arm:ktext 16/19] arch/arm64/mm/ktext.c:96:17: error: implicit declaration of function 'clean_dcache_range_nopatch' kernel test robot
2022-08-12 11:46 ` Russell King (Oracle)
2022-09-07 14:22 ` Catalin Marinas
2022-09-07 14:29 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxiq0xwjQDCn8fH6@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).