From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53D76C54EE9 for ; Wed, 7 Sep 2022 14:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D8YhdD4B+tK4zYzomrVANqM6UnTI5t65Oa8PRtGrarc=; b=A0g3tID8vTNCmC 92Cmgj2DkK2+V/DvZkzqOcgVqqO+vEeCnSGNSJ4H6/fGRCaylCzhmTbIQi+r43O2E+WLEaG6gTYgE M0SCQRoxFyZv6oSu8T6TAsAkSHg9Bl2EaTySm+SluK+X3+j/tQ4cbNhjswh0p3ccJuEkq2b6jnoRN dgKs8R2YWUp1i9BYrazP61gM8sZy029vES2FNs7SYoQCjHVnuDfLez9lpTvVJpZ82n5x72PLSsCT4 eb4ddNpkF8t7FrUO+a9LvAhjyC89Cmh6+8as1pukz91PVXgAMeJtE2sYojb3MFFCJ8M8wbBoeQRvl O/9ZBxlJOP+5FnVaUAcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVw6x-006vTw-Kd; Wed, 07 Sep 2022 14:33:04 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVw3k-006tfn-TV for linux-arm-kernel@lists.infradead.org; Wed, 07 Sep 2022 14:29:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EjekC5znm7z3dln5rkI1GMG/bz79SHKF+9TXcFXwCoA=; b=a1oN0fCLPmVgkCmxSD4KZUCfzD 8WXVsvmxmdAmYbJWUSQHzBMJHvVDkNQ6kzb4kU9EQgV3ZMIeBmMNcXb342otIU1/T6uyXTrhD4152 cp3n1bE7OKtrR9mknzSwgr6sCaRVzJ1hFdmzC4RYu84xMnueW1tIBZX6P0N0n7W9Be18oLNb1DQGG os0bP+z12V1DNlv52+vvQN1kB0f7DSulQgeux9u5RLDFIsc9GSxBRy8mwPfwYKbC44wRqt/np/Guo 79ayaKSJX/PWPyAjgo8oAzdrGqIKs39ZaBoT4w6JlWhxcwUexwynPaOUHWyHU0GckzE51bO7aG+r/ 9JK+VKgQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34186) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oVw3g-0005Vw-MT; Wed, 07 Sep 2022 15:29:40 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oVw3f-0001An-J0; Wed, 07 Sep 2022 15:29:39 +0100 Date: Wed, 7 Sep 2022 15:29:39 +0100 From: "Russell King (Oracle)" To: Catalin Marinas Cc: Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [arm:ktext 16/19] arch/arm64/mm/ktext.c:96:17: error: implicit declaration of function 'clean_dcache_range_nopatch' Message-ID: References: <202208120434.0ibxs7Y5-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220907_072944_996648_1E941A71 X-CRM114-Status: GOOD ( 25.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 07, 2022 at 03:22:38PM +0100, Catalin Marinas wrote: > Hi Russell, > > Sorry, holidays and lots of emails to go through. Will mentioned you were away. > On Fri, Aug 12, 2022 at 12:46:55PM +0100, Russell King wrote: > > What do you think would be the best way to fix the issue with > > clean_dcache_range_nopatch() in this patch set? I see two possible > > solutions to it: > > > > 1) duplicate clean_dcache_range_nopatch() in arch/arm64/mm/ktext.c > > 2) make clean_dcache_range_nopatch() globally visible so ktext.c > > can call it. > > > > Neither of these feels like a great solution. > > > > I've thought about moving the code into arch/arm64/kernel/alternative.c > > but that means making other stuff globally visible instead. So it seems > > to be a case of what is the lesser of all the evils. > > > > The patch can be viewed at: > > http://git.armlinux.org.uk/cgit/linux-arm.git/commit/?h=ktext&id=b8557d9117093ebe17320d36dadd47fc742820c9 > > I'd prefer the second option above. It's easier to maintain in case we > have to change this function (errata etc.) > > You could also pass a function pointer to ktext_replication_* to call > for cache maintenance but I'm not sure it's worth it. Thanks - (2) is what I ended up doing, so that's great! I'll post the patches in the next day or so as the series needs to be rebased on to something more recent than 5.19! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel