Re: [PATCH v5 net-next 2/6] net: switchdev: add support for offloading of fdb locked flag

netdev
2022-08-28T11:28:31Z

On 2022-08-27 17:46, Ido Schimmel wrote:
> On Fri, Aug 26, 2022 at 01:45:34PM +0200, Hans Schultz wrote:
>> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
>> index 7dcdc97c0bc3..437945179373 100644
>> --- a/include/net/switchdev.h
>> +++ b/include/net/switchdev.h
>> @@ -247,7 +247,10 @@ struct switchdev_notifier_fdb_info {
>> const unsigned char *addr;
>> u16 vid;
>> u8 added_by_user:1,
>> + sticky:1,
>
> If mv88e6xxx reports entries with 'is_local=1, locked=1, blackhole=1',
> then the 'sticky' bit can be removed for now (we will need it some day
> to support sticky entries notified from the bridge). This takes care of
> the discrepancy Nik mentioned here:
>
> https://lore.kernel.org/netdev/d1de0337-ae16-7dca-b212-1a4e85129c31@blackwall.org/
>
>> is_local:1,
>> + locked:1,
>> + blackhole:1,
>> offloaded:1;
>> };

Right!