From: Jason Gunthorpe <jgg@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"marcan@marcan.st" <marcan@marcan.st>,
"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"will@kernel.org" <will@kernel.org>,
"alyssa@rosenzweig.io" <alyssa@rosenzweig.io>,
"jean-philippe@linaro.org" <jean-philippe@linaro.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"zhang.lyra@gmail.com" <zhang.lyra@gmail.com>,
Joerg Roedel <joro@8bytes.org>,
"jon@solid-run.com" <jon@solid-run.com>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
Nicolin Chen <nicolinc@nvidia.com>,
"yangyingliang@huawei.com" <yangyingliang@huawei.com>,
"orsonzhai@gmail.com" <orsonzhai@gmail.com>,
"gerald.schaefer@linux.ibm.com" <gerald.schaefer@linux.ibm.com>,
"sven@svenpeter.dev" <sven@svenpeter.dev>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
"baolin.wang@linux.alibaba.com" <baolin.wang@linux.alibaba.com>,
"thunder.leizhen@huawei.com" <thunder.leizhen@huawei.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"robdclark@gmail.com" <robdclark@gmail.com>,
"asahi@lists.linux.dev" <asahi@lists.linux.dev>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
Robin Murphy <robin.murphy@arm.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Subject: Re: [PATCH v6 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group
Date: Thu, 8 Sep 2022 09:08:38 -0300 [thread overview]
Message-ID: <YxnbRq5vaP/OL0ra@nvidia.com> (raw)
In-Reply-To: <BN9PR11MB52763FAD3E7545CC26C0DE908C409@BN9PR11MB5276.namprd11.prod.outlook.com>
On Thu, Sep 08, 2022 at 09:30:57AM +0000, Tian, Kevin wrote:
> > But OK, I'm on board, lets use more common errnos with specific
> > meaning, that can be documented in a comment someplace:
> > ENOMEM - out of memory
> > ENODEV - no domain can attach, device or iommu is messed up
> > EINVAL - the domain is incompatible with the device
> > <others> - Same behavior as ENODEV, use is discouraged.
>
> There are also cases where common kAPIs are called in the attach
> path which may return -EINVAL and random errno, e.g.:
>
> omap_iommu_attach_dev()
> omap_iommu_attach()
> iommu_enable()
> pm_runtime_get_sync()
> __pm_runtime_resume()
> rpm_resume()
> if (dev->power.runtime_error) {
> retval = -EINVAL;
>
> viommu_attach_dev()
> viommu_domain_finalise()
> ida_alloc_range()
> if ((int)min < 0)
> return -ENOSPC;
Yes, this is was also on my mind with choosing an unpopular return
code, it has a higher chance of not coming out of some other kernel
API
> If we think attach_dev is a slow path and having unnecessary retries
> doesn't hurt then -EINVAL sounds a simpler option. We probably can
> just go using -EINVAL as retry indicator in vfio even w/o changing
> iommu drivers at this point. Then improve them to use consistent
> errno gradually and in a separate effort.
Given Joerg's objection I think we will do EINVAL and just live with
the imperfection.
It is not just slow path, but being inaccurate can mean extra domains
are created when they were not needed. But I think we are getting into
sufficiently unlikely territory that issue can be ignored to make
progress.
Jason
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-08 12:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 18:14 [PATCH v6 0/5] Simplify vfio_iommu_type1 attach/detach routine Nicolin Chen
2022-08-15 18:14 ` [PATCH v6 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group Nicolin Chen
2022-09-07 12:41 ` Joerg Roedel
2022-09-07 13:47 ` Jason Gunthorpe
2022-09-07 14:06 ` Joerg Roedel
2022-09-07 17:10 ` Jason Gunthorpe
2022-09-08 13:28 ` Joerg Roedel
2022-09-08 16:14 ` Jason Gunthorpe
2022-09-09 3:17 ` Nicolin Chen
2022-09-09 5:00 ` Tian, Kevin
2022-09-09 12:07 ` Jason Gunthorpe
2022-09-13 2:22 ` Tian, Kevin
2022-09-13 5:07 ` Nicolin Chen
2022-09-07 14:23 ` Robin Murphy
2022-09-07 17:00 ` Jason Gunthorpe
2022-09-07 19:41 ` Robin Murphy
2022-09-08 0:43 ` Jason Gunthorpe
2022-09-08 9:30 ` Tian, Kevin
2022-09-08 12:08 ` Jason Gunthorpe [this message]
2022-09-10 23:35 ` Nicolin Chen
2022-09-13 2:24 ` Tian, Kevin
2022-09-13 8:36 ` Nicolin Chen
2022-09-08 9:54 ` Tian, Kevin
2022-09-08 10:25 ` Robin Murphy
2022-08-15 18:14 ` [PATCH v6 2/5] vfio/iommu_type1: Prefer to reuse domains vs match enforced cache coherency Nicolin Chen
2022-08-15 18:14 ` [PATCH v6 3/5] vfio/iommu_type1: Remove the domain->ops comparison Nicolin Chen
2022-08-15 18:14 ` [PATCH v6 4/5] vfio/iommu_type1: Clean up update_dirty_scope in detach_group() Nicolin Chen
2022-08-15 18:14 ` [PATCH v6 5/5] vfio/iommu_type1: Simplify group attachment Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxnbRq5vaP/OL0ra@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=baolin.wang@linux.alibaba.com \
--cc=baolu.lu@linux.intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cohuck@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=jon@solid-run.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=orsonzhai@gmail.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=sven@svenpeter.dev \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=thunder.leizhen@huawei.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=yangyingliang@huawei.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).