From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D369CC54EE9 for ; Fri, 9 Sep 2022 03:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GuFEjttnqQ//b6lR1k/LJxM+9W/tlkzfRNZfl3WCitk=; b=LVN1ovQs9iU4aU c1Ec1rToNmdUYW562UrZGF+2U/6u9JDG4cFlMm2Mp7SX21AGzljuUWZ/d+IYH5Eo6zOxZmVp3eKf9 B5yvWOiMeTgge0n6c0+Cpi6iyNb7uiLF3gUZld9bHytBX7MwJZQ363+l7nZ8CPC7vcPnxxLp9mWhz 9OM8cTvb1Ty7aU/w/qs2A45CfZcxne3EM9RZ+38apmhlGNgTLpNMizzoq4BGI2K7BfEHIs95lJ1FY 0+yyCVu21yVfB2Db2JBgN5J+wbzsnfZzPRZhXwbQp7XaAeNvI00bJv8YKGG6oLYRY0O1yJ/y5YGVq jCdVjMpdvhMedy4a4LOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWUWP-00Bd8S-7y; Fri, 09 Sep 2022 03:17:37 +0000 Received: from mail-dm6nam10on2082.outbound.protection.outlook.com ([40.107.93.82] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWUWM-00Bd4x-Dv for linux-arm-kernel@lists.infradead.org; Fri, 09 Sep 2022 03:17:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YcVaHVn+DMuS+GQpcw0YEoKQnB/sJkf8kTrJ9ebXL2KNF1hLlRK1CkiJwBonfY6gAMG8HI+WffH5KxMbkWYLTdA8oo5QBbmV0YRm1kgW7kF5bSPyWwifsetin6xfyyAON7jVome8VjbM/hNfVzkhdIhTNp1NBNg/3bgJFSjGF0mhC4U8inHbbgre8WtpBk0wwDR3vQC0MP3GEhbKEbbPKLMspoZBGmGkrT6cqTtbUMKmtSkoEbbNEYEraB39ZDm2EEWoghi5wSfovVn/G8H6i+rucNL7PdX6F+SXrvfOD+fCVJaqJxgd/8wIxUJXnJLlPM8vqtSENupN0L2Pf7SW0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cWi81IMdZwicw2LJEyRXdtA41SF9WN6zcwiHFsu0pD8=; b=Xmgo0zR1WbCVhvU4pgAA52g93AAvbuxK3Wr61VFF0wyAP9LriCrXCtuMYLDCl6++Lg5DLkV39U5X+m9kz3oD8EHJKcjTcwBz2vwh60+csf1x0QQwamJ+GKVrRGXfzNyTgH+QnEByzqbsjU6Mo0gsoWkf5TDK19YTKiwK6CUdtf/JssqpKyZrZXgrdprA8nrVPFzSw6io7J1lsmDw/xWTLFUvT0jY2DQsUuvNGs4QUduEHbLEh7meJ4sZqORa+9D9PP1eC57okFGx+G1TfJ57Yp6QZeifsRsBz7oQ+1zPfToZfXCWhAgc8SSdbcRJn3w7P5BLVCF5YsZRW0cPC+1TmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.234) smtp.rcpttodomain=svenpeter.dev smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cWi81IMdZwicw2LJEyRXdtA41SF9WN6zcwiHFsu0pD8=; b=WGBGQ4+X6CBSSNxM4LEt46hpfdBPOnMr1IV/+HGwFUHY/uWJMNtRPYtmEuVWHuHo/xNhzUY5DiBASlibrIchBoj/jtKexYCpicpQjhHocIL35NFwwXIVpJVPCa1wxBLE9jtvVZpc+04BUd/pipKfU6wQtB/euUVBH0eGfOI+0WUs377ZPxhwxk9jK2C0miM7pkTlZRGS1JVBesDN/8PrAetkmsp7PP1fXPRpVtfSBWIc9Ck6Oec1yxMOOrv/3eSiYv/Be72ZsjzHdPC1SyR2gyUW2rPz+e1UDeMzg0QqMu1ADuGZm0rstzOqRwuvcO9xmrHSOMKYQcqYVLXVVolOCw== Received: from MW4PR03CA0032.namprd03.prod.outlook.com (2603:10b6:303:8e::7) by SJ1PR12MB6265.namprd12.prod.outlook.com (2603:10b6:a03:458::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Fri, 9 Sep 2022 03:17:28 +0000 Received: from CO1NAM11FT101.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8e:cafe::f9) by MW4PR03CA0032.outlook.office365.com (2603:10b6:303:8e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14 via Frontend Transport; Fri, 9 Sep 2022 03:17:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.234) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.234 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.234; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.234) by CO1NAM11FT101.mail.protection.outlook.com (10.13.175.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5612.13 via Frontend Transport; Fri, 9 Sep 2022 03:17:28 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by DRHQMAIL101.nvidia.com (10.27.9.10) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Fri, 9 Sep 2022 03:17:27 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Thu, 8 Sep 2022 20:17:27 -0700 Received: from Asurada-Nvidia (10.127.8.10) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29 via Frontend Transport; Thu, 8 Sep 2022 20:17:24 -0700 Date: Thu, 8 Sep 2022 20:17:23 -0700 From: Nicolin Chen To: Joerg Roedel , Jason Gunthorpe Subject: Re: [PATCH v6 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group Message-ID: References: <20220815181437.28127-1-nicolinc@nvidia.com> <20220815181437.28127-2-nicolinc@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT101:EE_|SJ1PR12MB6265:EE_ X-MS-Office365-Filtering-Correlation-Id: c011eca3-74e5-48d5-ea39-08da9211d333 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sHXN/KKHM1XqDv2azSzqcajRY297pTWIwlt21Oi+lOQCQiDUPNdS563UqSg4J16qQzfA/PAU3YuWHfSFROcJdbqM8kkCdpJgNqu9tNKc2Kb+OBRYBujk94qzcEcpRxjYdjUPVXGnnlsA/6lj7TD9TjlOZd9bOjRYQ9yi5qsrL3pyFBe5YI/i+MKbIepvsyh7tXba7rkBcNJGfVmZlwIBDyv4n4MQmfBnAPLJuPL1a66AMQpMgS+T+pzkZhi9R1prURmGLTAjEue/mF9f4t3BWI4KapBTjNxE3l+7uoBwaWl5UQfJh6fFLi5b624ZK+darjRg4fEgKeB1tATIbunOVdlUqtfkG3RNSf3NGqEsiX8bBTXGjhkeE/6Hpgo2U4u6NSxeRR6A1UZUivPgO+iv9WEZaxwXDOELG552xAbOHhft+NEJxRq7jGnPJgebz6w5zRwHOLBc8rhjpARThNLBcsJQ1XKKp1TlxAIaqvp/1ClRNX/uKsKwGVgVyB0XvuVgfTSAfcepAYNcfcwdN5WGCs475qGVZxDs1wL+iG2IObD06i0WpTOopysA9GLo2Vb2HgED2D8kz5SDTFz0pIS7xFpbNnx3+gS8sQxm+Tj/9urE7dqQO1hoNI2M4iAcVn+c/xZ5JzyPUOtCkx7ribuE/f+tpYopVhEav2VP+IpFO/fCpvHuDGHRJJBYJ1KU1oVQlUfQg345Hh7zwLxITDtEd+zjOr0BwamW3f7yZWju4tBE470JvzWdHVIVbc7fZkz9x4KoCvEeTi7d5FwCSkHJb7kTxndx8obj0bcR9EXB1P28p/nS7QmIHNhro8tR20+9RtaSdOuvc0Bxy5S09Y8eCQ== X-Forefront-Antispam-Report: CIP:12.22.5.234;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:InfoNoRecords;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(396003)(376002)(136003)(46966006)(40470700004)(36840700001)(40480700001)(336012)(81166007)(426003)(356005)(47076005)(26005)(8676002)(36860700001)(82310400005)(33716001)(478600001)(70586007)(82740400003)(40460700003)(70206006)(86362001)(55016003)(4326008)(41300700001)(6636002)(8936002)(110136005)(54906003)(316002)(5660300002)(186003)(7406005)(9686003)(2906002)(7416002)(67856001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 03:17:28.0590 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c011eca3-74e5-48d5-ea39-08da9211d333 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[12.22.5.234];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT101.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6265 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220908_201734_523075_1AC065E1 X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, marcan@marcan.st, mjrosato@linux.ibm.com, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, will@kernel.org, alyssa@rosenzweig.io, jean-philippe@linaro.org, kvm@vger.kernel.org, zhang.lyra@gmail.com, jon@solid-run.com, jonathanh@nvidia.com, iommu@lists.linux.dev, yangyingliang@huawei.com, orsonzhai@gmail.com, gerald.schaefer@linux.ibm.com, kevin.tian@intel.com, sven@svenpeter.dev, linux-arm-msm@vger.kernel.org, alex.williamson@redhat.com, christophe.jaillet@wanadoo.fr, baolin.wang@linux.alibaba.com, thunder.leizhen@huawei.com, linux-tegra@vger.kernel.org, tglx@linutronix.de, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, dwmw2@infradead.org, cohuck@redhat.com, shameerali.kolothum.thodi@huawei.com, robdclark@gmail.com, asahi@lists.linux.dev, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, baolu.lu@linux.intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 08, 2022 at 01:14:42PM -0300, Jason Gunthorpe wrote: > > I am wondering if this can be solved by better defining what the return > > codes mean and adjust the call-back functions to match the definition. > > Something like: > > > > -ENODEV : Device not mapped my an IOMMU > > -EBUSY : Device attached and domain can not be changed > > -EINVAL : Device and domain are incompatible > > ... > > Yes, this was gone over in a side thread the pros/cons, so lets do > it. Nicolin will come with something along these lines. I have started this effort by combining this list and the one from the side thread: @@ -266,6 +266,13 @@ struct iommu_ops { /** * struct iommu_domain_ops - domain specific operations * @attach_dev: attach an iommu domain to a device + * Rules of its return errno: + * ENOMEM - Out of memory + * EINVAL - Device and domain are incompatible + * EBUSY - Device is attached to a domain and cannot be changed + * ENODEV - Device or domain is messed up: device is not mapped + * to an IOMMU, no domain can attach, and etc. + * - Same behavior as ENODEV, use is discouraged * @detach_dev: detach an iommu domain from a device * @map: map a physically contiguous memory region to an iommu domain * @map_pages: map a physically contiguous set of pages of the same size to I am now going through every single return value of ->attach_dev to make sure the list above applies. And I will also incorporate things like Robin's comments at the AMD IOMMU driver. And if the change occurs to be bigger, I guess that separating it to be an IOMMU series from this VFIO one might be better. Thanks Nic _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel