From: Ricardo Koller <ricarkol@google.com>
To: Reiji Watanabe <reijiw@google.com>
Cc: Marc Zyngier <maz@kernel.org>,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Andrew Jones <andrew.jones@linux.dev>,
Oliver Upton <oupton@google.com>,
Jing Zhang <jingzhangos@google.com>,
Raghavendra Rao Anata <rananta@google.com>
Subject: Re: [PATCH 2/9] KVM: arm64: selftests: Add write_dbg{b,w}{c,v}r helpers in debug-exceptions
Date: Fri, 9 Sep 2022 12:40:52 -0700 [thread overview]
Message-ID: <YxuWxMPNYKuYcREX@google.com> (raw)
In-Reply-To: <20220825050846.3418868-3-reijiw@google.com>
On Wed, Aug 24, 2022 at 10:08:39PM -0700, Reiji Watanabe wrote:
> Introduce helpers in the debug-exceptions test to write to
> dbg{b,w}{c,v}r registers. Those helpers will be useful for
> test cases that will be added to the test in subsequent patches.
>
Reviewed-by: Ricardo Koller <ricarkol@google.com>
> Signed-off-by: Reiji Watanabe <reijiw@google.com>
> ---
> .../selftests/kvm/aarch64/debug-exceptions.c | 72 +++++++++++++++++--
> 1 file changed, 68 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c
> index 2ee35cf9801e..51047e6b8db3 100644
> --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c
> +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c
> @@ -28,6 +28,69 @@ static volatile uint64_t svc_addr;
> static volatile uint64_t ss_addr[4], ss_idx;
> #define PC(v) ((uint64_t)&(v))
>
> +#define GEN_DEBUG_WRITE_REG(reg_name) \
> +static void write_##reg_name(int num, uint64_t val) \
> +{ \
> + switch (num) { \
> + case 0: \
> + write_sysreg(val, reg_name##0_el1); \
> + break; \
> + case 1: \
> + write_sysreg(val, reg_name##1_el1); \
> + break; \
> + case 2: \
> + write_sysreg(val, reg_name##2_el1); \
> + break; \
> + case 3: \
> + write_sysreg(val, reg_name##3_el1); \
> + break; \
> + case 4: \
> + write_sysreg(val, reg_name##4_el1); \
> + break; \
> + case 5: \
> + write_sysreg(val, reg_name##5_el1); \
> + break; \
> + case 6: \
> + write_sysreg(val, reg_name##6_el1); \
> + break; \
> + case 7: \
> + write_sysreg(val, reg_name##7_el1); \
> + break; \
> + case 8: \
> + write_sysreg(val, reg_name##8_el1); \
> + break; \
> + case 9: \
> + write_sysreg(val, reg_name##9_el1); \
> + break; \
> + case 10: \
> + write_sysreg(val, reg_name##10_el1); \
> + break; \
> + case 11: \
> + write_sysreg(val, reg_name##11_el1); \
> + break; \
> + case 12: \
> + write_sysreg(val, reg_name##12_el1); \
> + break; \
> + case 13: \
> + write_sysreg(val, reg_name##13_el1); \
> + break; \
> + case 14: \
> + write_sysreg(val, reg_name##14_el1); \
> + break; \
> + case 15: \
> + write_sysreg(val, reg_name##15_el1); \
> + break; \
> + default: \
> + GUEST_ASSERT(0); \
> + } \
> +}
> +
> +/* Define write_dbgbcr()/write_dbgbvr()/write_dbgwcr()/write_dbgwvr() */
> +GEN_DEBUG_WRITE_REG(dbgbcr)
> +GEN_DEBUG_WRITE_REG(dbgbvr)
> +GEN_DEBUG_WRITE_REG(dbgwcr)
> +GEN_DEBUG_WRITE_REG(dbgwvr)
> +
> static void reset_debug_state(void)
> {
> asm volatile("msr daifset, #8");
> @@ -59,8 +122,9 @@ static void install_wp(uint64_t addr)
> uint32_t mdscr;
>
> wcr = DBGWCR_LEN8 | DBGWCR_RD | DBGWCR_WR | DBGWCR_EL1 | DBGWCR_E;
> - write_sysreg(wcr, dbgwcr0_el1);
> - write_sysreg(addr, dbgwvr0_el1);
> + write_dbgwcr(0, wcr);
> + write_dbgwvr(0, addr);
> +
> isb();
>
> asm volatile("msr daifclr, #8");
> @@ -76,8 +140,8 @@ static void install_hw_bp(uint64_t addr)
> uint32_t mdscr;
>
> bcr = DBGBCR_LEN8 | DBGBCR_EXEC | DBGBCR_EL1 | DBGBCR_E;
> - write_sysreg(bcr, dbgbcr0_el1);
> - write_sysreg(addr, dbgbvr0_el1);
> + write_dbgbcr(0, bcr);
> + write_dbgbvr(0, addr);
> isb();
>
> asm volatile("msr daifclr, #8");
> --
> 2.37.1.595.g718a3a8f04-goog
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-09 19:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 5:08 [PATCH 0/9] KVM: arm64: selftests: Test linked {break,watch}points Reiji Watanabe
2022-08-25 5:08 ` [PATCH 1/9] KVM: arm64: selftests: Add helpers to extract a field of an ID register Reiji Watanabe
2022-08-25 16:48 ` Oliver Upton
2022-08-25 16:52 ` Ricardo Koller
2022-08-25 16:58 ` Oliver Upton
2022-08-26 0:50 ` Reiji Watanabe
2022-08-25 5:08 ` [PATCH 2/9] KVM: arm64: selftests: Add write_dbg{b,w}{c,v}r helpers in debug-exceptions Reiji Watanabe
2022-09-09 19:40 ` Ricardo Koller [this message]
2022-08-25 5:08 ` [PATCH 3/9] KVM: arm64: selftests: Remove the hard-coded {b,w}pn#0 from debug-exceptions Reiji Watanabe
2022-08-25 16:55 ` Oliver Upton
2022-08-26 0:53 ` Reiji Watanabe
2022-09-09 19:46 ` Ricardo Koller
2022-09-10 4:15 ` Reiji Watanabe
2022-08-25 5:08 ` [PATCH 4/9] KVM: arm64: selftests: Add helpers to enable debug exceptions Reiji Watanabe
2022-08-25 17:21 ` Oliver Upton
2022-08-26 0:55 ` Reiji Watanabe
2022-09-09 19:57 ` Ricardo Koller
2022-08-25 5:08 ` [PATCH 5/9] KVM: arm64: selftests: Have debug_version() use cpuid_get_ufield() helper Reiji Watanabe
2022-08-25 17:29 ` Oliver Upton
2022-08-26 0:59 ` Reiji Watanabe
2022-08-25 5:08 ` [PATCH 6/9] KVM: arm64: selftests: Change debug_version() to take ID_AA64DFR0_EL1 Reiji Watanabe
2022-08-25 5:08 ` [PATCH 7/9] KVM: arm64: selftests: Add a test case for a linked breakpoint Reiji Watanabe
2022-08-26 1:29 ` Reiji Watanabe
2022-09-09 20:18 ` Ricardo Koller
2022-09-09 20:26 ` Ricardo Koller
2022-09-10 5:22 ` Reiji Watanabe
2022-09-09 21:01 ` Ricardo Koller
2022-09-10 5:19 ` Reiji Watanabe
2022-08-25 5:08 ` [PATCH 8/9] KVM: arm64: selftests: Add a test case for a linked watchpoint Reiji Watanabe
2022-08-25 5:08 ` [PATCH 9/9] KVM: arm64: selftests: Test with every breakpoint/watchpoint Reiji Watanabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxuWxMPNYKuYcREX@google.com \
--to=ricarkol@google.com \
--cc=alexandru.elisei@arm.com \
--cc=andrew.jones@linux.dev \
--cc=james.morse@arm.com \
--cc=jingzhangos@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=rananta@google.com \
--cc=reijiw@google.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).