From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08460ECAAD3 for ; Fri, 9 Sep 2022 19:58:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tIqRLiSM0GmZxnloMT4mrjLKnZubdZY7RtXZFwUoRDE=; b=jNOn21YcAQaFLn IHGtDXGe+gemwe4xUILaIxGCG/Zgl+OF5nfghY8VyM6PvoBhZRnef9sx4K664IF4ARZngAv7s20PL 5cWXPm4i86R5ZKXtaEFOQvFVcChYFUmyCm69b+Ij3ItWbvvN21/qDsPLROU6Q1DmeNS1t/zJr0oAv 6WTSG/W7O5cIUVt7zabuWM9F/S17sRjXqPdcNC0Cyx2lr5pkn7yai6NELbGknykwxm3s4e1eV596R +88s8cNrJXwKoynjIcTUpTP6R8HggF/I5sq9/1bmZ3++ScUst5hWf73GuDY7kqZe+kB/kww349EI7 GUkg6Q3jSF2xxvnIl8QQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWk7v-002HPA-MC; Fri, 09 Sep 2022 19:57:23 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWk7s-002H9P-23 for linux-arm-kernel@lists.infradead.org; Fri, 09 Sep 2022 19:57:21 +0000 Received: by mail-pl1-x631.google.com with SMTP id u22so2726596plq.12 for ; Fri, 09 Sep 2022 12:57:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=Ix+zHu63uexJwygRlsHzmVxxGE2dqts71wJzPIEl4nM=; b=s3KGT+5stdiJg6ABS08VG/cuaUdFpcYRsjAtE0XUHTJ2k0VaiPA6MoGcOqQzAMBKQ5 g76yDGGNwKZwynN1NZv3i4AiFb4LC4FBH+O88gO53Sw8OAobYXXdc1XWZcFuhHwXGHNT sPrdsFYYJSPQ7UOGjPhzy53NLHd9TAKri8US/CzLBtaqTMDr9/MPYcAkNWgSwmDZUQhA +qBDiBBDao6/P5LSqLNw/NEEJsb+6YZWBrBnPPSfVgNutZ7WZuz8iyuIepnoISqJ4lMC 58DGydl2/5e/O/5o7/1Nho6fNza7IDKHbiob7N9vDffb3r3lHf/xHmM09asG4LVKlGv0 MOPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=Ix+zHu63uexJwygRlsHzmVxxGE2dqts71wJzPIEl4nM=; b=cIXbqTe9KdTjqqWzJl8B5wwtrydu3RJrB745kDIjDwT0uO7yRWBtSvUMxV2aoRunSU Cq4SgRIJeFugamabFldCxa7mFywzWz+5HYt1WIslsdeQdQ6hSVB5bb7hY6kaowsBxVdw RNpZB2LnnIUtnlCcZPHCS09+TbWkZ/+6KiboUCYtllaBAq/qSb6qjClELWP1b0ZWkoUJ Qg1iun7I3+FtZe3tn298zCq/1DEpJtQJHkW4DaXKxDbxlmbbAZCbNLogMTqecNqdb+5x 7NK32g/1PxC2MX7AFWdXWVjKD+APE8+okVBmxRdNqOb82zSAKKi0JXP0J6jwOAGyu+aP Zudg== X-Gm-Message-State: ACgBeo2g6+Pwx3b3O254T6buI4m3xGYoFOkKVBscrIvOvAxxeEjgxgsh dNZ9iPD4/3mzbEuc1mMbkmjwmQ== X-Google-Smtp-Source: AA6agR5iABvqonzUsPwhF2ANtZ3gF54funoMeqvKsSUZtabxsI64h5+aJQDpiixm2ch7NwlmHH/+sA== X-Received: by 2002:a17:90b:164f:b0:1f5:4ced:ed81 with SMTP id il15-20020a17090b164f00b001f54ceded81mr11101733pjb.122.1662753438095; Fri, 09 Sep 2022 12:57:18 -0700 (PDT) Received: from google.com (220.181.82.34.bc.googleusercontent.com. [34.82.181.220]) by smtp.gmail.com with ESMTPSA id b9-20020a170902d40900b0016bedcced2fsm890830ple.35.2022.09.09.12.57.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Sep 2022 12:57:17 -0700 (PDT) Date: Fri, 9 Sep 2022 12:57:13 -0700 From: Ricardo Koller To: Oliver Upton Cc: Reiji Watanabe , kvm@vger.kernel.org, Marc Zyngier , Andrew Jones , Paolo Bonzini , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/9] KVM: arm64: selftests: Add helpers to enable debug exceptions Message-ID: References: <20220825050846.3418868-1-reijiw@google.com> <20220825050846.3418868-5-reijiw@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220909_125720_183872_B109F853 X-CRM114-Status: GOOD ( 17.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 25, 2022 at 10:21:49AM -0700, Oliver Upton wrote: > On Wed, Aug 24, 2022 at 10:08:41PM -0700, Reiji Watanabe wrote: > > Add helpers to enable breakpoint and watchpoint exceptions. > > > > Signed-off-by: Reiji Watanabe > > --- > > .../selftests/kvm/aarch64/debug-exceptions.c | 25 ++++++++++--------- > > 1 file changed, 13 insertions(+), 12 deletions(-) > > > > diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > > index 183ee16acb7d..713c7240b680 100644 > > --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > > +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > > @@ -128,10 +128,20 @@ static void enable_os_lock(void) > > GUEST_ASSERT(read_sysreg(oslsr_el1) & 2); > > } > > > > +static void enable_debug_bwp_exception(void) > > uber-nit: enable_monitor_debug_exceptions() > > (more closely matches the definition of MDSCR_EL1.MDE) oh, didn't know the MDE was for monitor debug exc. Anyway: Reviewed-by: Ricardo Koller > > With that: > > Reviewed-by: Oliver Upton > > -- > Thanks, > Oliver > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel