From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 767C6C54EE9 for ; Sun, 25 Sep 2022 04:56:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MiFLR1/Jkzd1MtzO8jdbb9lIGN2uQ5iCCV2fT8aeJlM=; b=uNFHvsAFwbdUAC Y+PMZzwxJErpTjsU/99f0NcCjX6f+9bERIB3uupmFYg8XhBAd7ScQiAwmXgWxzDq5n4inAOuI89sO Feiay0HFfprT7igPatfqi1xkCa+sClQDlEP0kQTCi1FwN+bsuPscBVxDd/kk/7pSIqOP6w9vv2Rwr RXAaxgLwbk/9BjD3B7gSb5D2r6eAQ9+TG/MO2aRAc8hnzgFvsSWA2MEjT5uR3KMbaIOI1qfbLr2ze g9O+8/7cKAqrVi2+4R7CprzqJJPTQLgp89LdU/srgvdTz1imWwGq8OgjhKBF2Hc8e39Lu5iiO0Cep up2YOBLMB4sNXZ+wUZCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocJfI-00B3x9-PO; Sun, 25 Sep 2022 04:54:52 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocJfF-00B3w2-5d for linux-arm-kernel@lists.infradead.org; Sun, 25 Sep 2022 04:54:50 +0000 Received: by mail-pg1-x532.google.com with SMTP id bh13so3799842pgb.4 for ; Sat, 24 Sep 2022 21:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=P2wvlg/sKupDOfwRxPOvn4eTw/F7swZQ2U9FkS+2NIo=; b=BXsf6zUmdcaZUebvDnxObiUlxuwhyNm3xlesVZ8csmewxZiY7KAiGa4wLWoUwSC+/h 5njwxu6yOrSiy6rw60Puxg5JBDuJ5N1RFd1Frvf2aS46SGFjZj2lK9qAE90+1Kg/omz0 UKEdorzCrL1rFiUzFe4qUwC4lKQ+5ZUQwTJ1jkFdVzcFJaIvlKMLA9zAPKKj8q+2+Yp+ M+wG8loz6+YzMmH0SxANXdoHlshJ1r8nWD1AwwXm10AXDGZxeAaV4UxKovV8lkVBJFVe 3iNCLau7UC19kqePwMivdZvyyCOv2mFisfz4WuNebp3siQEiD3l5f2sdDRQuQgf/xeGX gI0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=P2wvlg/sKupDOfwRxPOvn4eTw/F7swZQ2U9FkS+2NIo=; b=upmt92x1+sIe0D98sGMmL7PiU6DeVmAIUu6Wv/jMMtyOObuyNS0Fj09Qv0x2DmF/xH Ez2fKQLQSaaX4CUWlmNC1rd1IGHF+RTZqPkVtDHIelrQpOJNYK05iM7817D3NFLhdnlH UMSAGThgwmG05xUvygANxgftXp96R0fXFAF8XDjU+gtqr5a9mLJQYM0gYSnHnUdbr7VP xKF6HNWUpPrTUyhNCfqU+uavzOtwA6dFvReOnbpmA2lBgBIgkUH8Cj6rCvqxD/vumS26 u1v437hNqsVAV9bsK+rAqfXyhVLzC+g4krxtSU1m+rr6Bx/boutAylweeWul+uDv4exY mgjw== X-Gm-Message-State: ACrzQf1G0jXeLf+/xLovyLGZHlBuv4X3QfXp9Caj5pPDu9rJ3teH5KDM Bm2Q4TTjYdTRseMMw1FxJGo= X-Google-Smtp-Source: AMsMyM5lswvmUzKskZZeIrOUiIw2gZ5mbNkKLRHv9Fewfb/cT0WLpfYNTW2+vyKRuO7/fL9UYc2sXQ== X-Received: by 2002:a65:6cce:0:b0:439:49b5:48b8 with SMTP id g14-20020a656cce000000b0043949b548b8mr14476183pgw.514.1664081687424; Sat, 24 Sep 2022 21:54:47 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:37c:3916:9a45:14cc]) by smtp.gmail.com with ESMTPSA id lw4-20020a17090b180400b001df264610c4sm17189987pjb.0.2022.09.24.21.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Sep 2022 21:54:46 -0700 (PDT) Date: Sat, 24 Sep 2022 21:54:43 -0700 From: Dmitry Torokhov To: Dominik Brodowski Cc: Alexandre Belloni , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Claudiu Beznea Subject: Re: [PATCH] pcmcia: at91_cf: switch to using gpiod API Message-ID: References: <68c63077-848b-45f5-8aca-ed995391f2b6@www.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220924_215449_255006_5761C259 X-CRM114-Status: GOOD ( 42.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 24, 2022 at 04:17:20PM +0200, Dominik Brodowski wrote: > Am Sat, Sep 24, 2022 at 01:42:37PM +0200 schrieb Alexandre Belloni: > > On 24/09/2022 10:33:29+0200, Arnd Bergmann wrote: > > > On Sat, Sep 24, 2022, at 8:04 AM, Dmitry Torokhov wrote: > > > > This patch switches the driver to use newer gpiod API instead of legacy > > > > gpio API. This moves us closer to the goal of stopping exporting > > > > OF-specific APIs of gpiolib. > > > > > > > > While at it, stop using module-global for regmap. > > > > > > > > Signed-off-by: Dmitry Torokhov > > > > > > This looks good to me overall. Three comments: > > > > > > > @@ -63,7 +62,7 @@ struct at91_cf_socket { > > > > > > > > static inline int at91_cf_present(struct at91_cf_socket *cf) > > > > { > > > > - return !gpio_get_value(cf->board->det_pin); > > > > + return gpiod_get_value(cf->board->det_pin); > > > > } > > > > > > a) The change in polarity looks wrong here, I can't really tell > > > from the patch. If this is intentional, maybe explain it in > > > the changelog. With that addressed (either way) Oh, yes, you are right. I at first thought that card detect pin might be active low, was not able to confirm it, but forgot to restore polarity. Anyway, I think this does not matter given Dominik's patch below. > > > > > > Reviewed-by: Arnd Bergmann > > > > > > > > > b) In case you are doing more patches like this one at the moment, > > > note that I'm in the process of removing all unused board files > > > for arch/arm/, which will in turn make a lot of drivers unused. > > > I should be able to provide a branch soon, which can be used to > > > identify drivers that don't have DT support any more and don't > > > have any board files. Rather than converting them to gpio > > > descriptors, we can probably just remove those drivers. > > > > > > c) I'm not sure about the state of the at91_cf driver. Apparently > > > we used to have three drivers for the same hardware (pcmcia, > > > pata and ide), and only the pcmcia driver remained in the tree > > > after drivers/ide/ was removed and pata_at91 did not get converted > > > to DT. I think in the long run we will remove the pcmcia layer, > > > so if you are actually trying to use this hardware, we may want to > > > revive the pata variant and drop this one instead. Nope, I am interested in dropping legacy gpio API, that is all. > > > There is no dts file in tree that actually declares either of them, > > > so chances are that nobody is actually using the CF slot on at91 > > > any more. > > > > > > > I'm pretty sure it is broken since eaa9a21dd14b ("pcmcia: at91_cf: Use > > syscon to configure the MC/smc") as this change has never been tested. > > Well, that's a pretty strong reason to remove this driver. May I get ACKs on > this patch, please? Not sure if this is worth anything, but Acked-by: Dmitry Torokhov Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel