From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0E17C54EE9 for ; Tue, 13 Sep 2022 07:42:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rc9cRquWCSJiq78sTCBy67/XDlBsmE0FrN8894STD58=; b=sZ2uHbhanJEC1t NlgHp20iFwHXavILfr2jkxISRCoTRdOtA1G4Dw/5e8RlsMFN+6MqGoBTSrW8w+i1EDUSYMRekfM3t Ic0w+Lbt7E98Cm+4/WLJJkeWtKzbaxDB0TnUpG68JIM8q7O27YOVKn7iYJuapgheAH14hOKcTwhOq DFn/l67I+aVWNRhO8W8aNagY1XyPEwULgDr9NFgbPKkr9+Fh2Yp47SA5H8jVRYpipP4UafxOmgmTU gZKVV5f8etlud0ivMNNG/pCej23oqorZsJzvpIrAhxoDh5NGa0SqnN8lhFgwHA4eglwIIU5aIg0Aw 8C5mPM248iAlhinhNfcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY0XQ-003gk1-UA; Tue, 13 Sep 2022 07:40:57 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY0Wh-003g9D-IE for linux-arm-kernel@lists.infradead.org; Tue, 13 Sep 2022 07:40:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Fue77bPZdaJAaSOH7eGxgtw/KYIpmA186iUr1AmIias=; b=01hMynooNnszICaf6NYn8Rojxv ScRBfM0qW1BPM379I/PwdJAzT9yFfkpejMs3Rdcxe75i8+6oOnrX6RlROFwayXFSb1iqiP+6vEt4c EwG98+H8EPBByUaGCQ34zQ1NLdxeUuEupLY+brY4s91n6wiwnosd+rMCYDMGuxvjTyAVpUpoOlzar IY3GgCmhkVuEdedgW/K9O0SVL6XbRSZf2B9nOOT/JKYhgtTC9xRqPtWwqH25xbhxpsb2Lo31hSbTR AYLhH/QABbyKih7jDukv9VE387sR5oKzcRTGXYLGvLtV5OmbzKPqsG3u+u6RSx5MNgk0pA/dnA4eL 9HLw/C2g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34284) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oY0WZ-0002ZS-S4; Tue, 13 Sep 2022 08:40:04 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oY0WZ-0000Va-6v; Tue, 13 Sep 2022 08:40:03 +0100 Date: Tue, 13 Sep 2022 08:40:03 +0100 From: "Russell King (Oracle)" To: Tang Bin Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: imx: imx8m-blk-ctrl: Fix wrong check Message-ID: References: <20220913072155.13392-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220913072155.13392-1-tangbin@cmss.chinamobile.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220913_004011_641880_429D3001 X-CRM114-Status: UNSURE ( 9.31 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 13, 2022 at 03:21:55PM +0800, Tang Bin wrote: > In the function imx8m_blk_ctrl_probe(), > dev_pm_domain_attach_by_name() may return NULL in some cases, > so IS_ERR() doesn't meet the requirements. Thus fix it. > > Fixes: 2684ac05a8c4 ("soc: imx: add i.MX8M blk-ctrl driver") > Signed-off-by: Tang Bin Duplicate of a later patch. See comments on later patch for why this is potentially wrong. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel