From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E676C6FA82 for ; Tue, 13 Sep 2022 07:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NEW6sZklNy8aJMFIsnbXtxx3drawQvZwV6+A9NwAH24=; b=kpFAV2fWf3cjmK 5PzFe53wvXBwTQlSeg3x7xhse87SVKR528aLk8c7llXF8N0s6w3c20fzsaqsyg8CrXVQI6zmK1oRO IguSdxyJv4LSf4A7JHjzihuJBM3m3uygGHjcvs7tqxhEFZNQds3sRFwDb+luXUAPgzkh9NBb+mhat +Eg5hb0lzZ2l5ecRi7kLa5uLk2HjW9AkF/Kxgbz6Eahtgrr5tz+DIgOGYn7ORs9fU2n1w3ywAyRBm ZfZElPOrG1ZbInNf6vBjpWwdogXJkRgeCMRgQ2ydkuKh2w86PZ3fAzfaAbkLtQfEDyF55fiFM2SUi pDn5f1DSO2t/9tEELXEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY0Wk-003gBM-65; Tue, 13 Sep 2022 07:40:14 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY0WA-003fpg-KT for linux-arm-kernel@lists.infradead.org; Tue, 13 Sep 2022 07:39:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ti8c823NopLlwRG+ncpb0fxu6N8C0vk3Ny10bJFiLBI=; b=lcyq30Uf8aui/bAWcaBMZR/Wd1 A4N7kf99PfwF7DdjBqL8PWMlQR2HZap98jVwfkTmerZcRZx3+OjQ2GVraaq5EcFD7jtFpz/9bw8mQ p1wqUouhHYRRSLIzxmCY8xlV3+Jz3kmFiMAoyH5Qvrq+u67GOa2apJAMUvc8ojWjistszH+ssHD8b OhYKFjdRsOJbnR6UoUmgLr7b7n3xPbz7aEIG4q9QphCkXDSqFurNa7DW1+UbneUTputdvK0zQrk9a RXUjckN38lprQ07bAATijfl+MIaxug0sfaz9GjxzXS6GzzFYaiEvM5XFtPKgnBUKQtYdg7OBMhZ63 j/IAav5A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34282) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oY0W4-0002ZG-2w; Tue, 13 Sep 2022 08:39:32 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oY0W2-0000VT-Tu; Tue, 13 Sep 2022 08:39:30 +0100 Date: Tue, 13 Sep 2022 08:39:30 +0100 From: "Russell King (Oracle)" To: Tang Bin Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: imx: fix error check in imx8mp_blk_ctrl_probe() Message-ID: References: <20220913073434.7252-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220913073434.7252-1-tangbin@cmss.chinamobile.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220913_003938_794633_CE0C698F X-CRM114-Status: GOOD ( 19.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 13, 2022 at 03:34:34PM +0800, Tang Bin wrote: > In the function imx8mp_blk_ctrl_probe(), > dev_pm_domain_attach_by_name() may return NULL in some cases, > so IS_ERR() doesn't meet the requirements. Thus fix it. > > Fixes: 556f5cf9568a ("soc: imx: add i.MX8MP HSIO blk-ctrl") > Signed-off-by: Tang Bin > --- > drivers/soc/imx/imx8mp-blk-ctrl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c > index ccb30c6cd..ed8557eaf 100644 > --- a/drivers/soc/imx/imx8mp-blk-ctrl.c > +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c > @@ -597,11 +597,11 @@ static int imx8mp_blk_ctrl_probe(struct platform_device *pdev) > > domain->power_dev = > dev_pm_domain_attach_by_name(dev, data->gpc_name); > - if (IS_ERR(domain->power_dev)) { > + if (IS_ERR_OR_NULL(domain->power_dev)) { > dev_err_probe(dev, PTR_ERR(domain->power_dev), > "failed to attach power domain %s\n", > data->gpc_name); > - ret = PTR_ERR(domain->power_dev); > + ret = PTR_ERR(domain->power_dev) ? : -ENODATA; > goto cleanup_pds; > } > dev_set_name(domain->power_dev, "%s", data->name); Checking for NULL in this case is likely a good idea, as if domain->power_dev is NULL, then dev_set_name() will probably oops the kernel. Whether returning -ENODATA and causing a failure, or whether moving on to the next domain is a question that the maintainers of this code need to answer, bearing in mind that NULL here means that the device doesn't need a power domain. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel