From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8A28C6FA82 for ; Tue, 13 Sep 2022 11:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pa7JSpU8EQBsyOif3TBosSlKk5irtzSYc0Kh1vQcQ1s=; b=FIZH1V0dhXNAB1 dmfDZGnwL064a4dbCpEZygLg2koiaVaeAM8FosfduOMZFFmo7QC5A6wkKzo0Og76IJB+Zu/umCAy0 hQoe8xVOLDE/CBPwBTrsvovJ0kkjQFPdY5sxe/fernxpi6vrjF2DUuc5hkEOutK0zXQXlN6TfomIM XEiuYBEnNYjzdZ10j0VZZUnTczV4rDQ+bpoFV5NJLy5KoJ1X71aZ8NBNYiPBwT52kyxavIEtR1wF1 h0CQeOftCnN8Gf+eriOhc54i+0oleIIQDDWqZbCQUft2YsY8tVcNZHF34sM4rTrllMQNUR5oBiN7W rqbZxIeFrrsXGKUSm1KA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY43Z-008Osv-2K; Tue, 13 Sep 2022 11:26:21 +0000 Received: from out0.migadu.com ([94.23.1.103]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY43U-008OcS-S5 for linux-arm-kernel@lists.infradead.org; Tue, 13 Sep 2022 11:26:18 +0000 Date: Tue, 13 Sep 2022 12:26:09 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1663068372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WnJ7iBg3M95g4UxL74wu6Oc05BoA+yNNygAHJybcFs8=; b=Fm3VFtCCfQqW9sjPYoscFhTrIGnCxUXDH/ciu+YRcKAXP7uW5OtpmLVRqTb/DsL4JnzQu2 FR+O/PFlZnJzNslXx0gRpwgtDE2nlnGZKtlh2CZYyCjrepwroB1AvKZM7y2O5TgGxIJJdY Jmi7h0az1ofKpcVpjFCFraMCyBYnJOQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Kunkun Jiang Cc: Mark Rutland , Marc Zyngier , Daniel Lezcano , Thomas Gleixner , wanghaibin.wang@huawei.com, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: arch_timer: Fix the lack of set_next_event* for workaround of Cortex-A73 erratum 858921 Message-ID: References: <20220913104723.332-1-jiangkunkun@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220913104723.332-1-jiangkunkun@huawei.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220913_042617_677157_4EAA2D7E X-CRM114-Status: GOOD ( 11.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 13, 2022 at 06:47:23PM +0800, Kunkun Jiang wrote: > The patch a38b71b0833e moves the programming of the timers from Please check your patch with scripts/checkpatch.pl next time. Use this pattern when referring to a commit in the changelog: commit a38b71b0833e ("clocksource/drivers/arm_arch_timer: Move system register timer programming over to CVAL") moved the programming... > the countdown timer (TVAL) over to the comparator (CVAL). This > makes it necessary to read the counter when setting next event. > However, the workaround of Cortex-A73 erratum 858921 does not > set the corresponding set_next_event_phys and set_next_event_virt. > This patch fixes it. Avoid referring to 'this patch', and just state imperatively what the change does, perhaps: Add the appropriate hooks to apply the erratum mitigation when programming the next timer event. Thanks for catching this! -- Best, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel