From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0AF0C6FA82 for ; Tue, 13 Sep 2022 14:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E+HGskH/Se8oLyhI5YhLyTYF+JlcKNQHjzV82nxIyOM=; b=Z2TwoYYhBcwz5C aN9JQZzOgDYbd3ngJXVfdvwcUwoBoA6U/d/mveX7XBwZVc1uNTGePMwShpr0oFvhgMZZADGSQZIj+ d9IgEDFwLCgtGhHwufG3PJz0h8EO7XjGTz8G3hIydmzKl5U3gaD83pYVNxot9qDRaZhsuixxDUagq OVKoTXTZaMz6YKm1uw80EWDy7rlCYxKZuN5X9Av90xpNznvQkSpGmZ73jQJ3CMQQlKIHSgUZgargG B1cdLqMH8EDfYSPnEWMQ5oPRthNuZuDjfLPlPPsu05hnp5nEYk8AHici0NMOsAJVkLbYB+zOduugb sn/hXxv7HWd8GHnzUw2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY6lG-00BT3m-3q; Tue, 13 Sep 2022 14:19:38 +0000 Received: from out1.migadu.com ([2001:41d0:2:863f::]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY6fx-00BOXm-PY for linux-arm-kernel@lists.infradead.org; Tue, 13 Sep 2022 14:14:13 +0000 Date: Tue, 13 Sep 2022 15:13:31 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1663078445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZPFqLXQVtTos2SUte3DUDBgyf6YiS7tm7cKDDgA0N3w=; b=STciCipNkB4of3Fnd53nVFMwkjhKPj5RNhREZST/rW7Zndkz9Q1rgPOII2bhl4Dn7ECkRw gH0J8LzcdhkWOzdz5QYahgKrbSniFilG2qsRAyogTYkSaHOA167CvMCzKaZ5My9JITDjq5 E5u/pzAgvEpJdi98hrWzuauhEODfbtA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Alexandru Elisei Cc: maz@kernel.org, Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: KVM/arm64: SPE: Translate VA to IPA on a stage 2 fault instead of pinning VM memory Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220913_071411_218409_E6BD349D X-CRM114-Status: GOOD ( 41.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 13, 2022 at 01:41:56PM +0100, Alexandru Elisei wrote: > Hi Oliver, > > On Tue, Sep 13, 2022 at 11:58:47AM +0100, Oliver Upton wrote: > > Hey Alex, > > > > On Mon, Sep 12, 2022 at 03:50:46PM +0100, Alexandru Elisei wrote: > > > > [...] > > > > > > Yeah, that would be good to follow up on what other OSes are doing. > > > > > > FreeBSD doesn't have a SPE driver. > > > > > > Currently in the process of finding out how/if Windows implements the > > > driver. > > > > > > > You'll still have a nondestructive S2 fault handler for the SPE, right? > > > > IOW, if PMBSR_EL1.DL=0 KVM will just unpin the old buffer and repin the > > > > new one. > > > > > > This is how I think about it: a S2 DABT where DL == 0 can happen because of > > > something that the VMM, KVM or the guest has done: > > > > > > 1. If it's because of something that the host's userspace did (memslot was > > > changed while the VM was running, memory was munmap'ed, etc). In this case, > > > there's no way for KVM to handle the SPE fault, so I would say that the > > > sensible approach would be to inject an SPE external abort. > > > > > > 2. If it's because of something that KVM did, that can only be because of a > > > bug in SPE emulation. In this case, it can happen again, which means > > > arbitrary blackout windows which can skew the profiling results. I would > > > much rather inject an SPE external abort then let the guest rely on > > > potentially bad profiling information. > > > > > > 3. The guest changes the mapping for the buffer when it shouldn't have: A. > > > when the architecture does allow it, but KVM doesn't support, or B. when > > > the architecture doesn't allow it. For both cases, I would much rather > > > inject an SPE external abort for the reasons above. Furthermore, for B, I > > > think it would be better to let the guest know as soon as possible that > > > it's not following the architecture. > > > > > > In conclusion, I would prefer to treat all SPE S2 faults as errors. > > > > My main concern with treating S2 faults as a synthetic external abort is > > how this behavior progresses in later versions of the architecture. > > SPEv1p3 disallows implementations from reporting external aborts via the > > SPU, instead allowing only for an SError to be delivered to the core. > > Ah, yes, missed that bit for SPEv1p3 (ARM DDI 0487H.a, page D10-5180). > > > > > I caught up with Will on this for a little bit: > > > > Instead of an external abort, how about reporting an IMP DEF buffer > > management event to the guest? At least for the Linux driver it should > > have the same effect of killing the session but the VM will stay > > running. This way there's no architectural requirement to promote to an > > SError. > > The only reason I proposed to inject an external abort is because KVM needs > a way to tell the guest that something outside of the guest's control went > wrong and it should drop the contents of the current profiling session. An > external abort reported by the SPU seemed to fit the bit. > > By IMP DEF buffer management event I assume you mean PMBSR_EL1.EC=0b011111 > (Buffer management event for an IMPLEMENTATION DEFINED reason). Yup, that's it. You also get two whole bytes of room in PMBSR_EL1.MSS which is also IMP DEF, so we could even stick some ASCII in there to tell the guest how we really feel! :-P > I'm thinking that someone might run a custom kernel in a VM, like a vendor > downstream kernel, with patches that actually handle this exception class, > and injecting such an exception might not have the effects that KVM > expects. Am I overthinking things? Is that something that KVM should take > into consideration? I suppose KVM can and should also set > PMBSR_EL1.DL = 1, as that means per the architecture that the buffer > contents should be discarded. I agree with you that PMBSR_EL1.DL=1 is the right call for this. With that, I'd be surprised if there was a guest that tried to pull some tricks other than blowing away the profile. The other option that I find funny is if we plainly report the S2 abort to the guest, but that wont work well when nested comes into the picture. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel