From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A66AFC6FA82 for ; Wed, 14 Sep 2022 15:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y4drGJqsXl3La4FnnnX+9EriAh7ghR7Y2keSAiRXNaU=; b=ETNnPEcwWBlS/t xFoRAsaAM4eNb25mnq1+DXmCKQgSrJByh1DKGIUpS6O4HaBwssUmkNKqOiNRB8S4FMiQNez74WCBH cZ0ZF+H58MPPvQXc9S3B5RvcGIEPzc/4fT0/fR0zGqLQnFDBqKtbx51v6HVD+25WiOeU66D5mHZFe QoD6h+5HNUOOJagF85/ba6i9U7BpItK632X1IUqan2cryVB9+tl7LobUELVxeVB2XcRJM+EhIfQ2A Rf9d/BM7ar0Z2mXzGc6e3D6uyEouxcqHmrQfCmX+l0yaw5jRWme0uiO0DPcbRV/7C4pIQntYc+2Iu ocOQerCzLUZXNXBGdj2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYUha-004MfE-86; Wed, 14 Sep 2022 15:53:26 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYUhW-004Md8-TE for linux-arm-kernel@lists.infradead.org; Wed, 14 Sep 2022 15:53:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Y2nENUJNda1WOPfbAiiYeaWd6fg5bfLU6YozHB10ABk=; b=t5yewRq8LgXr7pweKZSwjPBINP +Q8AIr9CBw27Sgr9NcCoemr/Zt9fQT7jIZqmIZQ4cX2vE8E32Njx6h1VWJ8+rlw7PVXL355Z+vIM0 CKFSe8CQrwaVplEMmikJ5nfHmb7yUcjH+/cUKCgcWYQHMkW2s8A/X8Wu6+6w2zIMhWlYfVVAvGgm7 sFGN0aO3mQuQ2kCJOJbDeFshnieU9TwOvgTk7wJzTxEWZaS6IyggpSbWRv25CTDqrZkfo+eHxx7lQ RvGjTJLiT7orwhuacVAfAkW2caxlak7GzY1YEvWoYevNAYcYoPC6CLszq4UmjbM4qYxSIqwa6cYBt gcVZUxRw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34326) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oYUhN-0004Ze-Lg; Wed, 14 Sep 2022 16:53:13 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oYUhM-0001mD-AA; Wed, 14 Sep 2022 16:53:12 +0100 Date: Wed, 14 Sep 2022 16:53:12 +0100 From: "Russell King (Oracle)" To: Siddharth Vadapalli Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski@linaro.org, krzysztof.kozlowski+dt@linaro.org, vladimir.oltean@nxp.com, grygorii.strashko@ti.com, vigneshr@ti.com, nsekhar@ti.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kishon@ti.com Subject: Re: [PATCH 3/8] net: ethernet: ti: am65-cpsw: Add mac control function Message-ID: References: <20220914095053.189851-1-s-vadapalli@ti.com> <20220914095053.189851-4-s-vadapalli@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220914095053.189851-4-s-vadapalli@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220914_085322_955536_12168314 X-CRM114-Status: GOOD ( 10.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 14, 2022 at 03:20:48PM +0530, Siddharth Vadapalli wrote: > Add function am65_cpsw_nuss_mac_control() corresponding to the mac > control register writes that are performed in the > am65_cpsw_nuss_mac_link_up() function and use it in the > am65_cpsw_nuss_mac_link_up() function. The newly added function will be > used in am65_cpsw_nuss_mac_config() function in a future patch, thereby > making it necessary to define a new function for the redundant mac control > operations. I think if you debug why you don't see mac_link_up called when in fixed-link mode, you won't need this change. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel