From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 740B3C6FA89 for ; Wed, 14 Sep 2022 15:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=llLt0X1jAN/DdvKq6B+qwCkkNyHJM/Du6vhwW9P8Z5s=; b=q6NG3SRe7oUUnD fn/M6dBGdxz74/YvxivMGrgv/YHS3aURol06pZwhqqK26tn5kjaEYuOVYi/W/PE72vPwGTfKaf0oN FYp7d+obmNwwmZ5tdloywM/uNcErkt/6kNDZecP5zT4RcXJ/MNrbSB6IimzI9Tcua8Iv4Y537cGe4 M85jweM1EImj3/a9S0t1n7IxKYW/dtIGWxPOFNcAHRGlXv67T3PCprPwFaBNnCCQhfiHg7R08Wxfs WLyg2hJpX9Y6k3t0OOY0FhaFzg368olagyUi/z7eLgJDKIox9aUXwonxmSk0VPb/IJ33KYHt3xXIR brCfphugnoGWEJdztKFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYUiR-004Npd-0S; Wed, 14 Sep 2022 15:54:19 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYUiN-004NkW-PJ for linux-arm-kernel@lists.infradead.org; Wed, 14 Sep 2022 15:54:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6ENqpZ1rhLgHpjcT3PmRqlF4gjvOUVH5mvvBR/bPYHo=; b=cO74HYqs6GJqXZtgFqaSIyeorm IFMq+32ym2GLMgV8kebbk0NkqM5ST1RkSnzZcAPjs8Bi5wFsIsYuqlVY42htpCF05R4fsLLGa1qti RQ9hEEnM5uoLxoCldpV+6+G27aVXu8Gckj0HUybnhwwqcFBMt938zEabaLyR6+5TEjtDIAM77jFJV MNeZDWyMTK/KvwUMpipF2s6ZrpY7zhO9vtS5lctG8qhRCP+rem1O6ZAG3PPELS2iEuEui81N2252O 6OVniWb/ivPn7l9JocGV6DwTMI/UvsC19meSj/WgY58ENTmJtzq6XTJpoJAsIW0epFZ3IIcJLBncl sTe67ZOQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34328) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oYUiH-0004Zt-2W; Wed, 14 Sep 2022 16:54:09 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oYUiG-0001mK-DU; Wed, 14 Sep 2022 16:54:08 +0100 Date: Wed, 14 Sep 2022 16:54:08 +0100 From: "Russell King (Oracle)" To: Siddharth Vadapalli Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski@linaro.org, krzysztof.kozlowski+dt@linaro.org, vladimir.oltean@nxp.com, grygorii.strashko@ti.com, vigneshr@ti.com, nsekhar@ti.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kishon@ti.com Subject: Re: [PATCH 4/8] net: ethernet: ti: am65-cpsw: Add mac enable link function Message-ID: References: <20220914095053.189851-1-s-vadapalli@ti.com> <20220914095053.189851-5-s-vadapalli@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220914095053.189851-5-s-vadapalli@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220914_085415_844970_8304C778 X-CRM114-Status: GOOD ( 10.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 14, 2022 at 03:20:49PM +0530, Siddharth Vadapalli wrote: > Add function am65_cpsw_nuss_mac_enable_link() to invoke > am65_cpsw_enable_phy(), cpsw_ale_control_set(), am65_cpsw_qos_link_up() > and netif_tx_wake_all_queues() to prevent duplicate code. The above > set of function calls are currently invoked by the > am65_cpsw_nuss_mac_link_up() function. In a later patch in this series > meant for adding fixed-link support, even the am65_cpsw_nuss_mac_config() > function will invoke the same set of functions. I don't think you will need this patch once you've debugged why mac_link_up() doesn't get called for a fixed link (it should be called.) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel