From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30F9CECAAD8 for ; Wed, 14 Sep 2022 12:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sn0Y4X6YL3B3ExTHew+VeEQCpS4GQWVxlrFDiQFACaA=; b=zg65cUgKqTDBnB ws7q6o9swBanPCvWfy3ex5AYwgqilIAIzmTHoGDDfMQkUacP8rjO8ifIsZ2jQ9FyKt23I1GDrYs33 2p8ZJsDqS+G5VActCPhJkYCl671LESJHJ5gulwatwdduD3/QfL0WODaQjSKzmQlbmLGobIfQCMpn0 doVQwyJuUALxV4B7JCTDD46QYlY46OJvLdZdv8u6uPq59+p6QqvF4GziMa9nGaCynhOXQpYdOg1kN TqpUkJxmW5q80XuN4LvqBUpwhcPEZ2pVZU61oVNaYNGxFlKFCw3Zi+0skV3yKTxMVQQmz+biQZZ+8 y5ilzZaesaqnEeVvTu7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYRZd-00HQUJ-D5; Wed, 14 Sep 2022 12:33:01 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYRZa-00HQNC-Ce for linux-arm-kernel@lists.infradead.org; Wed, 14 Sep 2022 12:32:59 +0000 Received: by mail-pf1-x42e.google.com with SMTP id d82so14756313pfd.10 for ; Wed, 14 Sep 2022 05:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=zV9/pNlaNjyK2el6e1fRNtIC3GGj80c975ZOZ3QDzu8=; b=fpjDhGArOd00NcVhciHxdWcYBZ4cGta3ByCHJ6wwiK3ZsL1+dcCyu5yaTH1dUc4RVo bJAnDB8HxETQ9AvtntRHw/L8aGAQ246/JDr48F+mINd4HtojNjF+yZIPFkU+dYFcKqY0 Jf5j3C1jnmbM8ouqSc2jCK/3uhy5mmXq97F7C2TOEPcm3Qxqsr+PxcNWJ3PV7+Fb+A/D lC58rhZRnzuoPFbwrk73LpPxsSwoyW3nj+HyQK1OtHuXrnTjJSDRUWwRUZ6gBeEopqSV 9DFSMcSYWp7Eui55jM/daGA9YXBP+W+QDIOb6uI73nTZj5sPTOBzbr15FvdYIScA9ruj JvBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=zV9/pNlaNjyK2el6e1fRNtIC3GGj80c975ZOZ3QDzu8=; b=ymXwTYyTdM2s8FNW4EY0DgNicf7fvsxLaovaZ7xfOz8s5GMm7omEDtZ+jkCHzzr1xD dnUiv+qjzrbak3zsnLc6ZBeBFYI5hLLmRGpy5ZEkqvmlh0fAtEGjWZeUp4G+UMEojzrE Dsh5yI+N8/P05r6CeqUdEH/7FUGREIn04gZm1W8YOFQnZcbBKuzdKDa68rSwrJTj+Ng3 7z89ueEbDANspc394AzTgEQjcAMY2W7pcVeFPUzkohcv5uv1uk6pZly7wSWCa/l3R2g5 DeLukNteFHjkyF7cT6Wo2bBAdZh02L/PL5cnuEZJpjfEqBCs0tstoukk2JtjHgpbUYO+ kecw== X-Gm-Message-State: ACgBeo0Yh0TRVysC0fjk66aQrUk7U1td2avKehTLlEp8kDJgtHIGerai CTgvylWIbVERVGbBksvHHD8= X-Google-Smtp-Source: AA6agR6tRNaPK5Q+XlGLTf7QBCvdF0OFTG9sr6Yo6lrI7k0fjU3OoTI+1Zk11+65m0d4cz9+PgI/zw== X-Received: by 2002:a05:6a00:3492:b0:540:b30d:8396 with SMTP id cp18-20020a056a00349200b00540b30d8396mr29749270pfb.81.1663158775134; Wed, 14 Sep 2022 05:32:55 -0700 (PDT) Received: from google.com ([2620:15c:202:201:2f68:fe7:a2e6:7595]) by smtp.gmail.com with ESMTPSA id w17-20020a656951000000b00438b79c7049sm8341581pgq.42.2022.09.14.05.32.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 05:32:54 -0700 (PDT) Date: Wed, 14 Sep 2022 05:32:51 -0700 From: Dmitry Torokhov To: Jerome Neanne Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, lee.jones@linaro.org, tony@atomide.com, afd@ti.com, khilman@baylibre.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v5 5/6] Input: Add tps65219 interrupt driven powerbutton Message-ID: References: <20220913121419.15420-1-jneanne@baylibre.com> <20220913121419.15420-6-jneanne@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220913121419.15420-6-jneanne@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220914_053258_442602_41052733 X-CRM114-Status: GOOD ( 10.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jerome, On Tue, Sep 13, 2022 at 02:14:18PM +0200, Jerome Neanne wrote: > + idev = devm_input_allocate_device(dev); > + if (!idev) > + return -ENOMEM; > + > + idev->name = pdev->name; > + snprintf(pwr->phys, sizeof(pwr->phys), "%s/input0", > + pdev->name); > + idev->phys = pwr->phys; > + idev->dev.parent = dev; This assignment is not needed given that devm_input_allocate_device() is used. Otherwise: Acked-by: Dmitry Torokhov Please feel free to merge through MFD tree. Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel