[PATCH 0/5] iommu: Define EINVAL as device/domain incompatibility

Nicolin Chen
2022-09-13T08:26:56Z

This series is to replace the previous EMEDIUMTYPE patch in a VFIO series:
https://lore.kernel.org/kvm/Yxnt9uQTmbqul5lf@8bytes.org/

The purpose is to regulate all existing ->attach_dev callback functions to
use EINVAL exclusively for an incompatibility error between a device and a
domain. This allows VFIO and IOMMUFD to detect such a soft error, and then
try a different domain with the same device.

Among the five patches, the first two are preparatory changes. And then a
patch to update kdocs and another two patches for the enforcement efforts.

Although it might be ideal to merge the previous VFIO series together with
this series, given the number of new changes, the review in the IOMMU list
might need a couple of rounds to finalize. Also, considering that v6.0 is
at rc5 now, perhaps we could merge this IOMMU series and the VFIO one in
different cycles to avoid merge conflicts. If there's less concern for it,
I can respin the finalized version of this series with the previous VFIO
one to merge together into the VFIO tree.

This series is also available on Github:
https://github.com/nicolinc/iommufd/commits/iommu_attach_dev

Thanks!

Nicolin Chen (5):
iommu/msm: Add missing __disable_clocks calls
iommu/amd: Drop unnecessary checks in amd_iommu_attach_device()
iommu: Add return errno rules to ->attach_dev ops
iommu: Regulate errno in ->attach_dev callback functions
iommu: Use EINVAL for incompatible device/domain in ->attach_dev

drivers/iommu/amd/iommu.c | 12 ++----------
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 13 ++-----------
drivers/iommu/arm/arm-smmu/arm-smmu.c | 7 ++-----
drivers/iommu/arm/arm-smmu/qcom_iommu.c | 9 ++-------
drivers/iommu/fsl_pamu.c | 6 +++---
drivers/iommu/fsl_pamu_domain.c | 4 ++--
drivers/iommu/intel/iommu.c | 10 +++-------
drivers/iommu/intel/pasid.c | 2 +-
drivers/iommu/ipmmu-vmsa.c | 4 +---
drivers/iommu/msm_iommu.c | 2 ++
drivers/iommu/mtk_iommu.c | 9 ++++++---
drivers/iommu/omap-iommu.c | 6 +++---
drivers/iommu/rockchip-iommu.c | 4 +++-
drivers/iommu/sprd-iommu.c | 4 +---
drivers/iommu/tegra-gart.c | 2 +-
drivers/iommu/tegra-smmu.c | 2 +-
drivers/iommu/virtio-iommu.c | 6 +++---
include/linux/iommu.h | 11 +++++++++++
18 files changed, 49 insertions(+), 64 deletions(-)

--
2.17.1